Skip to content

Add bulk create attribute function #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abnegate merged 7 commits into from
May 13, 2025
Merged

Add bulk create attribute function #581

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
dc35655
Add bulk create attribute function
abnegate May 13, 2025
c32da61
Fix ql check
abnegate May 13, 2025
cf1abba
Disable for SQLite
abnegate May 13, 2025
0cb4c09
Fix postgres
abnegate May 13, 2025
b29feb2
Move collection attribute append outside of validation
abnegate May 13, 2025
62166fe
Remove redundant document purge
abnegate May 13, 2025
a255d8e
Revert "Remove redundant document purge"
abnegate May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,8 @@
},
"config": {
"allow-plugins": {
"php-http/discovery": true,
"tbachert/spi": true
"php-http/discovery": false,
"tbachert/spi": false
Comment on lines -59 to +60

@abnegate abnegate May 13, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know why these were enabled here, they're a transitive dependency, we don't need them

}
}
}
72 changes: 36 additions & 36 deletions composer.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 0 additions & 10 deletions phpunit.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,4 @@
<directory>./tests/e2e/Adapter</directory>
</testsuite>
</testsuites>
<coverage processUncoveredFiles="true">
<include>
<directory suffix=".php">./src/</directory>
<directory suffix=".php">./tests/</directory>
</include>
<report>
<clover outputFile="tmp/clover.xml"/>
<html outputDirectory="tmp/coverage"/>
</report>
</coverage>
Comment on lines -19 to -28

@abnegate abnegate May 13, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're not using this because of split CI tests, but the report generation still happens, which slows tests down.

</phpunit>
20 changes: 19 additions & 1 deletion src/Database/Adapter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -536,6 +536,17 @@ abstract public function analyzeCollection(string $collection): bool;
*/
abstract public function createAttribute(string $collection, string $id, string $type, int $size, bool $signed = true, bool $array = false): bool;

/**
* Create Attributes
*
* @param string $collection
* @param array<array<string, mixed>> $attributes
* @return bool
* @throws TimeoutException
* @throws DuplicateException
*/
abstract public function createAttributes(string $collection, array $attributes): bool;

/**
* Update Attribute
*
Expand Down Expand Up @@ -988,6 +999,13 @@ abstract public function getSupportForReconnection(): bool;
*/
abstract public function getSupportForHostname(): bool;

/**
* Is creating multiple attributes in a single query supported?
*
* @return bool
*/
abstract public function getSupportForBatchCreateAttributes(): bool;

/**
* Get current attribute count from collection document
*
Expand Down Expand Up @@ -1094,7 +1112,7 @@ public function filter(string $value): string
return $value;
}

public function escapeWildcards(string $value): string
protected function escapeWildcards(string $value): string
{
$wildcards = [
'%',
Expand Down
Loading