-
Notifications
You must be signed in to change notification settings - Fork 19
Open
Description
Hi,
I was going through the code.
I have questions regarding the code in this file:
src/main/scala/tshrdlu/util/bridge.scala
- I understand that "def onStatus(status: Status) = actor ! status" is handled by the "Bot" actor.
Events like below are handled by which actor?
def onDeletionNotice(notice: StatusDeletionNotice) = actor ! notice
def onStallWarning(warning: StallWarning) = actor ! warning
- You have case classes defined for few other events. Instead of that could you not have just worked if you had left the implementations empty?
For example:
Instead of
def onTrackLimitationNotice(int: Int) = actor ! TrackLimitationNotice(int)
This would have worked fine too.
def onTrackLimitationNotice(int: Int) { /* Purposefully left Empty */ }
Is there something that I am missing?
Good Practice, maybe?
Metadata
Metadata
Assignees
Labels
No labels