test: fills unserializable

Author: skoshx

src/core/constants.ts

@@ -6,3 +6,10 @@ export const FLYTRAP_UNSERIALIZABLE_VALUE = 'FLYTRAP_UNSERIALIZABLE_VALUE'
 export const FLYTRAP_FUNCTION = 'FLYTRAP_FUNCTION'
 export const FLYTRAP_DOM_EVENT = 'FLYTRAP_DOM_EVENT'
 export const FLYTRAP_CIRCULAR = 'FLYTRAP_CIRCULAR'
+
+export const FLYTRAP_REPLACE_VALUES = [
+	FLYTRAP_UNSERIALIZABLE_VALUE,
+	FLYTRAP_FUNCTION,
+	FLYTRAP_DOM_EVENT,
+	FLYTRAP_CIRCULAR
+]

src/core/util.ts

@@ -1,5 +1,5 @@
 import { getLoadedConfig } from './config'
-import { FLYTRAP_UNSERIALIZABLE_VALUE } from './constants'
+import { FLYTRAP_REPLACE_VALUES, FLYTRAP_UNSERIALIZABLE_VALUE } from './constants'
 import { SourceType } from './types'
 
 /**
@@ -175,13 +175,14 @@ export function tryCatchSync<DType = unknown, EType = unknown>(
 // function fillMissingFlytrapValues(lackingObject: any, fullObject: any) {}
 
 type ReplaceValue = any
-type InputValue = ReplaceValue | typeof FLYTRAP_UNSERIALIZABLE_VALUE
+type InputValue = ReplaceValue | (typeof FLYTRAP_REPLACE_VALUES)[number]
 
 export function fillUnserializableFlytrapValues(
 	input: InputValue,
 	replaceValue: ReplaceValue
 ): ReplaceValue {
-	if (input === FLYTRAP_UNSERIALIZABLE_VALUE) {
+	// if (input === FLYTRAP_UNSERIALIZABLE_VALUE) {
+	if (FLYTRAP_REPLACE_VALUES.includes(input)) {
 		if (replaceValue === undefined) throw new Error(`Replace value is undefined.`)
 		return replaceValue
 	}

test/args.test.ts

@@ -1,32 +1,38 @@
 import { describe, expect, it } from 'vitest'
 import { fillUnserializableFlytrapValues } from '../src/core/util'
-import { FLYTRAP_UNSERIALIZABLE_VALUE } from '../src/core/constants'
+import { FLYTRAP_REPLACE_VALUES, FLYTRAP_UNSERIALIZABLE_VALUE } from '../src/core/constants'
 
 describe('Replay args', () => {
 	const mockReplaceValue = {
 		hello: 'world'
 	}
 
 	it('fills strings', () => {
-		expect(
-			fillUnserializableFlytrapValues(FLYTRAP_UNSERIALIZABLE_VALUE, 'hello world')
-		).toStrictEqual('hello world')
+		FLYTRAP_REPLACE_VALUES.forEach((replaceValue) => {
+			expect(fillUnserializableFlytrapValues(replaceValue, 'hello world')).toStrictEqual(
+				'hello world'
+			)
+		})
 	})
 
 	it('fills numbers', () => {
-		expect(fillUnserializableFlytrapValues(FLYTRAP_UNSERIALIZABLE_VALUE, 1)).toStrictEqual(1)
+		FLYTRAP_REPLACE_VALUES.forEach((replaceValue) => {
+			expect(fillUnserializableFlytrapValues(replaceValue, 1)).toStrictEqual(1)
+		})
 	})
 
 	it('fills arrays', () => {
-		expect(
-			fillUnserializableFlytrapValues([FLYTRAP_UNSERIALIZABLE_VALUE], [mockReplaceValue])
-		).toStrictEqual([mockReplaceValue])
-		expect(
-			fillUnserializableFlytrapValues(
-				[FLYTRAP_UNSERIALIZABLE_VALUE, FLYTRAP_UNSERIALIZABLE_VALUE],
-				[mockReplaceValue, mockReplaceValue]
-			)
-		).toStrictEqual([mockReplaceValue, mockReplaceValue])
+		FLYTRAP_REPLACE_VALUES.forEach((replaceValue) => {
+			expect(fillUnserializableFlytrapValues([replaceValue], [mockReplaceValue])).toStrictEqual([
+				mockReplaceValue
+			])
+			expect(
+				fillUnserializableFlytrapValues(
+					[replaceValue, replaceValue],
+					[mockReplaceValue, mockReplaceValue]
+				)
+			).toStrictEqual([mockReplaceValue, mockReplaceValue])
+		})
 	})
 
 	it('works with null and undefined', () => {
@@ -39,47 +45,45 @@ describe('Replay args', () => {
 	})
 
 	it('throws when matching keys not same shape', () => {
-		expect(() =>
-			fillUnserializableFlytrapValues(
-				{ hello: [FLYTRAP_UNSERIALIZABLE_VALUE] },
-				{ hello: mockReplaceValue }
-			)
-		).toThrow()
+		FLYTRAP_REPLACE_VALUES.forEach((replaceValue) => {
+			expect(() =>
+				fillUnserializableFlytrapValues({ hello: [replaceValue] }, { hello: mockReplaceValue })
+			).toThrow()
 
-		expect(() =>
-			fillUnserializableFlytrapValues(
-				{ hello: [FLYTRAP_UNSERIALIZABLE_VALUE], world: [] },
-				{ hello: [mockReplaceValue] }
-			)
-		).not.toThrow()
+			expect(() =>
+				fillUnserializableFlytrapValues(
+					{ hello: [replaceValue], world: [] },
+					{ hello: [mockReplaceValue] }
+				)
+			).not.toThrow()
 
-		expect(() =>
-			fillUnserializableFlytrapValues(
-				{ hello: FLYTRAP_UNSERIALIZABLE_VALUE, world: [] },
-				{ mockReplaceValue }
-			)
-		).toThrow()
+			expect(() =>
+				fillUnserializableFlytrapValues({ hello: replaceValue, world: [] }, { mockReplaceValue })
+			).toThrow()
+		})
 	})
 
 	it('fills objects', () => {
-		const lackingObj = { hello: FLYTRAP_UNSERIALIZABLE_VALUE, otherKey: '' }
-		expect(
-			fillUnserializableFlytrapValues(lackingObj, { hello: mockReplaceValue, otherKey: '' })
-		).toStrictEqual({
-			hello: mockReplaceValue,
-			otherKey: ''
-		})
+		FLYTRAP_REPLACE_VALUES.forEach((replaceValue) => {
+			const lackingObj = { hello: replaceValue, otherKey: '' }
+			expect(
+				fillUnserializableFlytrapValues(lackingObj, { hello: mockReplaceValue, otherKey: '' })
+			).toStrictEqual({
+				hello: mockReplaceValue,
+				otherKey: ''
+			})
 
-		const lackingObjDeep = {
-			hello: { world: { deep: FLYTRAP_UNSERIALIZABLE_VALUE } },
-			otherKey: ''
-		}
-		const fillObjDeep = { hello: { world: { deep: { hello: 'world' } } }, otherKey: '' }
-		const fillObjDeepWrong = { deep: { hello: 'world' } }
-		expect(fillUnserializableFlytrapValues(lackingObjDeep, fillObjDeep)).toStrictEqual({
-			...fillObjDeep,
-			otherKey: ''
+			const lackingObjDeep = {
+				hello: { world: { deep: replaceValue } },
+				otherKey: ''
+			}
+			const fillObjDeep = { hello: { world: { deep: { hello: 'world' } } }, otherKey: '' }
+			const fillObjDeepWrong = { deep: { hello: 'world' } }
+			expect(fillUnserializableFlytrapValues(lackingObjDeep, fillObjDeep)).toStrictEqual({
+				...fillObjDeep,
+				otherKey: ''
+			})
+			expect(() => fillUnserializableFlytrapValues(lackingObjDeep, fillObjDeepWrong)).toThrow()
 		})
-		expect(() => fillUnserializableFlytrapValues(lackingObjDeep, fillObjDeepWrong)).toThrow()
 	})
 })