Refactor
Linux.MonitorBlockCli in pkg/unikontainers/unikernels/linux.go contains a dead conditional inside its case "firecracker": switch arm. The if l.Monitor == "firecracker" is always true at that point, because the surrounding switch l.Monitor has already selected that case.
This is a code-quality/ readability issue only.
Location
pkg/unikontainers/unikernels/linux.go, around lines 171-181 (current main):
case "firecracker":
for _, aBlock := range l.Blk {
id := aBlock.ID
if l.Monitor == "firecracker" { // <-- always true here
id = "FC" + aBlock.ID
}
blkArgs = append(blkArgs, types.MonitorBlockArgs{
ID: id,
Path: aBlock.Source,
})
}
Refactor
Linux.MonitorBlockCliinpkg/unikontainers/unikernels/linux.gocontains a dead conditional inside itscase "firecracker":switch arm. Theif l.Monitor == "firecracker"is always true at that point, because the surroundingswitch l.Monitorhas already selected that case.This is a code-quality/ readability issue only.
Location
pkg/unikontainers/unikernels/linux.go, around lines 171-181 (currentmain):