Merge pull request #3 from upm-packages/feat/add_unitywebrequest_extension_methods

Add UnityWebRequest.ApplyDownloadHandler(), UnityWebRequest.ApplyUploadHandler()

Author: monry

Assets/CHANGELOG.md

@@ -1,5 +1,15 @@
 # Changelog
 
+## [0.0.1-preview.4] - 2019-09-06
+
+* Add extension methods
+
+### Improves
+
+* Add extension methods to UnityWebRequestExtensions
+    * Add `ApplyDownloadHandler` method
+    * Add `ApplyUploadHandler` method
+
 ## [0.0.1-preview.3] - 2019-09-05
 
 * Change namespace

Assets/README.md

@@ -12,6 +12,22 @@ upm add package dev.upm-packages.extraunityengine
 
 ### `UnityWebRequest`
 
+#### `ApplyDownloadHandler`
+
+```csharp
+public static UnityWebRequest ApplyDownloadHandler(this UnityWebRequest self, DownloadHandler downloadHandler) {}
+```
+
+Set DownloadHandler instance to UnityWebRequest instance via `downloadHandler` property.
+
+#### `ApplyUploadHandler`
+
+```csharp
+public static UnityWebRequest ApplyUploadHandler(this UnityWebRequest self, UploadHandler uploadHandler) {}
+```
+
+Set DownloadHandler instance to UnityWebRequest instance via `downloadHandler` property.
+
 #### `ApplyRequestBody`
 
 ```csharp

Assets/Scripts/UnityWebRequestExtensions.cs

@@ -9,25 +9,39 @@ namespace ExtraUnityEngine
     [PublicAPI]
     public static class UnityWebRequestExtensions
     {
+        public static UnityWebRequest ApplyDownloadHandler(this UnityWebRequest self, DownloadHandler downloadHandler)
+        {
+            if (downloadHandler != default)
+            {
+                self.downloadHandler = downloadHandler;
+            }
+
+            return self;
+        }
+
+        public static UnityWebRequest ApplyUploadHandler(this UnityWebRequest self, UploadHandler uploadHandler)
+        {
+            if (uploadHandler != default)
+            {
+                self.uploadHandler = uploadHandler;
+            }
+
+            return self;
+        }
+
         public static UnityWebRequest ApplyRequestBody(this UnityWebRequest self, string requestBody)
         {
-            return self.ApplyRequestBody(Encoding.UTF8.GetBytes(requestBody));
+            return string.IsNullOrEmpty(requestBody) ? self : self.ApplyRequestBody(Encoding.UTF8.GetBytes(requestBody));
         }
 
         public static UnityWebRequest ApplyRequestBody(this UnityWebRequest self, IEnumerable<byte> requestBody)
         {
-            return self.ApplyRequestBody(requestBody.ToArray());
+            return requestBody == null ? self : self.ApplyRequestBody(requestBody.ToArray());
         }
 
         public static UnityWebRequest ApplyRequestBody(this UnityWebRequest self, byte[] requestBody)
         {
-            if (requestBody == default)
-            {
-                return self;
-            }
-
-            self.uploadHandler = new UploadHandlerRaw(requestBody);
-            return self;
+            return requestBody == default ? self : self.ApplyUploadHandler(new UploadHandlerRaw(requestBody));
         }
 
         public static UnityWebRequest ApplyRequestHeader(this UnityWebRequest self, string name, string value)

Assets/package.json

@@ -1,7 +1,7 @@
 {
   "name": "dev.upm-packages.extraunityengine",
   "displayName": "Extra UnityEngine",
-  "version": "0.0.1-preview.3",
+  "version": "0.0.1-preview.4",
   "unity": "2019.2",
   "description": "Extensions to extend UnityEngine classes",
   "author": {

ProjectSettings/ProjectVersion.txt

@@ -1,2 +1,2 @@
-m_EditorVersion: 2019.2.3f1
-m_EditorVersionWithRevision: 2019.2.3f1 (8e55c27a4621)
+m_EditorVersion: 2019.2.4f1
+m_EditorVersionWithRevision: 2019.2.4f1 (c63b2af89a85)