Add Firefox support#1
Open
gwennlbh wants to merge 2 commits into
Open
Conversation
gwennlbh
force-pushed
the
main
branch
2 times, most recently
from
39f0eac to
c19ccce
Compare
Member
|
sponge - neat tool. Never ran across that before. Cool. I'll look at integrating this in some form. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for Firefox.
The only non-trivial difference to chrome is that each extension needs a unique Extension ID (otherwise they replace other versions).
To modify the
manifest.jsonfile, I had to usejq, and alsospongeto write jq's output in-place. I hope that these dependencies are common enough.I updated the Makefile to add a Makefile-level
$BROWSERvariable, that can be set tofirefoxorchrome