Resolve some issues with types #34
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solastley
requested review from
a team,
MattHsiung,
aaug1-unify and
samwaterbury
MattHsiung
approved these changes
Dec 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses two issues flagged here:
TrackEventPropertiesis currently incorrect. It is defined as an object containing a keyproperties, but in reality it should be the type of the value ofproperties(an object which accepts arbitrary keys and values).tscis complaining about usingunknownas the default type insafeParse. I cannot reproduce locally, but it seems reasonable to just make itstringinstead to resolve this.tscalso seems to be complaining about using ananytype asunknown- again, not able to reproduce it locally, but I made a change which I think will resolve this.Bumping a patch version because the new type of properties would not constitute a breaking change.