-
Notifications
You must be signed in to change notification settings - Fork 815
Remove warning from routing page #7632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Remove warning from routing page #7632
Conversation
This content appears to be accurate to be - let's review and confirm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your changes look good to me @Newnab 😉
I was wondering whether maybe the "info" frame about the importance of routes order should better be a "warning" frame instead of "info". As it is now, it looks more like a comment on the code above, so it does not really draw attention IMHO. What do you think?
leekelleher
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
sofietoft
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! 🙌
To reflect on @mikecp comment about how the note about the importants of the order is kinda hidden - how about we move it up, so it's shown BEFORE the code snippet? Then it's something you'll have to consider, before you even read to code.
What do you think?
|
Sounds like a very good solution to me @sofietoft 😊 |
Updated text for clarity and removed redundant hint.
Updated the wording for clarity and removed redundant hint.
|
@Newnab - I've moved the note above the code snippet. If you're also happy with that change, I'll get the PR merged 💪 |
|
@sofietoft I'm happy! Thank you. |
This content appears to be accurate to me for v16 and v17. Suggesting we remove the warning and consider it done, subject to wider approval from the docs team and HQ.
📋 Description
N/A
📎 Related Issues (if applicable)
#7601
✅ Contributor Checklist
I've followed the Umbraco Documentation Style Guide and can confirm that:
Product & Version (if relevant)
v16, v17
Deadline (if relevant)
N/A
📚 Helpful Resources