Skip to content

Conversation

@Newnab
Copy link

@Newnab Newnab commented Nov 18, 2025

This content appears to be accurate to me for v16 and v17. Suggesting we remove the warning and consider it done, subject to wider approval from the docs team and HQ.

📋 Description

N/A

📎 Related Issues (if applicable)

#7601

✅ Contributor Checklist

I've followed the Umbraco Documentation Style Guide and can confirm that:

  • Code blocks are correctly formatted.
  • Sentences are short and clear (preferably under 25 words).
  • Passive voice and first-person language (“we”, “I”) are avoided.
  • Relevant pages are linked.
  • All links work and point to the correct resources.
  • Screenshots or diagrams are included if useful.
  • Any code examples or instructions have been tested.
  • Typos, broken links, and broken images are fixed.

Product & Version (if relevant)

v16, v17

Deadline (if relevant)

N/A

📚 Helpful Resources

This content appears to be accurate to be - let's review and confirm.
Copy link
Contributor

@mikecp mikecp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your changes look good to me @Newnab 😉

I was wondering whether maybe the "info" frame about the importance of routes order should better be a "warning" frame instead of "info". As it is now, it looks more like a comment on the code above, so it does not really draw attention IMHO. What do you think?

@leekelleher leekelleher self-requested a review December 4, 2025 12:02
Copy link
Member

@leekelleher leekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@sofietoft sofietoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🙌

To reflect on @mikecp comment about how the note about the importants of the order is kinda hidden - how about we move it up, so it's shown BEFORE the code snippet? Then it's something you'll have to consider, before you even read to code.
What do you think?

@mikecp
Copy link
Contributor

mikecp commented Dec 5, 2025

Sounds like a very good solution to me @sofietoft 😊

Updated text for clarity and removed redundant hint.
Updated the wording for clarity and removed redundant hint.
@sofietoft
Copy link
Contributor

@Newnab - I've moved the note above the code snippet.

If you're also happy with that change, I'll get the PR merged 💪

@Newnab
Copy link
Author

Newnab commented Dec 5, 2025

@sofietoft I'm happy! Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants