diff --git a/example/pubspec.lock b/example/pubspec.lock index 4a584c07..d3839742 100644 --- a/example/pubspec.lock +++ b/example/pubspec.lock @@ -14,7 +14,7 @@ packages: name: async url: "https://pub.dartlang.org" source: hosted - version: "2.5.0" + version: "2.6.1" boolean_selector: dependency: transitive description: @@ -263,7 +263,7 @@ packages: name: source_span url: "https://pub.dartlang.org" source: hosted - version: "1.8.0" + version: "1.8.1" stack_trace: dependency: transitive description: @@ -298,7 +298,7 @@ packages: name: test_api url: "https://pub.dartlang.org" source: hosted - version: "0.2.19" + version: "0.3.0" typed_data: dependency: transitive description: @@ -371,4 +371,4 @@ packages: version: "0.2.0" sdks: dart: ">=2.12.0 <3.0.0" - flutter: ">=2.0.0" + flutter: ">=2.2.0" diff --git a/pubspec.yaml b/pubspec.yaml index 3d278f37..338acda8 100644 --- a/pubspec.yaml +++ b/pubspec.yaml @@ -7,7 +7,7 @@ issue_tracker: https://github.com/ueman/feedback/issues environment: sdk: '>=2.12.0 <3.0.0' - flutter: '>=2.0.0' + flutter: '>=2.2.0' dependencies: flutter: diff --git a/test/golden_image_test.dart b/test/golden_image_test.dart index 4ac4d4f6..c3259683 100644 --- a/test/golden_image_test.dart +++ b/test/golden_image_test.dart @@ -1,3 +1,5 @@ +import 'dart:io'; + import 'package:feedback/feedback.dart'; import 'package:flutter/material.dart'; import 'package:flutter_test/flutter_test.dart'; @@ -16,8 +18,10 @@ void main() { await tester.pumpWidget(widget); await tester.pumpAndSettle(); - await expectLater(find.byType(BetterFeedback), - matchesGoldenFile('golden_images/closed_feedback.png')); + await expectLater( + find.byType(BetterFeedback), + matchesGoldenFile( + 'golden_images/closed_feedback-$_platformString.png')); }); testWidgets(' open feedback', (tester) async { @@ -34,8 +38,26 @@ void main() { await tester.tap(openFeedbackButton); await tester.pumpAndSettle(); - await expectLater(find.byType(BetterFeedback), - matchesGoldenFile('golden_images/open_feedback.png')); + await expectLater( + find.byType(BetterFeedback), + matchesGoldenFile( + 'golden_images/open_feedback-$_platformString.png')); }); - }); + }, skip: _skipMessage); +} + +String? get _platformString { + if (Platform.isWindows) { + return 'windows'; + } + if (Platform.isMacOS) { + return 'macos'; + } + return null; } + +String? get _skipMessage => _platformString != null + ? null + : 'Golden image tests are platform specific. $_platformString is not ' + 'currently supported. Please create a PR against ' + 'https://github.com/ueman/feedback to add golden images for your platform.'; diff --git a/test/golden_images/closed_feedback.png b/test/golden_images/closed_feedback-macos.png similarity index 100% rename from test/golden_images/closed_feedback.png rename to test/golden_images/closed_feedback-macos.png diff --git a/test/golden_images/closed_feedback-windows.png b/test/golden_images/closed_feedback-windows.png new file mode 100644 index 00000000..af9ef346 Binary files /dev/null and b/test/golden_images/closed_feedback-windows.png differ diff --git a/test/golden_images/open_feedback.png b/test/golden_images/open_feedback-macos.png similarity index 100% rename from test/golden_images/open_feedback.png rename to test/golden_images/open_feedback-macos.png diff --git a/test/golden_images/open_feedback-windows.png b/test/golden_images/open_feedback-windows.png new file mode 100644 index 00000000..7586e118 Binary files /dev/null and b/test/golden_images/open_feedback-windows.png differ