Sinclair Broadcast Group (katv.com/ktul.com/komonews.com/kfdm.com/wjla.com/etc.) - ads

[Hebrew-uBO-User]

Prerequisites

• This is NOT a YouTube, Facebook, Twitch or a shortener/hosting site report. These sites MUST be reported by clicking their respective links.
• I read and understand the policy about what is a valid filter issue.
• I verified that this issue is not a duplicate. (Use this button to find out.). Comment in the old issue threads even when they are closed or even if you have a different problem.
• I did not remove any of the default filter lists, or I have verified that the issue was not caused by removing any of the default lists.
• I did not enable additional or non-default filter lists, or I have identified which specific stock list is causing the issue.
• I do not have custom filters/rules, or I have verified that the issue still occurs without custom filters/rules.
• I have verified that the web browser's built-in content blocker/tracking protection, network wide/DNS blocking, or my VPN is not causing the issue.
• I have turned off all other extensions and the issue still persists. (exception "Firefox Multi-Account Containers").
• If this is about a breakage or detection, I have verified that it is caused by uBlock Origin and isn't a site or browser issue.
• I have verified that the browser I am using is up to date with no pending updates.
• I did not answer truthfully to ALL the above checkboxes.

URL(s) where the issue occurs.

https://katv.com/

Description

https://en.wikipedia.org/wiki/Sinclair_Broadcast_Group

Some generic cosmetic filters don't work for some reason.
For example: ##.style_medTopAdsWrapper__rd6bz (already in EasyList, big top placeholder on homepage).

---

By the way, more filters are needed:

##.StoryPage_storyTopAdContainer__6udZ0
##.PrimisMidArticleAdUnit_primisWrapper__G3UAH
##.DisplayAd_Native__XCll3
##.RightRailPanelAd_noPanelSmall__7yQ1M
##.PhotoGalleryBarSlider_adItem__sUMSS
##.TaboolaHomepageFeed_taboolaWrapper__dtrdt
##.TaboolaMoreToExplore_taboolaContainerWrapper__Ccf_j
##.TaboolaVideoReel_videoReelContainer__n_Egg

@ryanbr

Browser name and version

Firefox / Chromium
uBlock Origin
(latest stable)

Other extensions used

none

Country

No response

Screenshot(s)

Screenshot(s)

Configuration

Details

[mapx-]

needing specific filter

katv.com,ktul.com,komonews.com,kfdm.com,wjla.com##.style_medTopAdsWrapper__rd6bz

[ryanbr]

https://github.com/easylist/easylist/blob/master/easylist/easylist_general_hide.txt#L13251

[mapx-]

@ryanbr see above => it does not work, needing specific cosmetic filter
@gorhill

[ryanbr]

Why doesn't it work?

[gorhill]

It's a case like this: gorhill/uBlock#1885, i.e. if I uncomment those two lines, the issue goes away.

[gorhill]

I will make it so that class and id attribute changes are listened up to when the page is fully loaded. I tested and this solves the issue here. It's a compromise between not listening at all to any class/id changes and listening all time to class/id changes.

[stephenhawk8054]

@gorhill Would it affect the performance if listening all the time in MutationObserver?

[gorhill]

The issue with listening to attribute changes in the current state of the code is that for example a change of class or id attribute on the body element will cause the surveyor to query all the elements with class/id for body element and all its descendants, which could be easily in the hundreds. The fix is to stop relying on the generic DOM mutation observer used by many parts of the content script (blocked resource collapser, logger. procedural cosmetic filterer, etc.) and have one designed specifically for the surveyor, where a change in class or id will cause only the specific class or id changed to be looked up. I currently have a fix on my side and this does avoid the costly pointless surveying of all descendants.

[Hebrew-uBO-User]

@ryanbr
@mapx-
There are over 100 domains...
https://en.wikipedia.org/wiki/Sinclair_Broadcast_Group

##[class="style_medTopAdsWrapper__rd6bz"] works fine on my end (as a generic cosmetic filter).

[gorhill]

This is fixed in latest uBOL release. There will be a fix for uBO in the next dev build.

[uBlock-user]

Same issue I face with speed.cloudflare.com with a generic ##.react-share__ShareButton