Skip to content

Commit cde1d47

Browse files
simonihmigchriskrycho
authored andcommitted
Add blueprint support for ember-mocha
Brings blueprints on par with ember-cli-qunit/ember-qunit, supporting ember-mocha, which will supercede ember-cli-mocha.
1 parent 28059eb commit cde1d47

File tree

2 files changed

+76
-34
lines changed

2 files changed

+76
-34
lines changed

ts/blueprints/ember-cli-typescript/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ module.exports = {
147147
]);
148148
}
149149

150-
if (this._has('ember-cli-mocha')) {
150+
if (this._has('ember-cli-mocha') || this._has('ember-mocha')) {
151151
packages = packages.concat([
152152
{ name: '@types/ember-mocha', target: 'latest' },
153153
{ name: '@types/mocha', target: 'latest' },

ts/tests/blueprints/ember-cli-typescript-test.js

Lines changed: 75 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -366,43 +366,85 @@ describe('Acceptance: ember-cli-typescript generator', function() {
366366
});
367367
});
368368

369-
it('app with Mocha', function() {
370-
const args = ['ember-cli-typescript'];
369+
describe('ember-mocha', function() {
370+
it('app with ember-cli-mocha', function() {
371+
const args = ['ember-cli-typescript'];
371372

372-
return helpers
373-
.emberNew()
374-
.then(() => helpers.modifyPackages([
375-
{ name: 'ember-cli-mocha', dev: true },
376-
{ name: 'ember-qunit', delete: true }
377-
]))
378-
.then(() => helpers.emberGenerate(args))
379-
.then(() => {
380-
const pkg = file('package.json');
381-
expect(pkg).to.exist;
373+
return helpers
374+
.emberNew()
375+
.then(() => helpers.modifyPackages([
376+
{ name: 'ember-cli-mocha', dev: true },
377+
{ name: 'ember-qunit', delete: true }
378+
]))
379+
.then(() => helpers.emberGenerate(args))
380+
.then(() => {
381+
const pkg = file('package.json');
382+
expect(pkg).to.exist;
382383

383-
const pkgJson = JSON.parse(pkg.content);
384-
expect(pkgJson.devDependencies).to.include.all.keys('@types/ember-mocha', '@types/mocha');
385-
expect(pkgJson.devDependencies).to.not.have.any.keys('@types/ember-qunit', '@types/qunit');
386-
});
387-
});
384+
const pkgJson = JSON.parse(pkg.content);
385+
expect(pkgJson.devDependencies).to.include.all.keys('@types/ember-mocha', '@types/mocha');
386+
expect(pkgJson.devDependencies).to.not.have.any.keys('@types/ember-qunit', '@types/qunit');
387+
});
388+
});
388389

389-
it('addon with Mocha', function() {
390-
const args = ['ember-cli-typescript'];
390+
it('app with ember-mocha', function() {
391+
const args = ['ember-cli-typescript'];
391392

392-
return helpers
393-
.emberNew({ target: 'addon' })
394-
.then(() => helpers.modifyPackages([
395-
{ name: 'ember-cli-mocha', dev: true },
396-
{ name: 'ember-qunit', delete: true }
397-
]))
398-
.then(() => helpers.emberGenerate(args))
399-
.then(() => {
400-
const pkg = file('package.json');
401-
expect(pkg).to.exist;
393+
return helpers
394+
.emberNew()
395+
.then(() => helpers.modifyPackages([
396+
{ name: 'ember-mocha', dev: true },
397+
{ name: 'ember-qunit', delete: true }
398+
]))
399+
.then(() => helpers.emberGenerate(args))
400+
.then(() => {
401+
const pkg = file('package.json');
402+
expect(pkg).to.exist;
402403

403-
const pkgJson = JSON.parse(pkg.content);
404-
expect(pkgJson.devDependencies).to.include.all.keys('@types/ember-mocha', '@types/mocha');
405-
expect(pkgJson.devDependencies).to.not.have.any.keys('@types/ember-qunit', '@types/qunit');
406-
});
404+
const pkgJson = JSON.parse(pkg.content);
405+
expect(pkgJson.devDependencies).to.include.all.keys('@types/ember-mocha', '@types/mocha');
406+
expect(pkgJson.devDependencies).to.not.have.any.keys('@types/ember-qunit', '@types/qunit');
407+
});
408+
});
409+
410+
it('addon with ember-cli-mocha', function() {
411+
const args = ['ember-cli-typescript'];
412+
413+
return helpers
414+
.emberNew({ target: 'addon' })
415+
.then(() => helpers.modifyPackages([
416+
{ name: 'ember-cli-mocha', dev: true },
417+
{ name: 'ember-qunit', delete: true }
418+
]))
419+
.then(() => helpers.emberGenerate(args))
420+
.then(() => {
421+
const pkg = file('package.json');
422+
expect(pkg).to.exist;
423+
424+
const pkgJson = JSON.parse(pkg.content);
425+
expect(pkgJson.devDependencies).to.include.all.keys('@types/ember-mocha', '@types/mocha');
426+
expect(pkgJson.devDependencies).to.not.have.any.keys('@types/ember-qunit', '@types/qunit');
427+
});
428+
});
429+
430+
it('addon with ember-mocha', function() {
431+
const args = ['ember-cli-typescript'];
432+
433+
return helpers
434+
.emberNew({ target: 'addon' })
435+
.then(() => helpers.modifyPackages([
436+
{ name: 'ember-mocha', dev: true },
437+
{ name: 'ember-qunit', delete: true }
438+
]))
439+
.then(() => helpers.emberGenerate(args))
440+
.then(() => {
441+
const pkg = file('package.json');
442+
expect(pkg).to.exist;
443+
444+
const pkgJson = JSON.parse(pkg.content);
445+
expect(pkgJson.devDependencies).to.include.all.keys('@types/ember-mocha', '@types/mocha');
446+
expect(pkgJson.devDependencies).to.not.have.any.keys('@types/ember-qunit', '@types/qunit');
447+
});
448+
});
407449
});
408450
});

0 commit comments

Comments
 (0)