Skip to content
This repository was archived by the owner on Nov 16, 2021. It is now read-only.
This repository was archived by the owner on Nov 16, 2021. It is now read-only.

Nil exception happening after connection is open for a while #42

@ianloblaw

Description

@ianloblaw

Hello,

Recently I was trying to run version 0.8.2 to connect to scribe, after a few hours I noticed that the connection dies (seemingly on the ruby end) and results in the following exception

undefined method write' for nil:NilClass ruby/1.9.1/gems/thrift_client-0.8.2/lib/thrift_client/server.rb:82:inwrite'
ruby/1.9.1/gems/thrift-0.8.0/lib/thrift/protocol/binary_protocol.rb:91:in write_i16' ruby/1.9.1/gems/thrift-0.8.0/lib/thrift/protocol/binary_protocol.rb:43:inwrite_message_begin'
ruby/1.9.1/gems/thrift-0.8.0/lib/thrift/client.rb:29:in `send_message'

This seems to be related to line 60 of server.rb

return nil unless @connection

Unfortunately I haven't figured out why the connection is becoming nil, but it seems to be internal to the gem.

I am not sure if the closing of the connection is expected behavior or not, but I think anyone can agree that exception's relating to calls on nil aren't a sensible way dealing with an error case.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions