Just checking to see if the signature change on Dial.sip was intentional and is safe to proceed with the new implementation.
Previous:
|
def sip(sip_url, username: nil, password: nil, url: nil, method: nil, status_callback_event: nil, status_callback: nil, status_callback_method: nil, machine_detection: nil, amd_status_callback_method: nil, amd_status_callback: nil, machine_detection_timeout: nil, machine_detection_speech_threshold: nil, machine_detection_speech_end_threshold: nil, machine_detection_silence_timeout: nil, **keyword_args) |
def sip(sip_url, username: nil, password: nil, url: nil, method: nil, status_callback_event: nil, status_callback: nil, status_callback_method: nil, machine_detection: nil, amd_status_callback_method: nil, amd_status_callback: nil, machine_detection_timeout: nil, machine_detection_speech_threshold: nil, machine_detection_speech_end_threshold: nil, machine_detection_silence_timeout: nil, **keyword_args)
Current:
https://github.com/twilio/twilio-ruby/blob/main/lib/twilio-ruby/twiml/voice_response.rb#L1767
def sip(sip_url: nil, username: nil, password: nil, url: nil, method: nil, status_callback_event: nil, status_callback: nil, status_callback_method: nil, machine_detection: nil, amd_status_callback_method: nil, amd_status_callback: nil, machine_detection_timeout: nil, machine_detection_speech_threshold: nil, machine_detection_speech_end_threshold: nil, machine_detection_silence_timeout: nil, **keyword_args)
Notice the keyword arg for sip_url vs a positional arg.
Just checking to see if the signature change on
Dial.sipwas intentional and is safe to proceed with the new implementation.Previous:
twilio-ruby/lib/twilio-ruby/twiml/voice_response.rb
Line 1767 in d5a84f2
Current:
https://github.com/twilio/twilio-ruby/blob/main/lib/twilio-ruby/twiml/voice_response.rb#L1767
Notice the keyword arg for
sip_urlvs a positional arg.