Fix build

Author: koen-serry

.github/workflows/maven-build.yml

@@ -7,7 +7,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        java-version: [ 11 ]
+        java-version: [ 17 ]
 
     permissions:
       contents: read
@@ -22,7 +22,7 @@ jobs:
         java-version: ${{ matrix.java-version }}
 
     - name: Cache Maven packages
-      uses: actions/cache@v1
+      uses: actions/cache@v4
       with:
         path: ~/.m2
         key: ${{ runner.os }}-m2-${{ hashFiles('**/pom.xml') }}

pom.xml

@@ -61,13 +61,13 @@
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-surefire-plugin</artifactId>
-                <version>3.0.0-M5</version>
+                <version>3.5.3</version>
                 <configuration>
                     <runOrder>alphabetical</runOrder>
                     <useSystemClassLoader>false</useSystemClassLoader>
                     <redirectTestOutputToFile>true</redirectTestOutputToFile>
                     <reportFormat>plain</reportFormat>
-                    <systemProperties>
+                    <systemPropertyVariables>
                         <property>
                             <name>java.io.tmpdir</name>
                             <value>target</value>
@@ -80,7 +80,7 @@
                             <name>user.region</name>
                             <value>en</value>
                         </property>
-                    </systemProperties>
+                    </systemPropertyVariables>
                 </configuration>
             </plugin>
             <plugin>

src/main/java/com/twikey/modal/DocumentResponse.java

@@ -145,7 +145,7 @@ public static Document fromJson(JSONObject json, String state) {
             resp.debtorEmail = ctct.optString("EmailAdr");
             resp.customerNumber = ctct.optString("Othr");
 
-            resp.iban = mndt.getString("DbtrAcct");
+            resp.iban = mndt.optString("DbtrAcct");
 
             JSONObject agent = mndt.getJSONObject("DbtrAgt").getJSONObject("FinInstnId");
             resp.bic = agent.getString("BICFI");

src/test/java/com/twikey/DocumentGatewayTest.java

@@ -17,6 +17,7 @@ public class DocumentGatewayTest {
     private final String apiKey = System.getenv("TWIKEY_API_KEY"); // found in https://www.twikey.com/r/admin#/c/settings/api
 
     private final String _ct = System.getenv("CT"); // found @ https://www.twikey.com/r/admin#/c/template
+    private final String mndtNumber = System.getenv("MNDTNUMBER");
 
     private Long ct;
 
@@ -84,9 +85,9 @@ public void testSignMandate() throws Exception, TwikeyClient.UserException {
     }
 
     @Test
-    public void testAction() throws IOException, TwikeyClient.UserException, InterruptedException {
+    public void testAction() throws IOException, TwikeyClient.UserException {
         Assume.assumeTrue("APIKey is set", apiKey != null);
-        MandateActionRequest action = new MandateActionRequest(MandateActionRequest.MandateActionType.REMINDER, "CORERECURRENTNL18166")
+        MandateActionRequest action = new MandateActionRequest(MandateActionRequest.MandateActionType.REMINDER, mndtNumber)
                 .setReminder(1);
         api.document().action(action);
     }
@@ -116,28 +117,28 @@ public void testCancel() throws Exception, TwikeyClient.UserException {
     @Test
     public void testFetch() throws Exception, TwikeyClient.UserException {
         Assume.assumeTrue("APIKey is set", apiKey != null);
-        MandateDetailRequest fetch = new MandateDetailRequest("CORERECURRENTNL18166")
+        MandateDetailRequest fetch = new MandateDetailRequest(mndtNumber)
                 .setForce(true);
         DocumentResponse.Document response = api.document().fetch(fetch);
         assertNotNull("Document Reference", response.getMandateNumber());
     }
 
     @Test
-    public void testUpdateMandate() throws IOException, TwikeyClient.UserException, InterruptedException {
+    public void testUpdateMandate() throws IOException, TwikeyClient.UserException {
         Assume.assumeTrue("APIKey is set", apiKey != null);
-        UpdateMandateRequest update = new UpdateMandateRequest("CORERECURRENTNL18166", customer, account);
+        UpdateMandateRequest update = new UpdateMandateRequest(mndtNumber, customer, account);
         api.document().update(update);
     }
 
     @Test
-    public void testCustomerAccess() throws IOException, TwikeyClient.UserException, InterruptedException {
+    public void testCustomerAccess() throws IOException, TwikeyClient.UserException {
         Assume.assumeTrue("APIKey is set", apiKey != null);
-        DocumentResponse.CustomerAccessResponse response = api.document().customerAccess("CORERECURRENTNL18166");
+        DocumentResponse.CustomerAccessResponse response = api.document().customerAccess(mndtNumber);
         assertNotNull("Document Customer Url", response.getUrl());
     }
 
     @Test
-    public void testRetrievePdf() throws IOException, TwikeyClient.UserException, InterruptedException {
+    public void testRetrievePdf() throws IOException, TwikeyClient.UserException {
         Assume.assumeTrue("APIKey is set", apiKey != null);
         DocumentResponse.PdfResponse retrievedPdf = api.document().retrievePdf("CORERECURRENTNL18247");
         retrievedPdf.save("target/pdf.pdf");

src/test/java/com/twikey/RefundGatewayTest.java

@@ -14,6 +14,7 @@
 public class RefundGatewayTest {
 
     private final String apiKey = System.getenv("TWIKEY_API_KEY"); // found in https://www.twikey.com/r/admin#/c/settings/api
+    private final String iban = System.getenv("REFUND_IBAN"); // found in https://www.twikey.com/r/admin#/c/settings/api
 
     private final String ct = System.getenv("CT");
 
@@ -37,8 +38,8 @@ public void createCustomer(){
                 .setLang("nl")
                 .setMobile("32498665995");
 
-        account = new DocumentRequests.Account("NL46ABNA8910219718", "ABNANL2A");
-
+        Assume.assumeTrue("IBAN is set", iban != null);
+        account = new DocumentRequests.Account(iban, "ABNANL2A");
         api = new TwikeyClient(apiKey)
                 .withTestEndpoint()
                 .withUserAgent("twikey-api-java/junit");