From 174fc5b53ce7e58a192f4ec63f57d5eb4756d24e Mon Sep 17 00:00:00 2001
From: Lorenz Sieben <me@lorenz-sieben.com>
Date: Fri, 6 Dec 2024 16:50:11 +0100
Subject: [PATCH 1/4] Change schema to cache computed properties in the
 database

---
 dbschema/default.esdl                    | 128 +++++++++++++++++------
 dbschema/migrations/00005-m1smzp7.edgeql | 111 ++++++++++++++++++++
 2 files changed, 205 insertions(+), 34 deletions(-)
 create mode 100644 dbschema/migrations/00005-m1smzp7.edgeql

diff --git a/dbschema/default.esdl b/dbschema/default.esdl
index 9cad41a..9a7a42c 100644
--- a/dbschema/default.esdl
+++ b/dbschema/default.esdl
@@ -3,6 +3,30 @@ module default {
     scalar type AnalysisType extending enum<initial, second>;
     scalar type ControllerResponse extending enum<promise, denial, none>;
     scalar type ComplaintType extending enum<formal, informal>;
+    scalar type ProceedingState extending
+        enum<erased,
+            expired,
+            needsInitialAnalysis,
+            initialAnalysisFailed,
+            initialAnalysisFoundNothing,
+            awaitingControllerNotice,
+            awaitingControllerResponse,
+            needsSecondAnalysis,
+            secondAnalysisFailed,
+            secondAnalysisFoundNothing,
+            awaitingComplaint,
+            complaintSent>;
+    scalar type ComplaintState extending
+        enum<notYet,
+            askIsUserOfApp,
+            askAuthority,
+            askComplaintType,
+            askUserNetworkActivity,
+            askLoggedIntoAppStore,
+            askDeviceHasRegisteredSimCard,
+            askDeveloperAddress,
+            readyToSend>;
+
 
     abstract type CreatedOn {
         required property createdOn: datetime {
@@ -26,7 +50,9 @@ module default {
     }
 
     type Analysis {
-        required proceeding: Proceeding { on target delete delete source; };
+        single proceeding :=
+            .<initialAnalysis[is Proceeding] if .type = AnalysisType.initial else
+            .<secondAnalysis[is Proceeding];
         required type: AnalysisType;
 
         required startDate: datetime;
@@ -37,10 +63,14 @@ module default {
 
         required har: str { constraint max_size_bytes(52428800); };
         required trackHarResult: json;
+        required foundTrackers: bool {
+            rewrite insert, update using (
+                any(std::json_typeof(json_array_unpack(.trackHarResult)) != 'null') if __specified__.trackHarResult else .foundTrackers
+            );
+            default := false;
+        }
 
         single app := .proceeding.app;
-
-        constraint exclusive on ((.proceeding, .type));
     }
 
     type Proceeding extending CreatedOn {
@@ -55,42 +85,62 @@ module default {
         developerAddressSourceUrl: str { constraint max_len_value(200); };
         privacyPolicyUrl: str { constraint max_len_value(250); };
 
-        required state := (
-            'erased' if exists(.erased) else
-            'expired' if exists(.expired) else
-            'needsInitialAnalysis' if not exists(.initialAnalysis) and exists(.requestedAnalysis) else
-            'initialAnalysisFailed' if not exists(.initialAnalysis) and not exists(.requestedAnalysis) else
-            'initialAnalysisFoundNothing' if all(std::json_typeof(json_array_unpack(.initialAnalysis.trackHarResult)) = 'null') else
-            'awaitingControllerNotice' if not exists(.noticeSent) and any(std::json_typeof(json_array_unpack(.initialAnalysis.trackHarResult)) != 'null') else
-            'awaitingControllerResponse' if not exists(.controllerResponse) else
-            'needsSecondAnalysis' if not exists(.secondAnalysis) and exists(.requestedAnalysis) else
-            'secondAnalysisFailed' if not exists(.secondAnalysis) and not exists(.requestedAnalysis) else
-            'secondAnalysisFoundNothing' if all(std::json_typeof(json_array_unpack(.secondAnalysis.trackHarResult)) = 'null') else
-            'awaitingComplaint' if not exists(.complaintSent) and any(std::json_typeof(json_array_unpack(.secondAnalysis.trackHarResult)) != 'null') else
-            'complaintSent'
-        );
-        required stateUpdatedOn: datetime {
-            rewrite update using (
-                datetime_of_statement()
-                if __specified__.state and __old__.state != __subject__.state
-                else __old__.stateUpdatedOn
+        required state: ProceedingState {
+            rewrite insert, update using (
+                ProceedingState.erased if exists(.erased) else
+                ProceedingState.expired if exists(.expired) else
+                ProceedingState.needsInitialAnalysis if not exists(.initialAnalysis) and exists(.requestedAnalysis) else
+                ProceedingState.initialAnalysisFailed if not exists(.initialAnalysis) and not exists(.requestedAnalysis) else
+                ProceedingState.initialAnalysisFoundNothing if not .initialAnalysis.foundTrackers else
+                ProceedingState.awaitingControllerNotice if not exists(.noticeSent) and .initialAnalysis.foundTrackers else
+                ProceedingState.awaitingControllerResponse if not exists(.controllerResponse) else
+                ProceedingState.needsSecondAnalysis if not exists(.secondAnalysis) and exists(.requestedAnalysis) else
+                ProceedingState.secondAnalysisFailed if not exists(.secondAnalysis) and not exists(.requestedAnalysis) else
+                ProceedingState.secondAnalysisFoundNothing if not .secondAnalysis.foundTrackers else
+                ProceedingState.awaitingComplaint if not exists(.complaintSent) and .secondAnalysis.foundTrackers else
+                ProceedingState.complaintSent
             );
-            default := datetime_current();
+            default := ProceedingState.needsInitialAnalysis;
         };
+
+        trigger logStateUpdate after update for each
+        when (__old__.state != __new__.state)
+        do (
+            update ProceedingUpdateLog filter .proceeding = __new__ set {
+                stateUpdatedOn := datetime_of_statement()
+            }
+        );
+
+        trigger createUpdateLog after insert for each
+        do (
+            insert ProceedingUpdateLog {
+                proceeding := __new__,
+                stateUpdatedOn := __new__.createdOn
+            }
+        );
+
         required complaintState := (
-            'notYet' if .state != 'awaitingComplaint' else
-            'askIsUserOfApp' if not exists(.complainantIsUserOfApp) else
-            'askAuthority' if not exists(.complaintAuthority) else
-            'askComplaintType' if not exists(.complaintType) else
-            'askUserNetworkActivity' if .complaintType ?= <ComplaintType>'formal' and not exists(.userNetworkActivity) else
-            'askLoggedIntoAppStore' if .complaintType ?= <ComplaintType>'formal' and not exists(.loggedIntoAppStore) else
-            'askDeviceHasRegisteredSimCard' if .complaintType ?= <ComplaintType>'formal' and not exists(.deviceHasRegisteredSimCard) else
-            'askDeveloperAddress' if not exists(.developerAddress) else
-            'readyToSend'
+            ComplaintState.notYet if .state != ProceedingState.awaitingComplaint else
+            ComplaintState.askIsUserOfApp if not exists(.complainantIsUserOfApp) else
+            ComplaintState.askAuthority if not exists(.complaintAuthority) else
+            ComplaintState.askComplaintType if not exists(.complaintType) else
+            ComplaintState.askUserNetworkActivity if .complaintType ?= ComplaintType.formal and not exists(.userNetworkActivity) else
+            ComplaintState.askLoggedIntoAppStore if .complaintType ?= ComplaintType.formal and not exists(.loggedIntoAppStore) else
+            ComplaintState.askDeviceHasRegisteredSimCard if .complaintType ?= ComplaintType.formal and not exists(.deviceHasRegisteredSimCard) else
+            ComplaintState.askDeveloperAddress if not exists(.developerAddress) else
+            ComplaintState.readyToSend
         );
 
-        single initialAnalysis := (select Analysis filter .proceeding = Proceeding and .type = <AnalysisType>'initial' limit 1);
-        single secondAnalysis := (select Analysis filter .proceeding = Proceeding and .type = <AnalysisType>'second' limit 1);
+        stateUpdatedOn := (.<proceeding[is ProceedingUpdateLog]).stateUpdatedOn;
+
+        single initialAnalysis: Analysis {
+            constraint exclusive;
+            on source delete delete target;
+        };
+        single secondAnalysis: Analysis {
+            constraint exclusive;
+            on source delete delete target;
+        };
 
         noticeSent: datetime;
         controllerResponse: ControllerResponse;
@@ -115,6 +165,16 @@ module default {
         };
     }
 
+    type ProceedingUpdateLog {
+        required single proceeding: Proceeding {
+            on target delete delete source;
+            constraint exclusive;
+        }
+        required stateUpdatedOn: datetime {
+            default := datetime_current();
+        };
+    }
+
     type MessageUpload extending CreatedOn {
         required proceeding: Proceeding { on target delete delete source; };
 
diff --git a/dbschema/migrations/00005-m1smzp7.edgeql b/dbschema/migrations/00005-m1smzp7.edgeql
new file mode 100644
index 0000000..1fbdac6
--- /dev/null
+++ b/dbschema/migrations/00005-m1smzp7.edgeql
@@ -0,0 +1,111 @@
+CREATE MIGRATION m1osgfejsdyzdi2zrfrlsxokbs6nrk4aomuqd4hqpvktoicyxly5ta
+    ONTO m14kn6nhfn4ujx45frwhr6h4xkjvmgvgshzxbafecelruhz37rra2a
+{
+  ALTER TYPE default::Proceeding {
+      ALTER LINK initialAnalysis {
+          RESET EXPRESSION;
+          RESET EXPRESSION;
+          ON SOURCE DELETE DELETE TARGET;
+          RESET OPTIONALITY;
+          CREATE CONSTRAINT std::exclusive;
+          SET TYPE default::Analysis;
+      };
+      ALTER LINK secondAnalysis {
+          RESET EXPRESSION;
+          RESET EXPRESSION;
+          ON SOURCE DELETE DELETE TARGET;
+          RESET OPTIONALITY;
+          CREATE CONSTRAINT std::exclusive;
+          SET TYPE default::Analysis;
+      };
+  };
+  CREATE TYPE default::ProceedingUpdateLog {
+      CREATE REQUIRED SINGLE LINK proceeding: default::Proceeding {
+          ON TARGET DELETE DELETE SOURCE;
+          CREATE CONSTRAINT std::exclusive;
+      };
+      CREATE REQUIRED PROPERTY stateUpdatedOn: std::datetime {
+          SET default := (std::datetime_current());
+      };
+  };
+  FOR p IN (SELECT default::Proceeding {id, stateUpdatedOn}) UNION (
+    INSERT ProceedingUpdateLog {
+        proceeding := p,
+        stateUpdatedOn := p.stateUpdatedOn
+    }
+  );
+  ALTER TYPE default::Proceeding {
+      DROP PROPERTY complaintState;
+      DROP PROPERTY stateUpdatedOn;
+  };
+  ALTER TYPE default::Proceeding {
+      DROP PROPERTY state;
+  };
+  ALTER TYPE default::Analysis {
+      CREATE REQUIRED PROPERTY foundTrackers: std::bool {
+          SET default := false;
+          CREATE REWRITE
+              INSERT
+              USING ((std::any((std::json_typeof(std::json_array_unpack(.trackHarResult)) != 'null')) IF __specified__.trackHarResult ELSE .foundTrackers));
+          CREATE REWRITE
+              UPDATE
+              USING ((std::any((std::json_typeof(std::json_array_unpack(.trackHarResult)) != 'null')) IF __specified__.trackHarResult ELSE .foundTrackers));
+      };
+  };
+  UPDATE default::Analysis SET {
+    foundTrackers := (std::any((std::json_typeof(std::json_array_unpack(.trackHarResult)) != 'null')))
+  };
+  CREATE SCALAR TYPE default::ProceedingState EXTENDING enum<erased, expired, needsInitialAnalysis, initialAnalysisFailed, initialAnalysisFoundNothing, awaitingControllerNotice, awaitingControllerResponse, needsSecondAnalysis, secondAnalysisFailed, secondAnalysisFoundNothing, awaitingComplaint, complaintSent>;
+  ALTER TYPE default::Proceeding {
+      CREATE REQUIRED PROPERTY state: default::ProceedingState {
+          SET default := (default::ProceedingState.needsInitialAnalysis);
+          CREATE REWRITE
+              INSERT
+              USING ((default::ProceedingState.erased IF EXISTS (.erased) ELSE (default::ProceedingState.expired IF EXISTS (.expired) ELSE (default::ProceedingState.needsInitialAnalysis IF (NOT (EXISTS (.initialAnalysis)) AND EXISTS (.requestedAnalysis)) ELSE (default::ProceedingState.initialAnalysisFailed IF (NOT (EXISTS (.initialAnalysis)) AND NOT (EXISTS (.requestedAnalysis))) ELSE (default::ProceedingState.initialAnalysisFoundNothing IF NOT (.initialAnalysis.foundTrackers) ELSE (default::ProceedingState.awaitingControllerNotice IF (NOT (EXISTS (.noticeSent)) AND .initialAnalysis.foundTrackers) ELSE (default::ProceedingState.awaitingControllerResponse IF NOT (EXISTS (.controllerResponse)) ELSE (default::ProceedingState.needsSecondAnalysis IF (NOT (EXISTS (.secondAnalysis)) AND EXISTS (.requestedAnalysis)) ELSE (default::ProceedingState.secondAnalysisFailed IF (NOT (EXISTS (.secondAnalysis)) AND NOT (EXISTS (.requestedAnalysis))) ELSE (default::ProceedingState.secondAnalysisFoundNothing IF NOT (.secondAnalysis.foundTrackers) ELSE (default::ProceedingState.awaitingComplaint IF (NOT (EXISTS (.complaintSent)) AND .secondAnalysis.foundTrackers) ELSE default::ProceedingState.complaintSent))))))))))));
+          CREATE REWRITE
+              UPDATE
+              USING ((default::ProceedingState.erased IF EXISTS (.erased) ELSE (default::ProceedingState.expired IF EXISTS (.expired) ELSE (default::ProceedingState.needsInitialAnalysis IF (NOT (EXISTS (.initialAnalysis)) AND EXISTS (.requestedAnalysis)) ELSE (default::ProceedingState.initialAnalysisFailed IF (NOT (EXISTS (.initialAnalysis)) AND NOT (EXISTS (.requestedAnalysis))) ELSE (default::ProceedingState.initialAnalysisFoundNothing IF NOT (.initialAnalysis.foundTrackers) ELSE (default::ProceedingState.awaitingControllerNotice IF (NOT (EXISTS (.noticeSent)) AND .initialAnalysis.foundTrackers) ELSE (default::ProceedingState.awaitingControllerResponse IF NOT (EXISTS (.controllerResponse)) ELSE (default::ProceedingState.needsSecondAnalysis IF (NOT (EXISTS (.secondAnalysis)) AND EXISTS (.requestedAnalysis)) ELSE (default::ProceedingState.secondAnalysisFailed IF (NOT (EXISTS (.secondAnalysis)) AND NOT (EXISTS (.requestedAnalysis))) ELSE (default::ProceedingState.secondAnalysisFoundNothing IF NOT (.secondAnalysis.foundTrackers) ELSE (default::ProceedingState.awaitingComplaint IF (NOT (EXISTS (.complaintSent)) AND .secondAnalysis.foundTrackers) ELSE default::ProceedingState.complaintSent))))))))))));
+      };
+  };
+  CREATE SCALAR TYPE default::ComplaintState EXTENDING enum<notYet, askIsUserOfApp, askAuthority, askComplaintType, askUserNetworkActivity, askLoggedIntoAppStore, askDeviceHasRegisteredSimCard, askDeveloperAddress, readyToSend>;
+  ALTER TYPE default::Proceeding {
+      CREATE REQUIRED PROPERTY complaintState := ((default::ComplaintState.notYet IF (.state != default::ProceedingState.awaitingComplaint) ELSE (default::ComplaintState.askIsUserOfApp IF NOT (EXISTS (.complainantIsUserOfApp)) ELSE (default::ComplaintState.askAuthority IF NOT (EXISTS (.complaintAuthority)) ELSE (default::ComplaintState.askComplaintType IF NOT (EXISTS (.complaintType)) ELSE (default::ComplaintState.askUserNetworkActivity IF ((.complaintType ?= default::ComplaintType.formal) AND NOT (EXISTS (.userNetworkActivity))) ELSE (default::ComplaintState.askLoggedIntoAppStore IF ((.complaintType ?= default::ComplaintType.formal) AND NOT (EXISTS (.loggedIntoAppStore))) ELSE (default::ComplaintState.askDeviceHasRegisteredSimCard IF ((.complaintType ?= default::ComplaintType.formal) AND NOT (EXISTS (.deviceHasRegisteredSimCard))) ELSE (default::ComplaintState.askDeveloperAddress IF NOT (EXISTS (.developerAddress)) ELSE default::ComplaintState.readyToSend)))))))));
+  };
+  ALTER TYPE default::Proceeding {
+      CREATE TRIGGER logStateUpdate
+          AFTER UPDATE
+          FOR EACH
+              WHEN ((__old__.state != __new__.state))
+          DO (UPDATE
+              default::ProceedingUpdateLog
+          FILTER
+              (.proceeding = __new__)
+          SET {
+              stateUpdatedOn := std::datetime_of_statement()
+          });
+  };
+  UPDATE default::Proceeding SET {
+    secondAnalysis := (SELECT .<proceeding[IS default::Analysis] FILTER .type = default::AnalysisType.second LIMIT 1),
+    initialAnalysis := (SELECT .<proceeding[IS default::Analysis] FILTER .type = default::AnalysisType.initial LIMIT 1)
+  };
+  ALTER TYPE default::Analysis {
+    DROP CONSTRAINT std::exclusive ON ((.proceeding, .type));
+    ALTER LINK proceeding {
+      USING ((.<initialAnalysis[IS default::Proceeding] IF (.type = default::AnalysisType.initial) ELSE .<secondAnalysis[IS default::Proceeding]));
+      RESET ON TARGET DELETE;
+      SET SINGLE;
+      RESET OPTIONALITY;
+    };
+  };
+  ALTER TYPE default::Proceeding {
+      CREATE PROPERTY stateUpdatedOn := (.<proceeding[IS default::ProceedingUpdateLog].stateUpdatedOn);
+      CREATE TRIGGER createUpdateLog
+          AFTER INSERT
+          FOR EACH DO (INSERT
+              default::ProceedingUpdateLog
+              {
+                  proceeding := __new__,
+                  stateUpdatedOn := __new__.createdOn
+              });
+  };
+};

From d9e4aceedc1ae74fcc3485fc5d4d43b87c43ae75 Mon Sep 17 00:00:00 2001
From: Lorenz Sieben <me@lorenz-sieben.com>
Date: Fri, 6 Dec 2024 20:05:12 +0100
Subject: [PATCH 2/4] Update JS API to the changes

---
 src/pages/a/[platform]/[appId]/index.astro |  7 ++++--
 src/pages/private-api/analysis-result.ts   | 27 ++++++++++++----------
 2 files changed, 20 insertions(+), 14 deletions(-)

diff --git a/src/pages/a/[platform]/[appId]/index.astro b/src/pages/a/[platform]/[appId]/index.astro
index 8dc8e7a..5e8f8a6 100644
--- a/src/pages/a/[platform]/[appId]/index.astro
+++ b/src/pages/a/[platform]/[appId]/index.astro
@@ -22,11 +22,14 @@ const analyses = await e
     .run(client);
 
 if (analyses.length === 0) return new Response('We have not analyzed this app yet.', { status: 404 });
+const mostRecentAnalysis = analyses[0]!;
+if (!mostRecentAnalysis.proceeding)
+    throw new Error('The analysis has no backlink to a proceeding. This should never happen.');
 
 // An app can theoretically change its name with each new version, we thus use the one we saw in the most recent proceeding.
-const name = analyses[0]!.proceeding.appName;
+const name = mostRecentAnalysis.proceeding.appName;
 // On iOS, we need the adamId for getAppMeta().
-const adamId = analyses[0]!.app.adamId;
+const adamId = mostRecentAnalysis.app!.adamId;
 ---
 
 <Base title={t('app-details', 'heading', { name, platform: t('common', platform) })}>
diff --git a/src/pages/private-api/analysis-result.ts b/src/pages/private-api/analysis-result.ts
index 19b6163..1a9fd8e 100644
--- a/src/pages/private-api/analysis-result.ts
+++ b/src/pages/private-api/analysis-result.ts
@@ -68,21 +68,24 @@ export const POST: APIRoute = async ({ request }) => {
     if (app.id !== proceeding.app.appId) throw new Error('The HAR file contains traffic for a different app.');
 
     await e
-        .insert(e.Analysis, {
-            proceeding: e
-                // eslint-disable-next-line camelcase
-                .select(e.Proceeding, () => ({ filter_single: { id: proceeding.id } })),
-            type: requestedAnalysis.type,
+        .update(e.Proceeding, () => ({
+            // eslint-disable-next-line camelcase
+            filter_single: { id: proceeding.id },
+            set: {
+                [requestedAnalysis.type === 'initial' ? 'initialAnalysis' : 'secondAnalysis']: e.insert(e.Analysis, {
+                    type: requestedAnalysis.type,
 
-            startDate: new Date(res.har.log._tweasel.startDate),
-            endDate: new Date(res.har.log._tweasel.endDate),
+                    startDate: new Date(res.har.log._tweasel.startDate),
+                    endDate: new Date(res.har.log._tweasel.endDate),
 
-            appVersion: app.version,
-            appVersionCode: app.versionCode,
+                    appVersion: app.version,
+                    appVersionCode: app.versionCode,
 
-            har: JSON.stringify(res.har),
-            trackHarResult: res.trackHarResult,
-        })
+                    har: JSON.stringify(res.har),
+                    trackHarResult: res.trackHarResult,
+                }),
+            },
+        }))
         .run(client);
 
     await deleteRequestedAnalysis();

From 334b93d0ca352a2969e11faf56101337c4221b5a Mon Sep 17 00:00:00 2001
From: Lorenz Sieben <me@lorenz-sieben.com>
Date: Wed, 11 Dec 2024 17:00:38 +0100
Subject: [PATCH 3/4] Fix integration tests

---
 cypress/e2e/use-cases/android.cy.ts     |  8 ++++----
 src/pages/p/[platform]/[appId]/index.ts | 10 ++++++----
 2 files changed, 10 insertions(+), 8 deletions(-)

diff --git a/cypress/e2e/use-cases/android.cy.ts b/cypress/e2e/use-cases/android.cy.ts
index 29dd7c0..13d8d3e 100644
--- a/cypress/e2e/use-cases/android.cy.ts
+++ b/cypress/e2e/use-cases/android.cy.ts
@@ -65,7 +65,7 @@ describe('Use case: Analysing Android apps', () => {
             cy.contains('To Whom It May Concern:');
 
             cy.get('#upload').selectFile('cypress/fixtures/qd/notice.eml');
-            cy.get('button').contains('Upload').click();
+            cy.get('button').contains('Upload').scrollIntoView().click({ force: true });
 
             cy.contains('Waiting for the developer');
             cy.get('#upload');
@@ -101,19 +101,19 @@ describe('Use case: Analysing Android apps', () => {
             cy.contains('Irish Data Protection Commission').click();
 
             cy.contains('How to contact the DPA about the app?');
-            if (useCase === 'informal-complaint') cy.contains('Informally ask the DPA to look in the app').click();
+            if (useCase === 'informal-complaint') cy.contains('Informally ask the DPA to look into the app').click();
             else cy.contains('Check whether I am personally affected').click();
 
             if (useCase === 'formal-complaint') {
                 cy.contains('Prove that you are affected by the tracking');
 
                 cy.get('#upload').selectFile('cypress/fixtures/qd/trackercontrol.csv');
-                cy.get('button').contains('Upload').click();
+                cy.get('button').contains('Upload').scrollIntoView().click({ force: true });
 
                 cy.contains('How did you install the app?');
                 cy.contains('through the Google Play Store').click();
 
-                cy.contains('Do you have a SIM card in your phone?');
+                cy.contains('Do you have a SIM card in your device?');
                 cy.contains('I have a SIM card').click();
             }
 
diff --git a/src/pages/p/[platform]/[appId]/index.ts b/src/pages/p/[platform]/[appId]/index.ts
index 3d84236..b023a86 100644
--- a/src/pages/p/[platform]/[appId]/index.ts
+++ b/src/pages/p/[platform]/[appId]/index.ts
@@ -24,8 +24,8 @@ export const POST: APIRoute = async ({ params, redirect, currentLocale, clientAd
 
     const { token: analysisToken } = await startAnalysis(platform, appMeta.appId);
 
-    await e
-        .insert(e.Proceeding, {
+    try {
+        e.insert(e.Proceeding, {
             app: e
                 .insert(e.App, {
                     platform,
@@ -51,8 +51,10 @@ export const POST: APIRoute = async ({ params, redirect, currentLocale, clientAd
                 type: 'initial',
                 token: analysisToken,
             }),
-        })
-        .run(client);
+        }).run(client);
+    } catch (err) {
+        return new Response('Database Error', { status: 500 });
+    }
 
     return redirect(`/p/${token}`);
 };

From 58634a2a321423feb0277dad1051c3cc0d777bb2 Mon Sep 17 00:00:00 2001
From: Lorenz Sieben <me@lorenz-sieben.com>
Date: Thu, 2 Jan 2025 19:10:29 +0100
Subject: [PATCH 4/4] Fixed problem with failed analyses

fix
---
 .circleci/config.yml                     |  2 +-
 dbschema/default.esdl                    | 11 ++++-
 dbschema/migrations/00006-m1o43u7.edgeql | 16 +++++++
 src/pages/a/index.astro                  | 43 +++++++++++-------
 src/pages/p/[platform]/[appId]/index.ts  | 56 ++++++++++++------------
 src/pages/p/[token]/attachment/[type].ts |  2 +-
 src/pages/private-api/analysis-result.ts |  7 ++-
 7 files changed, 89 insertions(+), 48 deletions(-)
 create mode 100644 dbschema/migrations/00006-m1o43u7.edgeql

diff --git a/.circleci/config.yml b/.circleci/config.yml
index 574e5b5..23d3f7f 100644
--- a/.circleci/config.yml
+++ b/.circleci/config.yml
@@ -29,7 +29,7 @@ jobs:
             edgedb-server-5 --background --data-dir ~/edgedb/data --runstate-dir ~/edgedb/runstate --log-to ~/edgedb/logs --security insecure_dev_mode
 
             edgedb instance link --host localhost --port 5656 --user edgedb --branch main --non-interactive --trust-tls-cert tweasel-platform
-            edgedb migration apply
+            edgedb migrate
       - cypress/run-tests:
           start-command: 'yarn build && yarn npm-run-all -p mock-analysis-runner start'
           cypress-command: "npx wait-on 'http://localhost:4321' && if [ -z ${CYPRESS_RECORD_KEY+x} ]; then yarn cypress run; else yarn cypress run --record; fi"
diff --git a/dbschema/default.esdl b/dbschema/default.esdl
index 9a7a42c..44ccbba 100644
--- a/dbschema/default.esdl
+++ b/dbschema/default.esdl
@@ -103,6 +103,8 @@ module default {
             default := ProceedingState.needsInitialAnalysis;
         };
 
+        # We need to use these triggers to create separate log entries because we need to compare the state after
+        # modification, but can not edit the triggering entry in a trigger.
         trigger logStateUpdate after update for each
         when (__old__.state != __new__.state)
         do (
@@ -119,6 +121,13 @@ module default {
             }
         );
 
+        # This is to ensure there are no orphaned RequestedAnalysis
+        trigger removeRequestedAnalysis after update for each
+        when (__old__.requestedAnalysis not in  __new__.requestedAnalysis)
+        do (
+            delete __old__.requestedAnalysis
+        );
+
         required complaintState := (
             ComplaintState.notYet if .state != ProceedingState.awaitingComplaint else
             ComplaintState.askIsUserOfApp if not exists(.complainantIsUserOfApp) else
@@ -160,7 +169,7 @@ module default {
         multi uploads := .<proceeding[is MessageUpload];
         single requestedAnalysis: RequestedAnalysis {
             constraint exclusive;
-            on target delete allow;
+            on target delete deferred restrict;
             on source delete delete target;
         };
     }
diff --git a/dbschema/migrations/00006-m1o43u7.edgeql b/dbschema/migrations/00006-m1o43u7.edgeql
new file mode 100644
index 0000000..89bda6d
--- /dev/null
+++ b/dbschema/migrations/00006-m1o43u7.edgeql
@@ -0,0 +1,16 @@
+CREATE MIGRATION m1o43u7awhxou3dd7aa6nkf7d2hyi5u62jbvykj2c2vi4rknloatcq
+    ONTO m1osgfejsdyzdi2zrfrlsxokbs6nrk4aomuqd4hqpvktoicyxly5ta
+{
+  ALTER TYPE default::Proceeding {
+      ALTER LINK requestedAnalysis {
+          ON TARGET DELETE DEFERRED RESTRICT;
+      };
+      CREATE TRIGGER removeRequestedAnalysis
+          AFTER UPDATE 
+          FOR EACH 
+              WHEN ((__old__.requestedAnalysis NOT IN __new__.requestedAnalysis))
+          DO (DELETE
+              __old__.requestedAnalysis
+          );
+  };
+};
diff --git a/src/pages/a/index.astro b/src/pages/a/index.astro
index d03b5b5..7e2ae22 100644
--- a/src/pages/a/index.astro
+++ b/src/pages/a/index.astro
@@ -19,23 +19,34 @@ const searchResults =
         language: Astro.currentLocale || 'en',
     }).then((r) => r.slice(0, 10)));
 
-const resultsWithAnalysis =
-    searchResults && searchResults.length > 0
-        ? await e
-              .group(
-                  e.select(e.Analysis, (a) => ({
-                      filter: e.all(
-                          e.set(
-                              e.op(a.app.platform, '=', e.literal(e.Platform, platform)),
-                              e.op(a.type, '=', e.literal(e.AnalysisType, 'initial')),
-                              e.op(a.app.appId, 'in', e.set(...searchResults.map((r) => r.id))),
+let resultsWithAnalysis: {
+    key: { app_id: string | null };
+    elements: { id: string }[];
+}[] = [];
+
+try {
+    resultsWithAnalysis =
+        searchResults && searchResults.length > 0
+            ? await e
+                  .group(
+                      e.select(e.Analysis, (a) => ({
+                          filter: e.all(
+                              e.set(
+                                  e.op(a.app.platform, '=', e.literal(e.Platform, platform)),
+                                  e.op(a.type, '=', e.literal(e.AnalysisType, 'initial')),
+                                  e.op(a.app.appId, 'in', e.set(...searchResults.map((r) => r.id))),
+                              ),
                           ),
-                      ),
-                  })),
-                  (a) => ({ id: true, by: { app_id: a.app.appId } }),
-              )
-              .run(client)
-        : [];
+                      })),
+                      (a) => ({ id: true, by: { app_id: a.app.appId } }),
+                  )
+                  .run(client)
+            : [];
+} catch (error) {
+    console.log(error);
+    return new Response('Database Error', { status: 500 });
+}
+
 const results =
     searchResults &&
     searchResults.map((r) => ({
diff --git a/src/pages/p/[platform]/[appId]/index.ts b/src/pages/p/[platform]/[appId]/index.ts
index b023a86..6c07b90 100644
--- a/src/pages/p/[platform]/[appId]/index.ts
+++ b/src/pages/p/[platform]/[appId]/index.ts
@@ -25,33 +25,35 @@ export const POST: APIRoute = async ({ params, redirect, currentLocale, clientAd
     const { token: analysisToken } = await startAnalysis(platform, appMeta.appId);
 
     try {
-        e.insert(e.Proceeding, {
-            app: e
-                .insert(e.App, {
-                    platform,
-                    appId: appMeta.appId,
-                    adamId: appMeta.adamId,
-                })
-                .unlessConflict((app) => ({
-                    on: e.tuple([app.platform, app.appId]),
-                    else: app,
-                })),
-
-            token,
-            reference: generateReference(new Date()),
-
-            appName: appMeta.appName,
-            developerName: appMeta.developerName,
-            developerEmail: appMeta.developerEmail,
-            developerAddress: appMeta.developerAddress,
-            ...(appMeta.developerAddress && { developerAddressSourceUrl: appMeta.storeUrl }),
-            privacyPolicyUrl: appMeta.privacyPolicyUrl,
-
-            requestedAnalysis: e.insert(e.RequestedAnalysis, {
-                type: 'initial',
-                token: analysisToken,
-            }),
-        }).run(client);
+        await e
+            .insert(e.Proceeding, {
+                app: e
+                    .insert(e.App, {
+                        platform,
+                        appId: appMeta.appId,
+                        adamId: appMeta.adamId,
+                    })
+                    .unlessConflict((app) => ({
+                        on: e.tuple([app.platform, app.appId]),
+                        else: app,
+                    })),
+
+                token,
+                reference: generateReference(new Date()),
+
+                appName: appMeta.appName,
+                developerName: appMeta.developerName,
+                developerEmail: appMeta.developerEmail,
+                developerAddress: appMeta.developerAddress,
+                ...(appMeta.developerAddress && { developerAddressSourceUrl: appMeta.storeUrl }),
+                privacyPolicyUrl: appMeta.privacyPolicyUrl,
+
+                requestedAnalysis: e.insert(e.RequestedAnalysis, {
+                    type: 'initial',
+                    token: analysisToken,
+                }),
+            })
+            .run(client);
     } catch (err) {
         return new Response('Database Error', { status: 500 });
     }
diff --git a/src/pages/p/[token]/attachment/[type].ts b/src/pages/p/[token]/attachment/[type].ts
index 050a844..ddc3c38 100644
--- a/src/pages/p/[token]/attachment/[type].ts
+++ b/src/pages/p/[token]/attachment/[type].ts
@@ -155,7 +155,7 @@ export const POST: APIRoute = async ({ params, currentLocale, request }) => {
         .formData({
             complainantAddress: zfd.text(),
             complainantContactDetails: zfd.text(),
-            complainantAgreesToUnencryptedCommunication: zfd.text(z.enum(['yes', 'no'])),
+            complainantAgreesToUnencryptedCommunication: zfd.text(z.enum(['yes', 'no-letter'])),
         })
         .parse(await request.formData());
 
diff --git a/src/pages/private-api/analysis-result.ts b/src/pages/private-api/analysis-result.ts
index 1a9fd8e..73d85df 100644
--- a/src/pages/private-api/analysis-result.ts
+++ b/src/pages/private-api/analysis-result.ts
@@ -49,9 +49,12 @@ export const POST: APIRoute = async ({ request }) => {
 
     const deleteRequestedAnalysis = () =>
         e
-            .delete(e.RequestedAnalysis, () => ({
+            .update(e.Proceeding, () => ({
                 // eslint-disable-next-line camelcase
-                filter_single: { id: requestedAnalysis.id },
+                filter_single: { id: proceeding.id },
+                set: {
+                    requestedAnalysis: null,
+                },
             }))
             .run(client);