Merge pull request #1154 from dbraendle/feat/dashboard-icons-fallback

feat: add dashboard-icons as icon fallback source

Author: tw93

bin/options/icon.ts

@@ -398,6 +398,26 @@ function generateIconServiceUrls(domain: string): string[] {
   ];
 }
 
+/**
+ * Generates dashboard-icons URLs for an app name.
+ * Uses walkxcode/dashboard-icons as a final fallback for selfhosted apps.
+ * Keeps matching conservative to avoid overriding valid site-specific icons.
+ */
+function generateDashboardIconUrls(appName: string): string[] {
+  const baseUrl = 'https://cdn.jsdelivr.net/gh/walkxcode/dashboard-icons/png';
+  const name = appName.toLowerCase().trim();
+  const slugs = new Set<string>();
+
+  // Exact name
+  slugs.add(name);
+  // Replace spaces with hyphens
+  slugs.add(name.replace(/\s+/g, '-'));
+
+  return [...slugs]
+    .filter((s) => s.length > 0)
+    .map((slug) => `${baseUrl}/${slug}.png`);
+}
+
 /**
  * Attempts to fetch favicon from website
  */
@@ -409,14 +429,14 @@ async function tryGetFavicon(
     const domain = new URL(url).hostname;
     const spinner = getSpinner(`Fetching icon from ${domain}...`);
 
-    const serviceUrls = generateIconServiceUrls(domain);
-
     const isCI =
       process.env.CI === 'true' || process.env.GITHUB_ACTIONS === 'true';
     const downloadTimeout = isCI
       ? ICON_CONFIG.downloadTimeout.ci
       : ICON_CONFIG.downloadTimeout.default;
 
+    const serviceUrls = generateIconServiceUrls(domain);
+
     for (const serviceUrl of serviceUrls) {
       try {
         const faviconPath = await downloadIcon(
@@ -445,6 +465,37 @@ async function tryGetFavicon(
       }
     }
 
+    // Final fallback for selfhosted apps behind auth where domain-based
+    // services cannot access the site favicon.
+    if (appName) {
+      const dashboardIconUrls = generateDashboardIconUrls(appName);
+      for (const iconUrl of dashboardIconUrls) {
+        try {
+          const iconPath = await downloadIcon(iconUrl, false, downloadTimeout);
+          if (!iconPath) continue;
+
+          const convertedPath = await convertIconFormat(iconPath, appName);
+          if (convertedPath) {
+            const finalPath = await copyWindowsIconIfNeeded(
+              convertedPath,
+              appName,
+            );
+            spinner.succeed(
+              chalk.green(
+                `Icon found via dashboard-icons fallback for "${appName}"!`,
+              ),
+            );
+            return finalPath;
+          }
+        } catch (error: unknown) {
+          if (error instanceof Error) {
+            logger.debug(`Dashboard icon ${iconUrl} failed: ${error.message}`);
+          }
+          continue;
+        }
+      }
+    }
+
     spinner.warn(`No favicon found for ${domain}. Using default.`);
     return null;
   } catch (error) {