test: add duplicate property test and fix xunit warnings (#112)

Author: ttu

JsonFlatFileDataStore.Test/DataStoreDisposeTests.cs

@@ -41,7 +41,7 @@ public async Task DataStore_Dispose(string testName, bool useDispose)
                 await Task.Delay(1000);
 
                 if (sw.ElapsedMilliseconds > maxTimeMs)
-                    Assert.False(true, "Timeout");
+                    Assert.Fail("Timeout");
             }
 
             while (useDispose == storeRef.IsAlive)
@@ -50,7 +50,7 @@ public async Task DataStore_Dispose(string testName, bool useDispose)
                 GC.Collect();
 
                 if (sw.ElapsedMilliseconds > maxTimeMs)
-                    Assert.False(true, "Timeout");
+                    Assert.Fail("Timeout");
             }
 
             // If DataStore is not disposed, it should still be alive

JsonFlatFileDataStore.Test/DataStoreTests.cs

@@ -86,7 +86,7 @@ public void GetCollection_TypedCollection_NameParameter()
 
             var collection = store.GetCollection<Movie>("movies");
             Assert.Equal(2, collection.Count);
-            Assert.Single(collection.AsQueryable().Where(e => e.Name == "Predator"));
+            Assert.Single(collection.AsQueryable(), e => e.Name == "Predator");
 
             UTHelpers.Down(newFilePath);
         }
@@ -111,7 +111,7 @@ public void GetCollection_Mocked()
             var result = collection.InsertOne(new Movie { Name = "Predator" });
             Assert.True(result);
             Assert.Equal(2, collection.Count);
-            Assert.Single(collection.AsQueryable().Where(e => e.Name == "Predator"));
+            Assert.Single(collection.AsQueryable(), e => e.Name == "Predator");
         }
 
         [Fact]
@@ -223,9 +223,9 @@ public async Task Readme_Example2()
             var results = collection.AsQueryable().Where(x => x.age < 40);
 
             Assert.True(results.Count() == 3);
-            Assert.Single(results.Where(e => e.name == "Raymond Doe"));
-            Assert.Single(results.Where(e => e.name == "Andy Doe"));
-            Assert.Single(results.Where(e => e.name == "Karl"));
+            Assert.Single(results, e => e.name == "Raymond Doe");
+            Assert.Single(results, e => e.name == "Andy Doe");
+            Assert.Single(results, e => e.name == "Karl");
 
             UTHelpers.Down(pathToJson);
         }
@@ -400,7 +400,7 @@ public async Task Readme_Example3()
             // Use LINQ to query items
             var results = collection.AsQueryable().Where(e => e.Age > 30);
 
-            Assert.Single(results.Where(e => e.Name == "John Doe"));
+            Assert.Single(results, e => e.Name == "John Doe");
 
             UTHelpers.Down(pathToJson);
         }

JsonFlatFileDataStore.Test/FileContentTests.cs

@@ -1,5 +1,7 @@
 using System;
+using System.Dynamic;
 using System.IO;
+using System.Linq;
 using System.Text.RegularExpressions;
 using System.Threading.Tasks;
 using Xunit;
@@ -15,11 +17,11 @@ public void FileNotFound_CreateNewFile()
 
             var storeFileNotFound = new DataStore(path);
             var collectionKeys = storeFileNotFound.GetKeys();
-            Assert.Equal(0, collectionKeys.Count);
+            Assert.Empty(collectionKeys);
 
             var storeFileFound = new DataStore(path);
             var collectionKeysFileFound = storeFileFound.GetKeys();
-            Assert.Equal(0, collectionKeysFileFound.Count);
+            Assert.Empty(collectionKeysFileFound);
 
             UTHelpers.Down(path);
         }
@@ -73,11 +75,11 @@ public void Encrypted_FileNotFound_CreateNewFile()
 
             var storeFileNotFound = new DataStore(path, encryptionKey: "53cr3t");
             var collectionKeys = storeFileNotFound.GetKeys();
-            Assert.Equal(0, collectionKeys.Count);
+            Assert.Empty(collectionKeys);
 
             var storeFileFound = new DataStore(path, encryptionKey: "53cr3t");
             var collectionKeysFileFound = storeFileFound.GetKeys();
-            Assert.Equal(0, collectionKeysFileFound.Count);
+            Assert.Empty(collectionKeysFileFound);
 
             UTHelpers.Down(path);
         }
@@ -225,6 +227,44 @@ public async Task WriteToFile_UpperCamelCase()
             UTHelpers.Down(newFilePath);
         }
 
+        [Fact]
+        public async Task DynamicCollection_UpdateWrongCase_NoDuplicateProperties()
+        {
+            var newFilePath = UTHelpers.Up();
+
+            var store = new DataStore(newFilePath);
+
+            var collection = store.GetCollection("user");
+            Assert.Equal(3, collection.Count);
+
+            await collection.InsertOneAsync(new { id = 11, name = "Teddy", age = 21 });
+
+            // Update with wrong case - capital A in Age
+            dynamic source = new ExpandoObject();
+            source.Age = 22;
+            var updateResult = await collection.UpdateOneAsync(e => e.id == 11, source as object);
+            Assert.True(updateResult);
+
+            // Read the raw JSON and verify no duplicate properties with different casing
+            var json = File.ReadAllText(newFilePath);
+            var ageCountLower = Regex.Matches(json, "\"age\"").Count;
+            var ageCountUpper = Regex.Matches(json, "\"Age\"").Count;
+
+            // Property 'age' (lowercase) should exist in the JSON
+            Assert.True(ageCountLower > 0);
+            // Property 'Age' (uppercase) should NOT exist - no duplicate properties with different casing
+            Assert.Equal(0, ageCountUpper);
+
+            // Verify the value is correct
+            var store2 = new DataStore(newFilePath);
+            var collection2 = store2.GetCollection("user");
+            var updated = collection2.Find(e => e.id == 11).First();
+            Assert.Equal(22, updated.age);
+            Assert.Equal("Teddy", updated.name);
+
+            UTHelpers.Down(newFilePath);
+        }
+
         public class Employee
         {
             public int Id { get; set; }