feat(ecmascript): get PlainTime.prototype.second (#961)

Author: 0Zeno

nova_vm/src/builtin_strings

@@ -184,6 +184,7 @@ get description
 #[cfg(feature = "temporal")]get minute
 #[cfg(feature = "regexp")]get multiline
 #[cfg(feature = "array-buffer")]get resizable
+#[cfg(feature = "temporal")]get second
 get size
 #[cfg(feature = "regexp")]get source
 #[cfg(feature = "regexp")]get sticky
@@ -370,6 +371,7 @@ revocable
 #[cfg(feature = "temporal")]roundingIncrement
 seal
 #[cfg(feature = "regexp")]search
+#[cfg(feature = "temporal")]second
 #[cfg(feature = "temporal")]seconds
 set
 #[cfg(feature = "set")]Set

nova_vm/src/ecmascript/builtins/temporal/plain_time/plain_time_prototype.rs

@@ -23,6 +23,15 @@ impl Builtin for TemporalPlainTimePrototypeGetMinute {
 }
 impl BuiltinGetter for TemporalPlainTimePrototypeGetMinute {}
 
+struct TemporalPlainTimePrototypeGetSecond;
+impl Builtin for TemporalPlainTimePrototypeGetSecond {
+    const NAME: String<'static> = BUILTIN_STRING_MEMORY.get_second;
+    const KEY: Option<PropertyKey<'static>> = Some(BUILTIN_STRING_MEMORY.second.to_property_key());
+    const LENGTH: u8 = 0;
+    const BEHAVIOUR: Behaviour = Behaviour::Regular(TemporalPlainTimePrototype::get_second);
+}
+impl BuiltinGetter for TemporalPlainTimePrototypeGetSecond {}
+
 impl TemporalPlainTimePrototype {
     /// ### [4.3.4 get Temporal.PlainTime.prototype.minute](https://tc39.es/proposal-temporal/#sec-get-temporal.plaintime.prototype.minute)
     pub(crate) fn get_minute<'gc>(
@@ -39,6 +48,21 @@ impl TemporalPlainTimePrototype {
         let value = plain_time.inner_plain_time(agent).minute();
         Ok(value.into())
     }
+    /// ### [4.3.5 get Temporal.PlainTime.prototype.second](https://tc39.es/proposal-temporal/#sec-get-temporal.plaintime.prototype.second)
+    pub(crate) fn get_second<'gc>(
+        agent: &mut Agent,
+        this_value: Value,
+        _: ArgumentsList,
+        gc: GcScope<'gc, '_>,
+    ) -> JsResult<'gc, Value<'gc>> {
+        let gc = gc.into_nogc();
+        // 1. Let plainTime be the this value.
+        // 2. Perform ? RequireInternalSlot(plainTime, [[InitializedTemporalTime]]).
+        let plain_time = require_internal_slot_temporal_plain_time(agent, this_value, gc)?;
+        // 3. Return 𝔽(plainTime.[[Time]].[[Second]]).
+        let value = plain_time.inner_plain_time(agent).second();
+        Ok(value.into())
+    }
 
     pub(crate) fn create_intrinsic(agent: &mut Agent, realm: Realm<'static>, _: NoGcScope) {
         let intrinsics = agent.get_realm_record_by_id(realm).intrinsics();
@@ -47,10 +71,11 @@ impl TemporalPlainTimePrototype {
         let plain_time_constructor = intrinsics.temporal_plain_time();
 
         OrdinaryObjectBuilder::new_intrinsic_object(agent, realm, this)
-            .with_property_capacity(3)
+            .with_property_capacity(4)
             .with_prototype(object_prototype)
             .with_constructor_property(plain_time_constructor)
             .with_builtin_function_getter_property::<TemporalPlainTimePrototypeGetMinute>()
+            .with_builtin_function_getter_property::<TemporalPlainTimePrototypeGetSecond>()
             .with_property(|builder| {
                 builder
                     .with_key(WellKnownSymbols::ToStringTag.into())

tests/expectations.json

@@ -4022,8 +4022,6 @@
   "built-ins/Temporal/PlainTime/prototype/round/smallestunit-string-shorthand.js": "FAIL",
   "built-ins/Temporal/PlainTime/prototype/round/smallestunit-wrong-type.js": "FAIL",
   "built-ins/Temporal/PlainTime/prototype/round/subclassing-ignored.js": "FAIL",
-  "built-ins/Temporal/PlainTime/prototype/second/branding.js": "FAIL",
-  "built-ins/Temporal/PlainTime/prototype/second/prop-desc.js": "FAIL",
   "built-ins/Temporal/PlainTime/prototype/since/argument-cast.js": "FAIL",
   "built-ins/Temporal/PlainTime/prototype/since/argument-number.js": "FAIL",
   "built-ins/Temporal/PlainTime/prototype/since/argument-string-calendar-annotation-invalid-key.js": "FAIL",
@@ -7075,4 +7073,4 @@
   "staging/sm/syntax/yield-as-identifier.js": "FAIL",
   "staging/source-phase-imports/import-source-source-text-module.js": "FAIL",
   "staging/top-level-await/tla-hang-entry.js": "FAIL"
-}
+}

tests/metrics.json

@@ -1,8 +1,8 @@
 {
   "results": {
     "crash": 52,
-    "fail": 6969,
-    "pass": 40331,
+    "fail": 6967,
+    "pass": 40333,
     "skip": 3326,
     "timeout": 18,
     "unresolved": 37