Merge pull request #63 from trojs/feature/trojs-lint

Use TroJS lint rules

Author: w3nl

.github/workflows/cpd.yml

@@ -8,10 +8,10 @@ jobs:
 
     steps:
       - uses: actions/checkout@v4
-      - name: Use Node.js 20
+      - name: Use Node.js 24
         uses: actions/setup-node@v4
         with:
-          node-version: 20
+          node-version: 24
           cache: "npm"
       - name: npm cpd
         run: |

.github/workflows/lint.yml

@@ -8,10 +8,10 @@ jobs:
 
     steps:
       - uses: actions/checkout@v4
-      - name: Use Node.js 20
+      - name: Use Node.js 24
         uses: actions/setup-node@v4
         with:
-          node-version: 20
+          node-version: 24
           cache: "npm"
       - name: npm lint
         run: |

.github/workflows/npm-publish.yml

@@ -1,6 +1,3 @@
-# This workflow will run tests using node and then publish a package to GitHub Packages when a release is created
-# For more information see: https://help.github.com/actions/language-and-framework-guides/publishing-nodejs-packages
-
 name: Node.js Package
 
 on:
@@ -14,7 +11,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: actions/setup-node@v4
         with:
-          node-version: 20
+          node-version: 24
       - run: npm ci
       - run: npm test
 
@@ -23,12 +20,27 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
+        with:
+          token: ${{ secrets.GH_PAT }} # Use your PAT here!
       - uses: actions/setup-node@v4
         with:
-          node-version: 20
+          node-version: 24
           registry-url: https://registry.npmjs.org/
       - run: npm ci
+      - name: Set version from tag
+        run: |
+          git config user.name "github-actions[bot]"
+          git config user.email "github-actions[bot]@users.noreply.github.com"
+          TAG=${GITHUB_REF#refs/tags/}
+          TAG=${TAG#v}
+          git fetch origin main
+          git checkout main
+          git pull
+          npm version $TAG --no-git-tag-version
+          git add package.json package-lock.json
+          git commit -m "ci: set version to $TAG [skip ci]" || true
+          git push origin main
       - run: npm run build --if-present
       - run: npm publish --access public
         env:
-          NODE_AUTH_TOKEN: ${{secrets.npm_token}}
+          NODE_AUTH_TOKEN: ${{ secrets.npm_token }}

.github/workflows/sonarcloud.yml

@@ -8,10 +8,10 @@ jobs:
 
     steps:
       - uses: actions/checkout@v4
-      - name: Use Node.js 20
+      - name: Use Node.js 24
         uses: actions/setup-node@v4
         with:
-          node-version: 20
+          node-version: 24
           cache: "npm"
       - name: npm install, lint, and test
         run: |

.github/workflows/test.yml

@@ -8,7 +8,7 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [18.x, 20.x, 21.x, 22.x]
+        node-version: [20.x, 21.x, 22.x, 23.x, 24.x]
 
     steps:
       - uses: actions/checkout@v4

.github/workflows/vulnerabilities.yml

@@ -8,10 +8,10 @@ jobs:
 
     steps:
       - uses: actions/checkout@v4
-      - name: Use Node.js 20
+      - name: Use Node.js 24
         uses: actions/setup-node@v4
         with:
-          node-version: 20
+          node-version: 24
           cache: "npm"
       - name: npm vulnerabilities
         run: |

.nvmrc

@@ -1 +1 @@
-22.11.0
+24

coverage/.gitkeep

@@ -1,49 +1,27 @@
-import globals from 'globals';
-import pluginJs from '@eslint/js';
-import jsdoc from 'eslint-plugin-jsdoc';
-import stylisticJs from '@stylistic/eslint-plugin-js'
-import sonarjs from 'eslint-plugin-sonarjs';
+import globals from 'globals'
+import { plugins, rules } from '@trojs/lint'
 
 export default [
-  sonarjs.configs.recommended,
   {
-
-    files: ['**/*.js'],
-    languageOptions: { globals: globals.node },
-
+    languageOptions: {
+      ecmaVersion: 'latest',
+      sourceType: 'module',
+      globals: {
+        ...globals.node,
+        ...globals.es2024
+      }
+    },
+    settings: {
+      jsdoc: {
+        mode: 'typescript'
+      }
+    },
     plugins: {
-      '@stylistic/js': stylisticJs,
-      jsdoc: jsdoc
+      ...plugins
     },
     rules: {
-      '@stylistic/js/indent': ['error', 2],
-      'consistent-return': [
-        'error'
-      ],
-      'no-param-reassign': [
-        'error',
-        {
-          'props': true,
-          'ignorePropertyModificationsFor': [
-            'acc',
-            'accumulator',
-            'e',
-            'req',
-            'request',
-            'res',
-            'response'
-          ]
-        }
-      ],
-      'quotes': [
-        'error',
-        'single',
-        {
-          'avoidEscape': true,
-          'allowTemplateLiterals': true
-        }
-      ],
-    }
-  },
-  pluginJs.configs.recommended,
-];
+      ...rules.all
+    },
+    files: ['**/*.js']
+  }
+]