Feature: Adding .conflicts() where applicable to make flags exclusive#104
Open
brycentrivir wants to merge 2 commits into
Open
Feature: Adding .conflicts() where applicable to make flags exclusive#104brycentrivir wants to merge 2 commits into
brycentrivir wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CommanderJS has a feature of .conflicts() that can be added to the Option object to assign conflicting flags/options making them exclusive.
Only weird thing was to get .conflicts to work, we had to add its metadata to the cloneOption happening in FrodoCommand.ts. Commander has a typing error in the node_modules so for now we are using @ts-expect-error for each line that adds that until they fix it. The linter will create the new line so usage is for each line as @ts-expect-error doesn't have multi line functionality.