seems broken on macos

[evantill]

Hi,

As explained in the README.md :

Shortcuts manager preferences are located under Tools -> Accessories -> Shortcuts. To invoke shortcuts overlay feature press the W key on the keyboard.

But I have no Accessories in Toolsmenu and W key does not work either (My keyboard is an AZERTY).

• OS: Mac OS X (macOS Sierra 10.12.6)
• Word size of OS: 64-bit
• Word size of FreeCAD: 64-bit
• Version: 0.17.13541 (Git)
• Build type: Release
• Branch: releases/FreeCAD-0-17
• Hash: 9948ee4f1570df9216862a79705afb367b2c6ffb
• Python version: 2.7.14
• Qt version: 5.10.1
• Coin version: 4.0.0a
• OCC version: 7.2.0
• Locale: French/France (fr_FR)

[evantill]

First time I was in French language. I have switch to English but same problem.

[evantill]

Maybe the menu is not found here:

ShortCuts/ShortCuts_Gui.py

Line 450 in 19ca51e

toolsMenu = mb.findChild(QtGui.QMenu, "&Tools")

[evantill]

On stackoverflow I have found this question about findChild of QMenu does is not working properly

[evantill]

opening Freecad from the terminal I have ths error message :

Traceback (most recent call last):
  File "/Users/username/Library/Preferences/FreeCAD/Mod/ShortCuts/ShortCuts_Gui.py", line 471, in onStart
    onWorkbench()
  File "/Users/username/Library/Preferences/FreeCAD/Mod/ShortCuts/ShortCuts_Gui.py", line 171, in onWorkbench
    workbench = Gui.activeWorkbench().__class__.__name__
AssertionError: No active workbench

[evantill]

ShortCuts/ShortCuts_Gui.py

Lines 467 to 472 in 19ca51e

	if start:
	timer.stop()
	timer.deleteLater()
	onWorkbench()
	accessoriesMenu()
	mw.workbenchActivated.connect(onWorkbench)

Moving accessoriesMenu() before onWorkbench() seems to work but I have no ideas if there are side effects.

What could I do next to help ?

[triplus]

Thanks for reporting the issue and providing verbose information. Could you please test two things:

1.) Install CommandPanel module (available in Addon manager). Start FreeCAD from the terminal to see if CommandPanel module will have the same issue, or it will start successfully. This info will likely help once i will restructure ShortCuts module (merge the manager and overlay functionality).

2.) If you add an additional line to ShortCuts_Gui.py like this:

def onStart():
    """Start shortcuts."""
    start = False
    try:
        mw.workbenchActivated
        Gui.activeWorkbench().__class__.__name__
        start = True
    except:
        pass

    if start:
        timer.stop()
        timer.deleteLater()
        onWorkbench()
        accessoriesMenu()
        mw.workbenchActivated.connect(onWorkbench)

Does the ShortCuts module start successfully after? Note that to activate the Overlay currently Shift+Q and not W is set by default. I forgot to change the instruction, when i made that change.

[evantill]

1.) Same problem with CommandPanel:

Traceback (most recent call last):
  File "/Users/username/Library/Preferences/FreeCAD/Mod/CommandPanel/CommandPanelGui.py", line 201, in onStart
    onWorkbench()
  File "/Users/username/Library/Preferences/FreeCAD/Mod/CommandPanel/CommandPanelGui.py", line 144, in onWorkbench
    workbench = Gui.activeWorkbench().__class__.__name__
AssertionError: No active workbench

[evantill]

2.) the error is now on the new line

Traceback (most recent call last):
  File "/Users/ericvantillard/Library/Preferences/FreeCAD/Mod/ShortCuts/ShortCuts_Gui.py", line 464, in onStart
    Gui.activeWorkbench().__class__.__name__
AssertionError: No active workbench

[evantill]

compare with :

https://github.com/FreeCAD/FreeCAD/blob/4079c9603fe988799fdf2bb871b13c64313467f9/src/Mod/Tux/PersistentToolbarsGui.py#L243

adding if mw.property("eventLoop"):seems to solve the problem.

[triplus]

Thanks for the feedback. OK therefore i will assume all modules can have such problems on macOS. As on Qt4 builds this likely isn't an issue, therefore i won't drop support for FreeCAD 0.16 just yet. That property was added for FreeCAD 0.17+.

Will go over all modules and add the appropriate changes (will do that today or tomorrow).

[triplus]

OK i have checked all the modules and adapted the ones benefiting from such improved start reliability. Could you please install all the modules (Addon manager) to see if all start successfully now on your side, or if some errors are still detected when starting FreeCAD:

• Autoload
• CommandPanel
• Glass
• IconThemes
• Launcher
• PieMenu
• SelectorToolbar
• ShortCuts
• TabBar
• ToolbarStyle

Thanks.

[evantill]

• Autoload
  after restarting I have :

Traceback (most recent call last):
  File "/Users/ericvantillard/Library/Preferences/FreeCAD/Mod/Autoload/Autoload_Gui.py", line 240, in onStart
    loadWorkbenches()
  File "/Users/ericvantillard/Library/Preferences/FreeCAD/Mod/Autoload/Autoload_Gui.py", line 212, in loadWorkbenches
    Gui.activateWorkbench(default)
KeyError: "No such workbench 'StartWorkbench'"

but the menu is working

• CommandPanel
• IconThemes
• Launcher
• PieMenu
• SelectorToolbar
• Glass how to use Q+1 Q+2 keys ?
• ShortCuts
• TabBar seems to work but strange result in display
• ToolbarStyle not sure : when installing, it the accessories menu disappear not anymore

[triplus]

Thanks for the feedback. Will have more time to take a more in-depth look tomorrow.

• TabBar should add a workbench selector alike toolbar with tabs. What sort of display issues are you experiencing? Could that be Glass module related?
• Glass, when activated, should overlay Combo View over the MDI area. That is all it does ATM. It's early in development and therefore results could be unexpected. Indeed Q+1 is being used ATM, to toggle the mode.
• ToolbarStyle likely produces some error on FreeCAD start. If you enable log (Edit -> Preferences -> General -> Output window -> Record log messages) and start FreeCAD from the terminal. In the terminal and/or in the Report view, likely there is some additional clue outputted? If you remove the Autoload module, does the Accessories menu appear again?

P.S. Note that i accidentally edited your last reply. Wanted to test if such list is rearrangeable and i guess it is! Didn't really expected it would be.

[triplus]

Note that i just updated the Autoload module and hopefully the issue is resolved.

[evantill]

I have tried Autoload:

• No *Accesoiries Menu in tools.
• But no errors in the console.