Skip to content

Commit a16ed9a

Browse files
committed
Chart fullscreen legend shows all items and is scrollable
1 parent 3dd6fea commit a16ed9a

File tree

1 file changed

+14
-11
lines changed

1 file changed

+14
-11
lines changed

apps/webapp/app/components/metrics/QueryWidget.tsx

Lines changed: 14 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,19 @@
1-
import { DocumentDuplicateIcon, PencilSquareIcon, TrashIcon } from "@heroicons/react/20/solid";
2-
import { ArrowsPointingOutIcon } from "@heroicons/react/24/solid";
1+
import {
2+
DocumentDuplicateIcon,
3+
PencilIcon,
4+
PencilSquareIcon,
5+
TrashIcon,
6+
} from "@heroicons/react/20/solid";
7+
import { ChartBarIcon } from "@heroicons/react/24/solid";
38
import { type OutputColumnMetadata } from "@internal/tsql";
49
import { DialogClose } from "@radix-ui/react-dialog";
5-
import { IconChartHistogram, IconResize } from "@tabler/icons-react";
610
import { assertNever } from "assert-never";
11+
import { SimpleTooltip } from "~/components/primitives/Tooltip";
12+
import { cn } from "~/utils/cn";
713
import { Maximize2 } from "lucide-react";
814
import { useState, type ReactNode } from "react";
915
import { z } from "zod";
1016
import { Card } from "~/components/primitives/charts/Card";
11-
import { SimpleTooltip } from "~/components/primitives/Tooltip";
12-
import { cn } from "~/utils/cn";
1317
import { QueryResultsChart } from "../code/QueryResultsChart";
1418
import { TSQLResultsTable } from "../code/TSQLResultsTable";
1519
import { Button } from "../primitives/Buttons";
@@ -26,6 +30,7 @@ import {
2630
PopoverMenuItem,
2731
PopoverVerticalEllipseTrigger,
2832
} from "../primitives/Popover";
33+
import { IconChartHistogram } from "@tabler/icons-react";
2934

3035
const ChartType = z.union([z.literal("bar"), z.literal("line")]);
3136
export type ChartType = z.infer<typeof ChartType>;
@@ -187,7 +192,6 @@ export function QueryWidget({
187192
</span>
188193
}
189194
content="Maximize"
190-
disableHoverableContent
191195
asChild
192196
/>
193197
{accessory}
@@ -210,8 +214,6 @@ export function QueryWidget({
210214
onEdit(props.data);
211215
setIsMenuOpen(false);
212216
}}
213-
className="pl-1"
214-
leadingIconClassName="-mr-1"
215217
/>
216218
)}
217219
{onRename && (
@@ -259,8 +261,8 @@ export function QueryWidget({
259261
{isResizing ? (
260262
<div className="flex h-full flex-1 items-center justify-center p-3">
261263
<div className="flex flex-col items-center gap-1 text-text-dimmed">
262-
<IconResize className="size-10 text-text-dimmed/50" />
263-
<span className="text-base font-medium">Resizing</span>
264+
<ChartBarIcon className="size-10 text-text-dimmed" />{" "}
265+
<span className="text-base font-medium">Resizing...</span>
264266
</div>
265267
</div>
266268
) : error ? (
@@ -394,7 +396,8 @@ function QueryWidgetBody({
394396
columns={data.columns}
395397
config={config}
396398
timeRange={timeRange}
397-
onViewAllLegendItems={() => setIsFullscreen(true)}
399+
fullLegend
400+
legendScrollable
398401
isLoading={showLoading}
399402
/>
400403
</div>

0 commit comments

Comments
 (0)