Skip to content

Commit a08ffac

Browse files
committed
fix: review feedback - docsPath, typecheck error, duration rounding
1 parent 571eccb commit a08ffac

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

apps/webapp/app/components/runs/v3/SharedFilters.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -376,7 +376,7 @@ export function TimeFilter({
376376
const periodValue = period ?? value("period");
377377
const fromValue = from ?? value("from");
378378
const toValue = to ?? value("to");
379-
const triggerRef = useRef<HTMLDivElement>(null);
379+
const triggerRef = useRef<HTMLButtonElement>(null);
380380

381381
useShortcutKeys({
382382
shortcut,

apps/webapp/app/components/runs/v3/SpanHorizontalTimeline.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,9 @@ function formatSpanDuration(nanoseconds: number): string {
44
const ms = nanoseconds / 1_000_000;
55
if (ms < 1000) return `${Math.round(ms)}ms`;
66
if (ms < 60_000) return `${(ms / 1000).toFixed(1)}s`;
7-
const mins = Math.floor(ms / 60_000);
8-
const secs = ((ms % 60_000) / 1000).toFixed(0);
7+
const totalSecs = Math.round(ms / 1000);
8+
const mins = Math.floor(totalSecs / 60);
9+
const secs = totalSecs % 60;
910
return `${mins}m ${secs}s`;
1011
}
1112

apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.prompts._index/route.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ export default function PromptsPage() {
8383
<NavBar>
8484
<PageTitle title="Prompts" />
8585
<PageAccessories>
86-
<LinkButton variant="docs/small" LeadingIcon={BookOpenIcon} to={docsPath("/prompts")}>
86+
<LinkButton variant="docs/small" LeadingIcon={BookOpenIcon} to={docsPath("ai/prompts")}>
8787
Prompts docs
8888
</LinkButton>
8989
</PageAccessories>

0 commit comments

Comments
 (0)