Skip to content

Commit 410e397

Browse files
committed
fix: use != null check in resolveVersion to handle version 0 correctly
1 parent 5865db8 commit 410e397

File tree

4 files changed

+18
-7
lines changed

4 files changed

+18
-7
lines changed

CLAUDE.md

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,15 +18,24 @@ pnpm run dev --filter webapp # Run webapp (http://localhost:3030)
1818
pnpm run dev --filter trigger.dev --filter "@trigger.dev/*" # Watch CLI and packages
1919
```
2020

21-
### Verifying Webapp Changes
21+
### Verifying Changes
2222

23-
**Never run `pnpm run build --filter webapp` to verify changes.** Building proves almost nothing about correctness. Instead, run typecheck from the repo root:
23+
The verification command depends on where the change lives:
24+
25+
- **Apps and internal packages** (`apps/*`, `internal-packages/*`): Use `typecheck`. **Never use `build`** for these — building proves almost nothing about correctness.
26+
- **Public packages** (`packages/*`): Use `build`.
2427

2528
```bash
26-
pnpm run typecheck --filter webapp # ~1-2 minutes
29+
# Apps and internal packages — use typecheck
30+
pnpm run typecheck --filter webapp # ~1-2 minutes
31+
pnpm run typecheck --filter @internal/run-engine
32+
33+
# Public packages — use build
34+
pnpm run build --filter @trigger.dev/sdk
35+
pnpm run build --filter @trigger.dev/core
2736
```
2837

29-
Only run typecheck after major changes (new files, significant refactors, schema changes). For small edits, trust the types and let CI catch issues.
38+
Only run typecheck/build after major changes (new files, significant refactors, schema changes). For small edits, trust the types and let CI catch issues.
3039

3140
## Testing
3241

apps/webapp/CLAUDE.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,16 @@ Remix 2.1.0 app serving as the main API, dashboard, and orchestration engine. Us
44

55
## Verifying Changes
66

7-
**Never run `pnpm run build --filter webapp` to verify changes.** Building proves almost nothing about correctness. Instead, run typecheck from the repo root:
7+
**Never run `pnpm run build --filter webapp` to verify changes.** Building proves almost nothing about correctness. The webapp is an app, not a public package — use typecheck from the repo root:
88

99
```bash
1010
pnpm run typecheck --filter webapp # ~1-2 minutes
1111
```
1212

1313
Only run typecheck after major changes (new files, significant refactors, schema changes). For small edits, trust the types and let CI catch issues.
1414

15+
Note: Public packages (`packages/*`) use `build` instead. See the root CLAUDE.md for details.
16+
1517
## Testing Dashboard Changes with Chrome DevTools MCP
1618

1719
Use the `chrome-devtools` MCP server to visually verify local dashboard changes. The webapp must be running (`pnpm run dev --filter webapp` from repo root).

apps/webapp/app/presenters/v3/PromptPresenter.server.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ export class PromptPresenter extends BasePresenter {
158158
promptId: string,
159159
options?: { version?: number; label?: string }
160160
) {
161-
if (options?.version) {
161+
if (options?.version != null) {
162162
return this._replica.promptVersion.findUnique({
163163
where: {
164164
promptId_version: {

apps/webapp/app/services/runsReplicationService.server.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -528,7 +528,7 @@ export class RunsReplicationService {
528528
this._lastAcknowledgedAt = now;
529529
this._lastAcknowledgedLsn = this._latestCommitEndLsn;
530530

531-
this.logger.info("acknowledge_latest_transaction", {
531+
this.logger.debug("acknowledge_latest_transaction", {
532532
commitEndLsn: this._latestCommitEndLsn,
533533
lastAcknowledgedAt: this._lastAcknowledgedAt,
534534
});

0 commit comments

Comments
 (0)