Skip to content

Commit 188dac2

Browse files
committed
docs(webapp): trim hot-path comment, note region must stay whereTransform-free
1 parent 126a01f commit 188dac2

2 files changed

Lines changed: 5 additions & 4 deletions

File tree

apps/webapp/app/runEngine/services/triggerTask.server.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -361,10 +361,10 @@ export class RunEngineTriggerTaskService {
361361
const baseWorkerQueue = workerQueueResult?.masterQueue;
362362
const enableFastPath = workerQueueResult?.enableFastPath ?? false;
363363

364-
// Plan-aware compute migration: rewrite the resolved region to its
365-
// compute backing for enrolled orgs. Reads the in-memory global-flags
366-
// snapshot (no DB query). Gate the first read on the registry so a cold
367-
// replica never serves a default over a real flag value.
364+
// Rewrite the region to its compute backing for migration-enrolled orgs,
365+
// from the in-memory flag snapshot (no DB query). The isLoaded gates only
366+
// block during cold start so the first request can't serve a default over
367+
// a real flag; once warm they're a synchronous no-op.
368368
if (!globalFlagsRegistry.isLoaded) {
369369
await globalFlagsRegistry.waitUntilReady(env.GLOBAL_FLAGS_READY_TIMEOUT_MS);
370370
}

apps/webapp/app/v3/querySchemas.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -197,6 +197,7 @@ export const runsSchema: TableSchema = {
197197
description: "Region",
198198
example: "us-east-1",
199199
}),
200+
// No whereTransform: the expression drives WHERE too, so pre-region rows still match.
200201
expression: "multiIf(region != '', region, startsWith(worker_queue, 'cm'), NULL, worker_queue)",
201202
},
202203

0 commit comments

Comments
 (0)