fix(supervisor): address review feedback on compute workload manager

Author: nicktrn

apps/supervisor/src/services/timerWheel.ts

@@ -46,7 +46,7 @@ export class TimerWheel<T> {
     this.cursor = 0;
     this.intervalId = null;
     this.onExpire = opts.onExpire;
-    this.delaySlots = Math.max(1, Math.min(NUM_SLOTS, Math.round(opts.delayMs / TICK_MS)));
+    this.delaySlots = Math.max(1, Math.min(NUM_SLOTS, Math.ceil(opts.delayMs / TICK_MS)));
   }
 
   /** Start the timer wheel. Must be called before submitting items. */
@@ -88,7 +88,7 @@ export class TimerWheel<T> {
    * Clamped to [TICK_MS, 60000ms].
    */
   setDelay(delayMs: number): void {
-    this.delaySlots = Math.max(1, Math.min(NUM_SLOTS, Math.round(delayMs / TICK_MS)));
+    this.delaySlots = Math.max(1, Math.min(NUM_SLOTS, Math.ceil(delayMs / TICK_MS)));
   }
 
   /**

apps/supervisor/src/workloadServer/index.ts

@@ -129,7 +129,15 @@ export class WorkloadServer extends EventEmitter<WorkloadServerEvents> {
     if (this.computeManager && env.COMPUTE_SNAPSHOTS_ENABLED) {
       this.snapshotDelayWheel = new TimerWheel<DelayedSnapshot>({
         delayMs: env.COMPUTE_SNAPSHOT_DELAY_MS,
-        onExpire: (item) => this.dispatchComputeSnapshot(item.data),
+        onExpire: (item) => {
+          this.dispatchComputeSnapshot(item.data).catch((error) => {
+            this.logger.error("Compute snapshot dispatch failed", {
+              runId: item.data.runFriendlyId,
+              runnerId: item.data.runnerId,
+              error,
+            });
+          });
+        },
       });
       this.snapshotDelayWheel.start();
     }
@@ -296,7 +304,14 @@ export class WorkloadServer extends EventEmitter<WorkloadServerEvents> {
                 this.logger.error(
                   "TRIGGER_WORKLOAD_API_DOMAIN is not set, cannot create snapshot callback URL"
                 );
-                reply.json({ error: "Snapshot callbacks not configured" }, false, 500);
+                reply.json(
+                  {
+                    ok: false,
+                    error: "Snapshot callbacks not configured",
+                  } satisfies WorkloadSuspendRunResponseBody,
+                  false,
+                  500
+                );
                 return;
               }