-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Expand file tree
/
Copy pathstreamBatchItems.test.ts
More file actions
515 lines (441 loc) · 15.9 KB
/
streamBatchItems.test.ts
File metadata and controls
515 lines (441 loc) · 15.9 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
import { describe, it, expect, vi, afterEach } from "vitest";
import { ApiClient } from "./index.js";
import { BatchNotSealedError } from "./errors.js";
vi.setConfig({ testTimeout: 10_000 });
describe("streamBatchItems unsealed handling", () => {
const originalFetch = globalThis.fetch;
afterEach(() => {
globalThis.fetch = originalFetch;
vi.restoreAllMocks();
});
/**
* Helper to create a mock fetch that properly consumes the request body stream.
* This is necessary because streamBatchItems sends a ReadableStream body.
* Important: We must release the reader lock after consuming, just like real fetch does.
*/
function createMockFetch(
responses: Array<{
id: string;
itemsAccepted: number;
itemsDeduplicated: number;
sealed: boolean;
enqueuedCount?: number;
expectedCount?: number;
}>
) {
let callIndex = 0;
return vi.fn().mockImplementation(async (_url: string, init?: RequestInit) => {
// Consume the request body stream to prevent hanging
if (init?.body && init.body instanceof ReadableStream) {
const reader = init.body.getReader();
// Drain the stream
try {
while (true) {
const { done } = await reader.read();
if (done) break;
}
} finally {
// Release the lock so the stream can be cancelled later (like real fetch does)
reader.releaseLock();
}
}
const responseData = responses[Math.min(callIndex, responses.length - 1)];
callIndex++;
return {
ok: true,
json: () => Promise.resolve(responseData),
};
});
}
it("throws BatchNotSealedError when sealed=false after retries exhausted", async () => {
const mockFetch = createMockFetch([
{
id: "batch_test123",
itemsAccepted: 5,
itemsDeduplicated: 0,
sealed: false,
enqueuedCount: 5,
expectedCount: 10,
},
]);
globalThis.fetch = mockFetch;
const client = new ApiClient("http://localhost:3030", "tr_test_key");
const error = await client
.streamBatchItems("batch_test123", [{ index: 0, task: "test-task", payload: "{}" }], {
retry: { maxAttempts: 2, minTimeoutInMs: 10, maxTimeoutInMs: 50 },
})
.catch((e) => e);
expect(error).toBeInstanceOf(BatchNotSealedError);
expect((error as BatchNotSealedError).batchId).toBe("batch_test123");
expect((error as BatchNotSealedError).enqueuedCount).toBe(5);
expect((error as BatchNotSealedError).expectedCount).toBe(10);
expect((error as BatchNotSealedError).itemsAccepted).toBe(5);
expect((error as BatchNotSealedError).itemsDeduplicated).toBe(0);
// Should have retried (2 attempts total based on maxAttempts)
expect(mockFetch).toHaveBeenCalledTimes(2);
});
it("retries when sealed=false and succeeds when sealed=true on retry", async () => {
const mockFetch = createMockFetch([
// First response: not sealed
{
id: "batch_test123",
itemsAccepted: 5,
itemsDeduplicated: 0,
sealed: false,
enqueuedCount: 5,
expectedCount: 10,
},
// Second response: sealed
{
id: "batch_test123",
itemsAccepted: 5,
itemsDeduplicated: 0,
sealed: true,
},
]);
globalThis.fetch = mockFetch;
const client = new ApiClient("http://localhost:3030", "tr_test_key");
const result = await client.streamBatchItems(
"batch_test123",
[{ index: 0, task: "test-task", payload: "{}" }],
{ retry: { maxAttempts: 3, minTimeoutInMs: 10, maxTimeoutInMs: 50 } }
);
expect(result.sealed).toBe(true);
// Should have been called twice (first unsealed, second sealed)
expect(mockFetch).toHaveBeenCalledTimes(2);
});
it("succeeds immediately when sealed=true on first attempt", async () => {
const mockFetch = createMockFetch([
{
id: "batch_test123",
itemsAccepted: 10,
itemsDeduplicated: 0,
sealed: true,
},
]);
globalThis.fetch = mockFetch;
const client = new ApiClient("http://localhost:3030", "tr_test_key");
const result = await client.streamBatchItems("batch_test123", [
{ index: 0, task: "test-task", payload: "{}" },
]);
expect(result.sealed).toBe(true);
expect(result.itemsAccepted).toBe(10);
// Should only be called once
expect(mockFetch).toHaveBeenCalledTimes(1);
});
it("BatchNotSealedError has descriptive message", async () => {
const mockFetch = createMockFetch([
{
id: "batch_abc123",
itemsAccepted: 7,
itemsDeduplicated: 2,
sealed: false,
enqueuedCount: 9,
expectedCount: 15,
},
]);
globalThis.fetch = mockFetch;
const client = new ApiClient("http://localhost:3030", "tr_test_key");
const error = await client
.streamBatchItems("batch_abc123", [{ index: 0, task: "test-task", payload: "{}" }], {
retry: { maxAttempts: 1, minTimeoutInMs: 10, maxTimeoutInMs: 50 },
})
.catch((e) => e);
expect(error).toBeInstanceOf(BatchNotSealedError);
expect(error.message).toContain("batch_abc123");
expect(error.message).toContain("9 of 15");
expect(error.message).toContain("accepted: 7");
expect(error.message).toContain("deduplicated: 2");
});
it("handles missing enqueuedCount and expectedCount gracefully", async () => {
// Simulate older server response that might not include these fields
const mockFetch = createMockFetch([
{
id: "batch_test123",
itemsAccepted: 5,
itemsDeduplicated: 0,
sealed: false,
// No enqueuedCount or expectedCount
},
]);
globalThis.fetch = mockFetch;
const client = new ApiClient("http://localhost:3030", "tr_test_key");
const error = await client
.streamBatchItems("batch_test123", [{ index: 0, task: "test-task", payload: "{}" }], {
retry: { maxAttempts: 1, minTimeoutInMs: 10, maxTimeoutInMs: 50 },
})
.catch((e) => e);
expect(error).toBeInstanceOf(BatchNotSealedError);
// Should default to 0 when not provided
expect((error as BatchNotSealedError).enqueuedCount).toBe(0);
expect((error as BatchNotSealedError).expectedCount).toBe(0);
});
});
describe("streamBatchItems stream cancellation on retry", () => {
const originalFetch = globalThis.fetch;
afterEach(() => {
globalThis.fetch = originalFetch;
vi.restoreAllMocks();
});
/**
* Helper to consume a stream and release the lock (simulating fetch behavior).
*/
async function consumeAndRelease(stream: ReadableStream<any>) {
const reader = stream.getReader();
try {
while (true) {
const { done } = await reader.read();
if (done) break;
}
} finally {
reader.releaseLock();
}
}
it("cancels forRequest stream when retrying due to HTTP error", async () => {
// Track cancel calls
let cancelCallCount = 0;
let callIndex = 0;
const mockFetch = vi.fn().mockImplementation(async (_url: string, init?: RequestInit) => {
const currentAttempt = callIndex;
callIndex++;
if (init?.body && init.body instanceof ReadableStream) {
const originalCancel = init.body.cancel.bind(init.body);
init.body.cancel = async (reason?: any) => {
cancelCallCount++;
return originalCancel(reason);
};
// Consume stream and release lock (like real fetch does)
await consumeAndRelease(init.body);
}
// First attempt: return 500 error (retryable)
if (currentAttempt === 0) {
return {
ok: false,
status: 500,
text: () => Promise.resolve("Server error"),
headers: new Headers(),
};
}
// Second attempt: success
return {
ok: true,
json: () =>
Promise.resolve({
id: "batch_test123",
itemsAccepted: 10,
itemsDeduplicated: 0,
sealed: true,
}),
};
});
globalThis.fetch = mockFetch;
const client = new ApiClient("http://localhost:3030", "tr_test_key");
const result = await client.streamBatchItems(
"batch_test123",
[{ index: 0, task: "test-task", payload: "{}" }],
{ retry: { maxAttempts: 3, minTimeoutInMs: 10, maxTimeoutInMs: 50 } }
);
expect(result.sealed).toBe(true);
expect(mockFetch).toHaveBeenCalledTimes(2);
// forRequest should be cancelled once (before first retry)
// forRetry should be cancelled once (after success)
// Total: 2 cancel calls
expect(cancelCallCount).toBeGreaterThanOrEqual(1);
});
it("cancels forRequest stream when retrying due to batch not sealed", async () => {
let cancelCallCount = 0;
let callIndex = 0;
const mockFetch = vi.fn().mockImplementation(async (_url: string, init?: RequestInit) => {
const currentAttempt = callIndex;
callIndex++;
if (init?.body && init.body instanceof ReadableStream) {
const originalCancel = init.body.cancel.bind(init.body);
init.body.cancel = async (reason?: any) => {
cancelCallCount++;
return originalCancel(reason);
};
await consumeAndRelease(init.body);
}
// First attempt: not sealed (triggers retry)
if (currentAttempt === 0) {
return {
ok: true,
json: () =>
Promise.resolve({
id: "batch_test123",
itemsAccepted: 5,
itemsDeduplicated: 0,
sealed: false,
enqueuedCount: 5,
expectedCount: 10,
}),
};
}
// Second attempt: sealed
return {
ok: true,
json: () =>
Promise.resolve({
id: "batch_test123",
itemsAccepted: 5,
itemsDeduplicated: 5,
sealed: true,
}),
};
});
globalThis.fetch = mockFetch;
const client = new ApiClient("http://localhost:3030", "tr_test_key");
const result = await client.streamBatchItems(
"batch_test123",
[{ index: 0, task: "test-task", payload: "{}" }],
{ retry: { maxAttempts: 3, minTimeoutInMs: 10, maxTimeoutInMs: 50 } }
);
expect(result.sealed).toBe(true);
expect(mockFetch).toHaveBeenCalledTimes(2);
// forRequest cancelled before retry + forRetry cancelled after success
expect(cancelCallCount).toBeGreaterThanOrEqual(1);
});
it("cancels forRequest stream when retrying due to connection error", async () => {
let cancelCallCount = 0;
let callIndex = 0;
const mockFetch = vi.fn().mockImplementation(async (_url: string, init?: RequestInit) => {
const currentAttempt = callIndex;
callIndex++;
if (init?.body && init.body instanceof ReadableStream) {
const originalCancel = init.body.cancel.bind(init.body);
init.body.cancel = async (reason?: any) => {
cancelCallCount++;
return originalCancel(reason);
};
// Always consume and release - even for error case
// This simulates what happens when fetch partially reads before failing
// The important thing is the stream lock is released so cancel() can work
await consumeAndRelease(init.body);
}
// First attempt: connection error (simulate by throwing after consuming)
if (currentAttempt === 0) {
throw new TypeError("Failed to fetch");
}
// Second attempt: success
return {
ok: true,
json: () =>
Promise.resolve({
id: "batch_test123",
itemsAccepted: 10,
itemsDeduplicated: 0,
sealed: true,
}),
};
});
globalThis.fetch = mockFetch;
const client = new ApiClient("http://localhost:3030", "tr_test_key");
const result = await client.streamBatchItems(
"batch_test123",
[{ index: 0, task: "test-task", payload: "{}" }],
{ retry: { maxAttempts: 3, minTimeoutInMs: 10, maxTimeoutInMs: 50 } }
);
expect(result.sealed).toBe(true);
expect(mockFetch).toHaveBeenCalledTimes(2);
// forRequest should be cancelled before retry
expect(cancelCallCount).toBeGreaterThanOrEqual(1);
});
it("handles locked stream when connection error occurs mid-read", async () => {
// This test simulates the real-world scenario where fetch throws an error
// while still holding the reader lock on the request body stream.
// This can happen with connection resets, timeouts, or network failures.
let callIndex = 0;
const mockFetch = vi.fn().mockImplementation(async (_url: string, init?: RequestInit) => {
const currentAttempt = callIndex;
callIndex++;
if (init?.body && init.body instanceof ReadableStream) {
if (currentAttempt === 0) {
// First attempt: Get a reader and start reading, but throw while still holding the lock.
// This simulates a connection error that happens mid-transfer.
const reader = init.body.getReader();
await reader.read(); // Start reading
// DON'T release the lock - this simulates fetch crashing mid-read
throw new TypeError("Connection reset by peer");
}
// Subsequent attempts: consume and release normally
await consumeAndRelease(init.body);
}
// Second attempt: success
return {
ok: true,
json: () =>
Promise.resolve({
id: "batch_test123",
itemsAccepted: 10,
itemsDeduplicated: 0,
sealed: true,
}),
};
});
globalThis.fetch = mockFetch;
const client = new ApiClient("http://localhost:3030", "tr_test_key");
// This should NOT throw "ReadableStream is locked" error
// Instead it should gracefully handle the locked stream and retry
const result = await client.streamBatchItems(
"batch_test123",
[{ index: 0, task: "test-task", payload: "{}" }],
{ retry: { maxAttempts: 3, minTimeoutInMs: 10, maxTimeoutInMs: 50 } }
);
expect(result.sealed).toBe(true);
expect(mockFetch).toHaveBeenCalledTimes(2);
});
it("does not leak memory by leaving tee branches unconsumed during multiple retries", async () => {
let cancelCallCount = 0;
let callIndex = 0;
const mockFetch = vi.fn().mockImplementation(async (_url: string, init?: RequestInit) => {
const currentAttempt = callIndex;
callIndex++;
if (init?.body && init.body instanceof ReadableStream) {
const originalCancel = init.body.cancel.bind(init.body);
init.body.cancel = async (reason?: any) => {
cancelCallCount++;
return originalCancel(reason);
};
await consumeAndRelease(init.body);
}
// First two attempts: not sealed
if (currentAttempt < 2) {
return {
ok: true,
json: () =>
Promise.resolve({
id: "batch_test123",
itemsAccepted: 5,
itemsDeduplicated: 0,
sealed: false,
enqueuedCount: 5,
expectedCount: 10,
}),
};
}
// Third attempt: sealed
return {
ok: true,
json: () =>
Promise.resolve({
id: "batch_test123",
itemsAccepted: 5,
itemsDeduplicated: 5,
sealed: true,
}),
};
});
globalThis.fetch = mockFetch;
const client = new ApiClient("http://localhost:3030", "tr_test_key");
const result = await client.streamBatchItems(
"batch_test123",
[{ index: 0, task: "test-task", payload: "{}" }],
{ retry: { maxAttempts: 5, minTimeoutInMs: 10, maxTimeoutInMs: 50 } }
);
expect(result.sealed).toBe(true);
expect(mockFetch).toHaveBeenCalledTimes(3);
// Each retry should cancel forRequest, plus final forRetry cancel
// With 2 retries: 2 forRequest cancels + 1 forRetry cancel = 3 total
expect(cancelCallCount).toBeGreaterThanOrEqual(2);
});
});