You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Spun out of review feedback on #841 (klog → slog migration).
internal/ct/requestlog.go carries its own ad-hoc structured-logging convention (the RL: … prefix on each line) that predates the move to slog. The slog migration preserved the existing prefix but didn't take a position on whether this layer is still needed:
The interface logs request-scoped events (origin, addDERToChain, addCertToChain, issueSCT, status) via the DefaultRequestLog impl, all at slog.LevelDebug.
Most of what it captures arguably belongs in OpenTelemetry spans/events on the request, not in a separate per-request log channel.
Action: decide whether to
Drop requestLog entirely and move the per-request data onto the existing tracing spans, or
Keep it but rename/restructure away from the RL: prefix into proper slog attributes, or
Spun out of review feedback on #841 (klog → slog migration).
internal/ct/requestlog.gocarries its own ad-hoc structured-logging convention (theRL: …prefix on each line) that predates the move toslog. The slog migration preserved the existing prefix but didn't take a position on whether this layer is still needed:origin,addDERToChain,addCertToChain,issueSCT,status) via theDefaultRequestLogimpl, all atslog.LevelDebug.Action: decide whether to
requestLogentirely and move the per-request data onto the existing tracing spans, orRL:prefix into proper slog attributes, orProbably worth doing alongside, or after, the per-request-debug logging review in the sibling issue.