Merge #347: test: add comprehensive unit tests for endpoint_builder module

7621c1e test: add comprehensive unit tests for endpoint_builder module (Jose Celano)

Pull request description:

  ## Description

  This PR adds comprehensive unit tests for the `endpoint_builder` module in the application layer's common command handlers.

  ## Changes

  - Added 16 unit tests covering all three public functions:
    - `build_api_endpoint()` - 5 tests
    - `build_http_tracker_endpoint()` - 5 tests
    - `build_all_tracker_endpoints()` - 6 tests

  ## Test Coverage

  The tests cover:

  - ✅ HTTP endpoint building (without TLS)
  - ✅ HTTPS endpoint building (with TLS)
  - ✅ Correct path handling (`/api/health_check` vs `/health_check`)
  - ✅ Port extraction from configuration
  - ✅ Instance IP usage and propagation
  - ✅ Multiple tracker endpoint building
  - ✅ Empty tracker list handling
  - ✅ Port configuration preservation

  ## Testing Approach

  Following the project's unit testing conventions:
  - Tests are in the same file using `#[cfg(test)] mod tests { ... }`
  - Using behavior-driven naming: `it_should_{behavior}_when_{condition}`
  - Pure unit tests with no external dependencies beyond domain types

  ## Pre-commit Checks

  All pre-commit checks pass:
  - ✅ Cargo machete (no unused dependencies)
  - ✅ Markdown linting
  - ✅ YAML linting
  - ✅ TOML linting
  - ✅ Spell checking
  - ✅ Clippy (all warnings fixed)
  - ✅ Rustfmt
  - ✅ ShellCheck
  - ✅ All tests pass (16/16 new tests + existing test suite)

ACKs for top commit:
  josecelano:
    ACK 7621c1e

Tree-SHA512: 72850de7a2e8bcfb7db45814b71d66dcd3e42802ee6dce22716a5d33ed6e784e4fcf795c5cdd355853e325de932576d31b6dabb5fd98e00a3a1c2fc5c4034ad1

Author: josecelano

src/application/command_handlers/common/endpoint_builder.rs

@@ -126,3 +126,323 @@ pub fn build_all_tracker_endpoints(
 
     (api_endpoint, http_tracker_endpoints)
 }
+
+#[cfg(test)]
+mod tests {
+    use std::net::{IpAddr, Ipv4Addr};
+
+    use super::*;
+    use crate::domain::tracker::config::{
+        DatabaseConfig, HealthCheckApiConfig, HttpApiConfig, HttpTrackerConfig, SqliteConfig,
+        TrackerConfig, TrackerCoreConfig, UdpTrackerConfig,
+    };
+    use crate::shared::{ApiToken, DomainName};
+
+    // Test fixtures
+
+    fn test_ip() -> IpAddr {
+        IpAddr::V4(Ipv4Addr::new(10, 0, 0, 1))
+    }
+
+    fn http_api_config_without_tls() -> HttpApiConfig {
+        HttpApiConfig::new(
+            "0.0.0.0:1212".parse().unwrap(),
+            ApiToken::from("test_token".to_string()),
+            None,
+            false,
+        )
+        .expect("valid config")
+    }
+
+    fn http_api_config_with_tls() -> HttpApiConfig {
+        HttpApiConfig::new(
+            "0.0.0.0:1212".parse().unwrap(),
+            ApiToken::from("test_token".to_string()),
+            Some(DomainName::new("api.tracker.local").unwrap()),
+            true,
+        )
+        .expect("valid config")
+    }
+
+    fn http_tracker_config_without_tls() -> HttpTrackerConfig {
+        HttpTrackerConfig::new("0.0.0.0:7070".parse().unwrap(), None, false).expect("valid config")
+    }
+
+    fn http_tracker_config_with_tls() -> HttpTrackerConfig {
+        HttpTrackerConfig::new(
+            "0.0.0.0:7070".parse().unwrap(),
+            Some(DomainName::new("tracker.example.com").unwrap()),
+            true,
+        )
+        .expect("valid config")
+    }
+
+    fn tracker_config_with_one_http_tracker() -> TrackerConfig {
+        TrackerConfig::new(
+            TrackerCoreConfig::new(
+                DatabaseConfig::Sqlite(SqliteConfig::new("tracker.db").unwrap()),
+                false,
+            ),
+            vec![UdpTrackerConfig::new("0.0.0.0:6969".parse().unwrap(), None).unwrap()],
+            vec![http_tracker_config_without_tls()],
+            http_api_config_without_tls(),
+            HealthCheckApiConfig::new("127.0.0.1:1313".parse().unwrap(), None, false).unwrap(),
+        )
+        .expect("valid config")
+    }
+
+    fn tracker_config_with_multiple_http_trackers() -> TrackerConfig {
+        TrackerConfig::new(
+            TrackerCoreConfig::new(
+                DatabaseConfig::Sqlite(SqliteConfig::new("tracker.db").unwrap()),
+                false,
+            ),
+            vec![],
+            vec![
+                HttpTrackerConfig::new("0.0.0.0:7070".parse().unwrap(), None, false)
+                    .expect("valid config"),
+                HttpTrackerConfig::new("0.0.0.0:8080".parse().unwrap(), None, false)
+                    .expect("valid config"),
+                HttpTrackerConfig::new(
+                    "0.0.0.0:9090".parse().unwrap(),
+                    Some(DomainName::new("tracker.example.com").unwrap()),
+                    true,
+                )
+                .expect("valid config"),
+            ],
+            http_api_config_with_tls(),
+            HealthCheckApiConfig::new("127.0.0.1:1313".parse().unwrap(), None, false).unwrap(),
+        )
+        .expect("valid config")
+    }
+
+    // Tests for build_api_endpoint
+
+    #[test]
+    fn it_should_build_http_api_endpoint_when_tls_is_disabled() {
+        let config = http_api_config_without_tls();
+        let endpoint = build_api_endpoint(test_ip(), &config);
+
+        assert!(!endpoint.uses_tls());
+        assert_eq!(endpoint.server_ip(), test_ip());
+        assert_eq!(endpoint.port(), 1212);
+        assert_eq!(
+            endpoint.url().as_str(),
+            "http://10.0.0.1:1212/api/health_check" // DevSkim: ignore DS137138
+        );
+    }
+
+    #[test]
+    fn it_should_build_https_api_endpoint_when_tls_is_enabled() {
+        let config = http_api_config_with_tls();
+        let endpoint = build_api_endpoint(test_ip(), &config);
+
+        assert!(endpoint.uses_tls());
+        assert_eq!(endpoint.server_ip(), test_ip());
+        assert_eq!(endpoint.port(), 443);
+        assert_eq!(endpoint.domain(), Some("api.tracker.local"));
+        assert_eq!(
+            endpoint.url().as_str(),
+            "https://api.tracker.local/api/health_check"
+        );
+    }
+
+    #[test]
+    fn it_should_use_correct_path_when_building_api_endpoint() {
+        let config = http_api_config_without_tls();
+        let endpoint = build_api_endpoint(test_ip(), &config);
+
+        assert_eq!(endpoint.url().path(), "/api/health_check");
+    }
+
+    #[test]
+    fn it_should_extract_port_from_config_when_building_api_endpoint() {
+        let config = HttpApiConfig::new(
+            "0.0.0.0:9999".parse().unwrap(),
+            ApiToken::from("test".to_string()),
+            None,
+            false,
+        )
+        .expect("valid config");
+
+        let endpoint = build_api_endpoint(test_ip(), &config);
+
+        assert_eq!(endpoint.port(), 9999);
+    }
+
+    #[test]
+    fn it_should_use_instance_ip_when_building_api_endpoint() {
+        let different_ip = IpAddr::V4(Ipv4Addr::new(192, 168, 1, 100));
+        let config = http_api_config_without_tls();
+
+        let endpoint = build_api_endpoint(different_ip, &config);
+
+        assert_eq!(endpoint.server_ip(), different_ip);
+    }
+
+    // Tests for build_http_tracker_endpoint
+
+    #[test]
+    fn it_should_build_http_tracker_endpoint_when_tls_is_disabled() {
+        let config = http_tracker_config_without_tls();
+        let endpoint = build_http_tracker_endpoint(test_ip(), &config);
+
+        assert!(!endpoint.uses_tls());
+        assert_eq!(endpoint.server_ip(), test_ip());
+        assert_eq!(endpoint.port(), 7070);
+        assert_eq!(
+            endpoint.url().as_str(),
+            "http://10.0.0.1:7070/health_check" // DevSkim: ignore DS137138
+        );
+    }
+
+    #[test]
+    fn it_should_build_https_tracker_endpoint_when_tls_is_enabled() {
+        let config = http_tracker_config_with_tls();
+        let endpoint = build_http_tracker_endpoint(test_ip(), &config);
+
+        assert!(endpoint.uses_tls());
+        assert_eq!(endpoint.server_ip(), test_ip());
+        assert_eq!(endpoint.port(), 443);
+        assert_eq!(endpoint.domain(), Some("tracker.example.com"));
+        assert_eq!(
+            endpoint.url().as_str(),
+            "https://tracker.example.com/health_check"
+        );
+    }
+
+    #[test]
+    fn it_should_use_correct_path_when_building_tracker_endpoint() {
+        let config = http_tracker_config_without_tls();
+        let endpoint = build_http_tracker_endpoint(test_ip(), &config);
+
+        assert_eq!(endpoint.url().path(), "/health_check");
+    }
+
+    #[test]
+    fn it_should_extract_port_from_config_when_building_tracker_endpoint() {
+        let config = HttpTrackerConfig::new("0.0.0.0:8888".parse().unwrap(), None, false)
+            .expect("valid config");
+
+        let endpoint = build_http_tracker_endpoint(test_ip(), &config);
+
+        assert_eq!(endpoint.port(), 8888);
+    }
+
+    #[test]
+    fn it_should_use_instance_ip_when_building_tracker_endpoint() {
+        let different_ip = IpAddr::V4(Ipv4Addr::new(172, 16, 0, 50));
+        let config = http_tracker_config_without_tls();
+
+        let endpoint = build_http_tracker_endpoint(different_ip, &config);
+
+        assert_eq!(endpoint.server_ip(), different_ip);
+    }
+
+    // Tests for build_all_tracker_endpoints
+
+    #[test]
+    fn it_should_build_api_and_tracker_endpoints_when_given_tracker_config() {
+        let config = tracker_config_with_one_http_tracker();
+
+        let (api_endpoint, tracker_endpoints) = build_all_tracker_endpoints(test_ip(), &config);
+
+        // Verify API endpoint
+        assert!(!api_endpoint.uses_tls());
+        assert_eq!(api_endpoint.port(), 1212);
+        assert_eq!(api_endpoint.url().path(), "/api/health_check");
+
+        // Verify tracker endpoints
+        assert_eq!(tracker_endpoints.len(), 1);
+        assert!(!tracker_endpoints[0].uses_tls());
+        assert_eq!(tracker_endpoints[0].port(), 7070);
+        assert_eq!(tracker_endpoints[0].url().path(), "/health_check");
+    }
+
+    #[test]
+    fn it_should_build_multiple_tracker_endpoints_when_multiple_trackers_configured() {
+        let config = tracker_config_with_multiple_http_trackers();
+
+        let (_api_endpoint, tracker_endpoints) = build_all_tracker_endpoints(test_ip(), &config);
+
+        assert_eq!(tracker_endpoints.len(), 3);
+
+        // First tracker (HTTP on 7070)
+        assert!(!tracker_endpoints[0].uses_tls());
+        assert_eq!(tracker_endpoints[0].port(), 7070);
+
+        // Second tracker (HTTP on 8080)
+        assert!(!tracker_endpoints[1].uses_tls());
+        assert_eq!(tracker_endpoints[1].port(), 8080);
+
+        // Third tracker (HTTPS on 9090 -> 443)
+        assert!(tracker_endpoints[2].uses_tls());
+        assert_eq!(tracker_endpoints[2].port(), 443);
+        assert_eq!(tracker_endpoints[2].domain(), Some("tracker.example.com"));
+    }
+
+    #[test]
+    fn it_should_build_tls_api_endpoint_when_tracker_config_has_tls_enabled() {
+        let config = tracker_config_with_multiple_http_trackers();
+
+        let (api_endpoint, _tracker_endpoints) = build_all_tracker_endpoints(test_ip(), &config);
+
+        assert!(api_endpoint.uses_tls());
+        assert_eq!(api_endpoint.domain(), Some("api.tracker.local"));
+        assert_eq!(
+            api_endpoint.url().as_str(),
+            "https://api.tracker.local/api/health_check"
+        );
+    }
+
+    #[test]
+    fn it_should_return_empty_tracker_list_when_no_http_trackers_configured() {
+        let config = TrackerConfig::new(
+            TrackerCoreConfig::new(
+                DatabaseConfig::Sqlite(SqliteConfig::new("tracker.db").unwrap()),
+                false,
+            ),
+            vec![UdpTrackerConfig::new("0.0.0.0:6969".parse().unwrap(), None).unwrap()],
+            vec![], // No HTTP trackers
+            http_api_config_without_tls(),
+            HealthCheckApiConfig::new("127.0.0.1:1313".parse().unwrap(), None, false).unwrap(),
+        )
+        .expect("valid config");
+
+        let (_api_endpoint, tracker_endpoints) = build_all_tracker_endpoints(test_ip(), &config);
+
+        assert!(tracker_endpoints.is_empty());
+    }
+
+    #[test]
+    fn it_should_use_same_instance_ip_for_all_endpoints_when_building_all() {
+        let config = tracker_config_with_multiple_http_trackers();
+        let specific_ip = IpAddr::V4(Ipv4Addr::new(203, 0, 113, 42));
+
+        let (api_endpoint, tracker_endpoints) = build_all_tracker_endpoints(specific_ip, &config);
+
+        // All endpoints should use the same instance IP
+        assert_eq!(api_endpoint.server_ip(), specific_ip);
+        for endpoint in &tracker_endpoints {
+            assert_eq!(endpoint.server_ip(), specific_ip);
+        }
+    }
+
+    #[test]
+    fn it_should_preserve_individual_port_configurations_when_building_all() {
+        let config = tracker_config_with_multiple_http_trackers();
+
+        let (_api_endpoint, tracker_endpoints) = build_all_tracker_endpoints(test_ip(), &config);
+
+        // Each tracker should preserve its configured port (or use 443 for HTTPS)
+        let ports: Vec<u16> = tracker_endpoints
+            .iter()
+            .map(ServiceEndpoint::port)
+            .collect();
+
+        // First two are HTTP (use configured ports), third is HTTPS (uses 443)
+        assert_eq!(ports[0], 7070);
+        assert_eq!(ports[1], 8080);
+        assert_eq!(ports[2], 443); // HTTPS default port
+    }
+}