Test missing and wildcard Accept headers

Author: RealOrangeOne

tbx/core/tests/test_views.py

@@ -110,11 +110,6 @@ def test_setting_theme_on_one_site_sets_it_on_multiple_sites(self):
 class PageNotFoundTestCase(TestCase):
     url = "/does-not-exist/"
 
-    def test_accessible(self) -> None:
-        response = self.client.get(self.url)
-        self.assertEqual(response.status_code, 404)
-        self.assertIn("text/html", response.headers["content-type"])
-
     def test_accept_html(self) -> None:
         response = self.client.get(self.url, headers={"Accept": "text/html"})
         self.assertEqual(response.status_code, 404)
@@ -131,3 +126,26 @@ def test_simple_when_html_not_highest(self) -> None:
         )
         self.assertEqual(response.status_code, 404)
         self.assertIn("text/plain", response.headers["content-type"])
+
+    def test_missing_accept_header(self) -> None:
+        response = self.client.get(self.url, headers={"Accept": ""})
+        self.assertEqual(response.status_code, 404)
+        self.assertIn("text/plain", response.headers["content-type"])
+
+    def test_wildcard_accept_header(self) -> None:
+        response = self.client.get(self.url, headers={"Accept": "*/*"})
+        self.assertEqual(response.status_code, 404)
+        self.assertIn("text/plain", response.headers["content-type"])
+
+    def test_browser_request(self) -> None:
+        """
+        Test Accept header from Firefox 128
+        """
+        response = self.client.get(
+            self.url,
+            headers={
+                "Accept": "text/html,application/xhtml+xml,application/xml;q=0.9,image/avif,image/webp,image/png,image/svg+xml,*/*;q=0.8"  # noqa:E501
+            },
+        )
+        self.assertEqual(response.status_code, 404)
+        self.assertIn("text/html", response.headers["content-type"])

tbx/core/utils/views.py

@@ -10,8 +10,15 @@ def get_quality(media_type):
 
 
 def show_html_error_page(request):
+    # If there is no `Accept` header, serve the simpler page
+    if not request.headers.get("Accept"):
+        return False
+
     accepted_types = sorted(request.accepted_types, key=get_quality, reverse=True)
 
+    if len(accepted_types) == 1 and accepted_types[0].match("*/*"):
+        return False
+
     html_type = next(
         (
             accepted_type