Skip to content

Commit 2cd9e80

Browse files
Copilottoolate28
andcommitted
fix: address code review feedback for agent_skills.py
Co-authored-by: toolate28 <105518313+toolate28@users.noreply.github.com>
1 parent a1608b7 commit 2cd9e80

1 file changed

Lines changed: 10 additions & 6 deletions

File tree

agent_skills.py

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -237,6 +237,10 @@ def review_pr() -> dict:
237237
# Fibonacci sequence for weighted calculations
238238
FIBONACCI = [1, 1, 2, 3, 5, 8, 13, 21, 34, 55, 89, 144]
239239

240+
# Expected number of surjection transitions in the corpus
241+
# (Repos→Phases, Forks→Contributions, Tags→ATOM, Relations→Lattice, Discussions→KB, Tools→HOPE)
242+
EXPECTED_SURJECTION_TRANSITIONS = 6
243+
240244

241245
def load_vortex_corpus(path: Optional[str] = None) -> Dict[str, Any]:
242246
"""
@@ -330,8 +334,8 @@ def _enforce_surjections(corpus: Dict[str, Any]) -> Dict[str, Any]:
330334
# Check Fibonacci phase weights are properly ordered and valid
331335
if fib_phases:
332336
weights = [p.get('fib_weight', 0) for p in fib_phases]
333-
# Check monotonic increasing
334-
is_monotonic = all(weights[i] <= weights[i+1] for i in range(len(weights)-1))
337+
# Check strictly increasing (Fibonacci values should increase)
338+
is_monotonic = all(weights[i] < weights[i+1] for i in range(len(weights)-1))
335339
# Check all weights are valid Fibonacci numbers
336340
fib_set = set(FIBONACCI)
337341
all_fib = all(w in fib_set for w in weights)
@@ -413,7 +417,7 @@ def _auto_curl_divergences(corpus: Dict[str, Any]) -> Dict[str, Any]:
413417
'type': 'quality_below_threshold',
414418
'current': emergent_quality,
415419
'required': quality_min,
416-
'message': f'Emergent quality {emergent_quality:.1%} below minimum {quality_min:.0%}'
420+
'message': f'Emergent quality {emergent_quality:.1%} below minimum {quality_min:.1%}'
417421
})
418422
curl_detected = True
419423

@@ -439,12 +443,12 @@ def _auto_curl_divergences(corpus: Dict[str, Any]) -> Dict[str, Any]:
439443
transitions = corpus.get('transitions_mapping', {})
440444
surjection_transitions = transitions.get('surjection_transitions', [])
441445

442-
if len(surjection_transitions) < 6:
446+
if len(surjection_transitions) < EXPECTED_SURJECTION_TRANSITIONS:
443447
divergences.append({
444448
'type': 'incomplete_transitions',
445449
'count': len(surjection_transitions),
446-
'expected': 6,
447-
'message': f'Only {len(surjection_transitions)} of 6 expected transitions defined'
450+
'expected': EXPECTED_SURJECTION_TRANSITIONS,
451+
'message': f'Only {len(surjection_transitions)} of {EXPECTED_SURJECTION_TRANSITIONS} expected transitions defined'
448452
})
449453
curl_detected = True
450454

0 commit comments

Comments
 (0)