Skip to content

review of the code 09.02.2023 #7

@MarkoKermi

Description

@MarkoKermi

Hello @teitonny,
You did great job, everything is working great and all requirement are met.
There is some suggestions bellow:

  • In the score place holder, it should be possible to enter only numbers. Try to change the HTML file line 36, the type should be number instead of text. That should fix the issue.
  • Try to use :root so you can write the colors that you are using in CSS. The code will look more clear.
  • In CSS file you have unnecessary lines at the end, that can cause you an linters errors. It's better to delete that part.
  • The entering form look nice but it keeps the last entered values and name, it should be reset when you press the submit button. Try to fix that issue as well.

Happy coding!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions