fix(ci): do not comment from linter.yml in forks and enable exponential backoff for workflow functions in common.mjs (#1523)

Author: novusnota

.github/scripts/common.mjs

@@ -6,45 +6,54 @@ export async function hidePriorCommentsWithPrefix({
   resolved = true,
   user = 'github-actions[bot]',
 }) {
-  const comments = await github.rest.issues.listComments({
-    owner: context.repo.owner,
-    repo: context.repo.repo,
-    issue_number: context.issue.number,
-  });
+  const comments = await withRetry(() =>
+    github.rest.issues.listComments({
+      owner: context.repo.owner,
+      repo: context.repo.repo,
+      issue_number: context.issue.number,
+    })
+  );
+  await exec.exec('sleep 0.5s');
   for (const comment of comments.data) {
-    const isHidden = (await github.graphql(`
-      query($nodeId: ID!) {
-        node(id: $nodeId) {
-          ... on IssueComment {
-            isMinimized
+    const commentData = await withRetry(() =>
+      github.graphql(`
+        query($nodeId: ID!) {
+          node(id: $nodeId) {
+            ... on IssueComment {
+              isMinimized
+            }
           }
         }
-      }
-    `, { nodeId: comment.node_id }))?.node?.isMinimized;
+      `, { nodeId: comment.node_id })
+    );
     await exec.exec('sleep 0.5s');
+    const isHidden = commentData?.node?.isMinimized;
     if (isHidden) { continue; }
     if (
       comment.user.login === user &&
       comment.body.startsWith(prefix)
     ) {
       console.log('Comment node_id:', comment.node_id);
-      console.log(await github.graphql(`
-        mutation($subjectId: ID!, $classifier: ReportedContentClassifiers!) {
-          minimizeComment(input: {
-            subjectId: $subjectId,
-            classifier: $classifier
-          }) {
-            minimizedComment {
-              isMinimized
-              minimizedReason
+      const commentStatus = await withRetry(() =>
+        github.graphql(`
+          mutation($subjectId: ID!, $classifier: ReportedContentClassifiers!) {
+            minimizeComment(input: {
+              subjectId: $subjectId,
+              classifier: $classifier
+            }) {
+              minimizedComment {
+                isMinimized
+                minimizedReason
+              }
             }
           }
-        }
-      `, {
-        subjectId: comment.node_id,
-        classifier: resolved ? 'RESOLVED' : 'OUTDATED',
-      }));
+        `, {
+          subjectId: comment.node_id,
+          classifier: resolved ? 'RESOLVED' : 'OUTDATED',
+        })
+      );
       await exec.exec('sleep 0.5s');
+      console.log(commentStatus);
     }
   }
 }
@@ -55,10 +64,35 @@ export async function createComment({
   exec, // injected by GitHub
   body = '',
 }) {
-  await github.rest.issues.createComment({
-    owner: context.repo.owner,
-    repo: context.repo.repo,
-    issue_number: context.issue.number,
-    body: body,
-  });
+  await withRetry(() =>
+    github.rest.issues.createComment({
+      owner: context.repo.owner,
+      repo: context.repo.repo,
+      issue_number: context.issue.number,
+      body: body,
+    })
+  );
+}
+
+/** @param fn {() => Promise<any>} */
+async function withRetry(fn, maxRetries = 3, baseDelayMs = 1500) {
+  let lastError;
+  for (let attempt = 1; attempt <= maxRetries; attempt += 1) {
+    try {
+      return await fn();
+    } catch (error) {
+      // Don't retry on 4xx errors (client errors), only on 5xx or network issues
+      if (error.status && error.status >= 400 && error.status < 500) {
+        throw error;
+      }
+      lastError = error;
+
+      // Exponential backoff
+      const delay = baseDelayMs * Math.pow(2, attempt - 1);
+      console.log(`Attempt ${attempt} failed, retrying in ${delay / 1000}s...`);
+      await new Promise((resolve) => setTimeout(resolve, delay));
+    }
+  }
+  // Did not produce results after multiple retries
+  throw lastError;
 }

.github/workflows/linter.yml

@@ -86,7 +86,10 @@ jobs:
             !cancelled() &&
             steps.changed-files.conclusion == 'success' &&
             github.event_name == 'pull_request' &&
-            github.event_name != 'pull_request_target'
+            (
+              github.event.pull_request.head.repo.fork == true ||
+              github.event.pull_request.head.repo.full_name != github.repository
+            )
           )
         env:
           ALL_CHANGED_FILES: ${{ steps.changed-files.outputs.all_changed_files }}