Skip to content

Commit bd161e7

Browse files
committed
Use qualified names when encoding vertices and triangles
1 parent ebe8789 commit bd161e7

3 files changed

Lines changed: 6 additions & 5 deletions

File tree

Package.resolved

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Package.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import PackageDescription
44

55
let package = Package(
66
name: "ThreeMF",
7-
platforms: [.iOS(.v13)],
7+
platforms: [.macOS(.v10_15), .iOS(.v13)],
88
products: [
99
.library(name: "ThreeMF", targets: ["ThreeMF"])
1010
],

Sources/ThreeMF/Resources/Object/Mesh.swift

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,10 @@ public struct Mesh: Sendable, XMLElementCodable {
1313
}
1414

1515
public func encode(to element: Node) {
16-
element.encode(vertices, elementName: Core.vertex, containedIn: Core.vertices)
17-
element.encode(triangles, elementName: Core.triangle, containedIn: Core.triangles)
18-
element.encode(triangleSets, elementName: TriangleSets.triangleSet, containedIn: TriangleSets.triangleSets)
16+
// Use qualified names here as an optimization. We're producing output and have full control.
17+
element.encode(vertices, elementName: Core.vertex.localName, containedIn: Core.vertices)
18+
element.encode(triangles, elementName: Core.triangle.localName, containedIn: Core.triangles)
19+
element.encode(triangleSets, elementName: TriangleSets.triangleSet.localName, containedIn: TriangleSets.triangleSets)
1920
}
2021

2122
public init(from element: Node) throws {

0 commit comments

Comments
 (0)