Skip to content

NPM echo-js pulling older version than stated #119

@brianchristopherpeck

Description

@brianchristopherpeck

npm install echo-js pulls version 1.7.0 instead of 1.7.3 as of 9/5/17. On install, it says
└── echo-js@1.7.3
The main difference in versions is this line:
var nodes = (context || document).querySelectorAll('[data-echo], [data-echo-background]');
which in the older version being downloaded is this:
var nodes = (context || document).querySelectorAll('img[data-echo], [data-echo-background]');
This forces only images whereas in 1.7.3, the removal of the image selector allows to lazy-load other media like youtube videos

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions