Skip to content

Commit 652cf3a

Browse files
committed
fix(tests): skip flaky waiter test on tmux 3.4
why: test_wait_for_pane_content_exact_match_detailed is flaky on tmux 3.4 due to capture-pane line wrapping behavior differences introduced in that version (commit 9cc8e40a added GRID_STRING_EMPTY_CELLS flag) what: - Add pytest.mark.skipif to skip test on tmux 3.4 specifically - Import has_version for exact version checking
1 parent 812c164 commit 652cf3a

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

tests/_internal/test_waiter.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
wait_for_window_panes,
2828
wait_until_pane_ready,
2929
)
30-
from libtmux.common import has_gte_version
30+
from libtmux.common import has_gte_version, has_version
3131
from libtmux.exc import WaitTimeout
3232

3333
if TYPE_CHECKING:
@@ -1835,6 +1835,10 @@ def test_wait_for_pane_content_specific_type_errors(wait_pane: Pane) -> None:
18351835
assert ERR_PREDICATE_TYPE in str(excinfo.value)
18361836

18371837

1838+
@pytest.mark.skipif(
1839+
has_version("3.4"),
1840+
reason="Flaky on tmux 3.4 due to capture-pane line wrapping differences",
1841+
)
18381842
def test_wait_for_pane_content_exact_match_detailed(wait_pane: Pane) -> None:
18391843
"""Test wait_for_pane_content with EXACT match type in detail.
18401844

0 commit comments

Comments
 (0)