prevented zero length modifications

Author: ic0ns

src/main/java/de/rub/nds/modifiablevariable/bytearray/ByteArrayModificationFactory.java

@@ -49,11 +49,10 @@ public class ByteArrayModificationFactory {
     public static final String FILE_NAME = "de/rub/nds/modifiablevariable/explicit/array.vec";
 
     /**
-     * 
-     * @param xor
-     *            bytes to xor
-     * @param startPosition
-     *            negative numbers mean that the position is taken from the end
+     *
+     * @param xor bytes to xor
+     * @param startPosition negative numbers mean that the position is taken
+     * from the end
      * @return variable modification
      */
     public static VariableModification<byte[]> xor(final byte[] xor, final int startPosition) {
@@ -62,8 +61,7 @@ public static VariableModification<byte[]> xor(final byte[] xor, final int start
 
     /**
      *
-     * @param payload
-     *            bytes are set as value
+     * @param payload bytes are set as value
      * @return variable modification
      */
     public static VariableModification<byte[]> payload(final byte[] payload) {
@@ -72,11 +70,10 @@ public static VariableModification<byte[]> payload(final byte[] payload) {
 
     /**
      * *
-     * 
-     * @param bytesToInsert
-     *            bytes to xor
-     * @param startPosition
-     *            negative numbers mean that the position is taken from the end
+     *
+     * @param bytesToInsert bytes to xor
+     * @param startPosition negative numbers mean that the position is taken
+     * from the end
      * @return variable modification
      */
     public static VariableModification<byte[]> insert(final byte[] bytesToInsert, final int startPosition) {
@@ -85,11 +82,10 @@ public static VariableModification<byte[]> insert(final byte[] bytesToInsert, fi
 
     /**
      * * Deletes $count bytes from the input array beginning at $startPosition
-     * 
-     * @param startPosition
-     *            negative numbers mean that the position is taken from the end
-     * @param count
-     *            number of bytes to be deleted
+     *
+     * @param startPosition negative numbers mean that the position is taken
+     * from the end
+     * @param count number of bytes to be deleted
      * @return variable modification
      */
     public static VariableModification<byte[]> delete(final int startPosition, final int count) {
@@ -98,7 +94,7 @@ public static VariableModification<byte[]> delete(final int startPosition, final
 
     /**
      * Duplicates the byte array
-     * 
+     *
      * @return duplicate variable modification
      */
     public static VariableModification<byte[]> duplicate() {
@@ -117,9 +113,8 @@ public static VariableModification<byte[]> explicitValueFromFile(int value) {
 
     /**
      * Shuffles the bytes in the array, given a specified array of positions.
-     * 
-     * @param shuffle
-     *            positions that define shuffling
+     *
+     * @param shuffle positions that define shuffling
      * @return shuffling variable modification
      */
     public static VariableModification<byte[]> shuffle(final byte[] shuffle) {
@@ -162,13 +157,19 @@ public static VariableModification<byte[]> createRandomModification(byte[] origi
         switch (r) {
             case BYTE_ARRAY_XOR_MODIFICATION:
                 int modificationArrayLength = random.nextInt(modifiedArrayLength);
+                if (modificationArrayLength == 0) {
+                    modificationArrayLength++;
+                }
                 byte[] xor = new byte[modificationArrayLength];
                 random.nextBytes(xor);
                 int startPosition = random.nextInt(modifiedArrayLength - modificationArrayLength);
                 vm = new ByteArrayXorModification(xor, startPosition);
                 return vm;
             case BYTE_ARRAY_INSERT_MODIFICATION:
                 modificationArrayLength = random.nextInt(MAX_CONFIG_PARAMETER);
+                if (modificationArrayLength == 0) {
+                    modificationArrayLength++;
+                }
                 byte[] bytesToInsert = new byte[modificationArrayLength];
                 random.nextBytes(bytesToInsert);
                 int insertPosition = random.nextInt(modifiedArrayLength);
@@ -182,6 +183,9 @@ public static VariableModification<byte[]> createRandomModification(byte[] origi
                 return vm;
             case BYTE_ARRAY_EXPLICIT_VALUE_MODIFICATION:
                 modificationArrayLength = random.nextInt(MAX_CONFIG_PARAMETER);
+                if (modificationArrayLength == 0) {
+                    modificationArrayLength++;
+                }
                 byte[] explicitValue = new byte[modificationArrayLength];
                 random.nextBytes(explicitValue);
                 vm = new ByteArrayExplicitValueModification(explicitValue);