backup: prefer CLI datastore path when merging inventory

Fix PBS datastore inventory merge so the runtime CLI path overrides datastore.cfg for the same datastore identity. Add a regression test covering config-vs-CLI path precedence during merge.

Author: tis24dev

internal/backup/collector_pbs_datastore_inventory.go

@@ -496,7 +496,7 @@ func mergePBSDatastoreDefinitions(cli, config []pbsDatastore) []pbsDatastoreDefi
 		if entry.Name == "" && name != "" {
 			entry.Name = name
 		}
-		if entry.Path == "" && path != "" {
+		if path != "" && (entry.Path == "" || origin == pbsDatastoreSourceCLI) {
 			entry.Path = path
 		}
 		if entry.Comment == "" && comment != "" {

internal/backup/collector_pbs_datastore_inventory_test.go

@@ -351,6 +351,39 @@ func TestMergePBSDatastoreDefinitionsKeepsOverridesSeparate(t *testing.T) {
 	}
 }
 
+func TestMergePBSDatastoreDefinitionsPrefersCLIPathOverConfigPath(t *testing.T) {
+	config := []pbsDatastore{{
+		Name:           "backup",
+		Path:           "/config/backup",
+		Comment:        "from config",
+		Source:         pbsDatastoreSourceConfig,
+		CLIName:        "backup",
+		NormalizedPath: normalizePBSDatastorePath("/config/backup"),
+		OutputKey:      collectorPathKey("backup"),
+	}}
+	cli := []pbsDatastore{{
+		Name:           "backup",
+		Path:           "/runtime/backup",
+		Comment:        "from cli",
+		Source:         pbsDatastoreSourceCLI,
+		CLIName:        "backup",
+		NormalizedPath: normalizePBSDatastorePath("/runtime/backup"),
+		OutputKey:      collectorPathKey("backup"),
+	}}
+
+	merged := mergePBSDatastoreDefinitions(cli, config)
+	if len(merged) != 1 {
+		t.Fatalf("expected 1 merged entry, got %d: %+v", len(merged), merged)
+	}
+
+	if merged[0].Origin != pbsDatastoreOriginMerged {
+		t.Fatalf("expected merged origin, got %+v", merged[0])
+	}
+	if merged[0].Path != "/runtime/backup" {
+		t.Fatalf("expected CLI path to win, got %+v", merged[0])
+	}
+}
+
 func TestMergePBSDatastoreDefinitionsDisambiguatesCLIAndOverrideOutputKeyCollisions(t *testing.T) {
 	overridePath := "/mnt/a/backup"
 	collidingKey := buildPBSOverrideOutputKey(overridePath)