-
Notifications
You must be signed in to change notification settings - Fork 2.5k
fix(tauri): forward hot-instance OAuth deep links #2229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -50,8 +50,10 @@ tauri-plugin-opener = "2" | |
| # `cef::initialize(...) != 1` cache-lock panic seen in production | ||
| # (Sentry OPENHUMAN-TAURI-A). The plugin acquires a per-identifier | ||
| # lock before any tauri::Builder work happens, so the secondary | ||
| # process exits cleanly after handing its argv to the primary. | ||
| tauri-plugin-single-instance = "2" | ||
| # process exits cleanly after handing its argv to the primary. The `deep-link` | ||
| # feature forwards second-launch deep-link payloads to the primary instance on | ||
| # Windows/Linux, which is required for hot-instance OAuth callbacks. | ||
| tauri-plugin-single-instance = { version = "2", features = ["deep-link"] } | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Added a regression test in 4065975 — |
||
| # Auto-update for the Tauri shell itself. The core sidecar already has its own | ||
| # updater (see `core_update.rs`); this plugin handles the .app/.exe/.AppImage | ||
| # bundle. Both are needed because shipping a new RPC method requires both | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[major] Missing regression test required by #2228 acceptance criteria.
The issue explicitly lists:
Suggestion: add a build-time assertion that
tauri-plugin-single-instanceincludes thedeep-linkfeature, e.g.:Alternatively, a CI script assertion using
cargo metadata --no-depsworks too — the PR's own validation section already describes the command.