Skip to content

Commit a1a3f88

Browse files
Copilotti-chi-botwuhuizuo
authored
[fix #430] pin gocov to v1.1.0 and remove duplicate install step in CDC CI (#431)
Signed-off-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> Signed-off-by: wuhuizuo <wuhuizuo@126.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: ti-chi-bot <71242396+ti-chi-bot@users.noreply.github.com> Co-authored-by: wuhuizuo <wuhuizuo@126.com>
1 parent e056406 commit a1a3f88

4 files changed

Lines changed: 35 additions & 144 deletions

File tree

.github/workflows/build.yml

Lines changed: 0 additions & 53 deletions
This file was deleted.

.github/workflows/ci-cdc.yml

Lines changed: 34 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -1,52 +1,50 @@
11
name: TiKV-CDC
2+
23
on:
34
push:
4-
branches: main
5-
paths: cdc/**
5+
branches:
6+
- main
7+
paths:
8+
- "cdc/**"
9+
- ".github/workflows/ci-cdc.yml"
610
pull_request:
7-
branches: main
8-
paths: cdc/**
11+
branches:
12+
- main
13+
paths:
14+
- "cdc/**"
15+
- ".github/workflows/ci-cdc.yml"
916

1017
permissions:
1118
contents: read
1219

13-
env:
14-
GO_VERSION: 1.21.4
20+
concurrency:
21+
group: ci-cdc-${{ github.workflow }}-${{ github.ref }}
22+
cancel-in-progress: true
23+
24+
defaults:
25+
run:
26+
shell: bash
27+
working-directory: cdc
1528

1629
jobs:
17-
cdc-lint:
30+
verify-cdc:
1831
runs-on: ubuntu-latest
32+
timeout-minutes: 30
1933
steps:
20-
- uses: actions/checkout@v2
21-
- uses: actions/setup-go@v2
34+
- uses: actions/checkout@v4
35+
- uses: actions/setup-go@v5
2236
with:
23-
go-version: '${{ env.GO_VERSION }}'
37+
go-version-file: cdc/go.mod
38+
cache-dependency-path: |
39+
cdc/go.sum
40+
cdc/tools/check/go.sum
2441
- name: make check
25-
shell: bash
26-
run: |
27-
cd cdc/
28-
make check
29-
cdc-check-gosec:
30-
runs-on: ubuntu-latest
31-
steps:
32-
- uses: actions/checkout@v2
33-
- uses: actions/setup-go@v2
34-
with:
35-
go-version: '${{ env.GO_VERSION }}'
42+
run: make check
3643
- name: make check-gosec
37-
shell: bash
38-
run: |
39-
cd cdc/
40-
make check-gosec
41-
cdc-build:
42-
runs-on: ubuntu-latest
43-
steps:
44-
- uses: actions/checkout@v2
45-
- uses: actions/setup-go@v2
46-
with:
47-
go-version: '${{ env.GO_VERSION }}'
44+
run: make check-gosec
4845
- name: make cdc
49-
shell: bash
50-
run: |
51-
cd cdc/
52-
make cdc
46+
run: make cdc
47+
- name: make unit_test_in_verify_ci
48+
env:
49+
TIKV_MIGRATION_CODECOV_TOKEN: ${{ secrets.TIKV_MIGRATION_CODECOV_TOKEN }}
50+
run: make unit_test_in_verify_ci

.github/workflows/test.yml

Lines changed: 0 additions & 54 deletions
This file was deleted.

cdc/tools/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ tools/bin/oapi-codegen: tools/check/go.mod
3434
cd tools/check && $(GO) build -mod=mod -o ../bin/oapi-codegen github.com/deepmap/oapi-codegen/cmd/oapi-codegen
3535

3636
gocov:
37-
$(GO) install github.com/axw/gocov/gocov@latest
37+
$(GO) install github.com/axw/gocov/gocov@v1.1.0
3838

3939
gocov-xml:
4040
$(GO) install github.com/AlekSi/gocov-xml@latest

0 commit comments

Comments
 (0)