Update engine specific arguments for boost_tree()

Author: juliasilge

R/boost_tree.R

@@ -163,7 +163,8 @@ update.boost_tree <-
            loss_reduction = NULL, sample_size = NULL,
            stop_iter = NULL,
            fresh = FALSE, ...) {
-    update_dot_check(...)
+
+    eng_args <- update_engine_parameters(object$eng_args, ...)
 
     if (!is.null(parameters)) {
       parameters <- check_final_param(parameters)
@@ -185,12 +186,15 @@ update.boost_tree <-
     # TODO make these blocks into a function and document well
     if (fresh) {
       object$args <- args
+      object$eng_args <- eng_args
     } else {
       null_args <- map_lgl(args, null_value)
       if (any(null_args))
         args <- args[!null_args]
       if (length(args) > 0)
         object$args[names(args)] <- args
+      if (length(eng_args) > 0)
+        object$eng_args[names(eng_args)] <- eng_args
     }
 
     new_model_spec(

tests/testthat/test_boost_tree.R

@@ -109,14 +109,19 @@ test_that('updating', {
   expr1     <- boost_tree() %>% set_engine("xgboost", verbose = 0)
   expr1_exp <- boost_tree(trees = 10) %>% set_engine("xgboost", verbose = 0)
 
-  expr2     <- boost_tree(trees = varying()) %>% set_engine("xgboost")
-  expr2_exp <- boost_tree(trees = varying())  %>% set_engine("xgboost", verbose = 0)
+  expr2     <- boost_tree(trees = varying()) %>% set_engine("C5.0", bands = varying())
+  expr2_exp <- boost_tree(trees = varying())  %>% set_engine("C5.0", bands = 10)
 
   expr3     <- boost_tree(trees = 1, sample_size = varying())
   expr3_exp <- boost_tree(trees = 1)
 
+  expr4     <- boost_tree() %>% set_engine("C5.0", noGlobalPruning = varying())
+  expr4_exp <- boost_tree() %>% set_engine("C5.0", noGlobalPruning = TRUE)
+
   expect_equal(update(expr1, trees = 10), expr1_exp)
+  expect_equal(update(expr2, bands = 10), expr2_exp)
   expect_equal(update(expr3, trees = 1, fresh = TRUE), expr3_exp)
+  expect_equal(update(expr4, noGlobalPruning = TRUE), expr4_exp)
 
   param_tibb <- tibble::tibble(trees = 7, mtry = 1)
   param_list <- as.list(param_tibb)