fixed ReflectionNormalizer to include inherited properties not returned by default by ReflectionClass::getProperties

Author: thunderer

src/Normalizer/ReflectionNormalizer.php

@@ -18,14 +18,18 @@ public function __invoke($var)
         $ref = new \ReflectionObject($var);
 
         $result = array();
-        foreach($ref->getProperties() as $property) {
-            if(in_array($property->getName(), $this->skipped)) {
-                continue;
-            }
+        while($ref) {
+            foreach($ref->getProperties() as $property) {
+                if(in_array($property->getName(), $this->skipped)) {
+                    continue;
+                }
+
+                $property->setAccessible(true);
 
-            $property->setAccessible(true);
+                $result[$property->getName()] = $property->getValue($var);
+            }
 
-            $result[$property->getName()] = $property->getValue($var);
+            $ref = $ref->getParentClass();
         }
 
         return $result;

tests/Fake/Inheritance/FakeClass.php

@@ -0,0 +1,19 @@
+<?php
+namespace Thunder\Serializard\Tests\Fake\Inheritance;
+
+class FakeClass extends FakeClassParent
+{
+    private $property;
+
+    public function __construct($parentParent, $parent, $property)
+    {
+        parent::__construct($parentParent, $parent);
+
+        $this->property = $property;
+    }
+
+    public function getProperty()
+    {
+        return $this->property;
+    }
+}

tests/Fake/Inheritance/FakeClassParent.php

@@ -0,0 +1,19 @@
+<?php
+namespace Thunder\Serializard\Tests\Fake\Inheritance;
+
+class FakeClassParent extends FakeClassParentParent
+{
+    private $parentProperty;
+
+    public function __construct($parent, $property)
+    {
+        parent::__construct($parent);
+
+        $this->parentProperty = $property;
+    }
+
+    public function getParentProperty()
+    {
+        return $this->parentProperty;
+    }
+}

tests/Fake/Inheritance/FakeClassParentParent.php

@@ -0,0 +1,17 @@
+<?php
+namespace Thunder\Serializard\Tests\Fake\Inheritance;
+
+class FakeClassParentParent
+{
+    private $parentParentProperty;
+
+    public function __construct($property)
+    {
+        $this->parentParentProperty = $property;
+    }
+
+    public function getParentParentProperty()
+    {
+        return $this->parentParentProperty;
+    }
+}

tests/NormalizerTest.php

@@ -2,6 +2,7 @@
 namespace Thunder\Serializard\Tests;
 
 use Thunder\Serializard\Normalizer\ReflectionNormalizer;
+use Thunder\Serializard\Tests\Fake\Inheritance\FakeClass;
 use Thunder\Serializard\Tests\Fake\FakeTag;
 use Thunder\Serializard\Tests\Fake\FakeUser;
 
@@ -17,4 +18,15 @@ public function testReflectionSkip()
 
         $this->assertSame(array('id' => 12, 'name' => 'XXX'), $normalizer($object));
     }
+
+    public function testReflectionInheritance()
+    {
+        $normalizer = new ReflectionNormalizer();
+
+        $this->assertSame(array(
+            'property' => 'property',
+            'parentProperty' => 'parent',
+            'parentParentProperty' => 'parentParent',
+        ), $normalizer(new FakeClass('parentParent', 'parent', 'property')));
+    }
 }