Research: a Rivine address can be recreated from a stellar one if created from the same private key

Author: robvanmieghem

research/stellar/examples/accounts/convert.go

@@ -6,6 +6,7 @@ import (
 	"fmt"
 
 	"github.com/stellar/go/keypair"
+	"github.com/stellar/go/strkey"
 
 	"github.com/threefoldtech/rivine/crypto"
 	"github.com/threefoldtech/rivine/modules"
@@ -30,13 +31,12 @@ func main() {
 	if err != nil {
 		panic("ERROR hashing the seed and the index")
 	}
-	fmt.Printf("Rivine and stellar private key: %x\n", h)
+	fmt.Printf("Private key (1st one generated from the seed): %x\n", h[:])
 	//Rivine
-	rawrivinePublicKey, rawrivineSecretKey, err := ed25519.GenerateKey(bytes.NewReader(h[:]))
+	rawrivinePublicKey, _, err := ed25519.GenerateKey(bytes.NewReader(h[:]))
 	if err != nil {
 		panic("ERROR generating the ed25519 key")
 	}
-	fmt.Printf("Generated rivine ed25519 private key (len=%d): %x\n", len(rawrivineSecretKey), rawrivineSecretKey)
 	var rivinePublicKey crypto.PublicKey
 	copy(rivinePublicKey[:], rawrivinePublicKey)
 	rivineUnlockHash, err := types.NewEd25519PubKeyUnlockHash(rivinePublicKey)
@@ -50,7 +50,18 @@ func main() {
 	if err != nil {
 		panic("ERROR generating the stellar keypair ")
 	}
-	fmt.Println("Stellar Seed:", stellarKeypair.Seed())
-	fmt.Println("Stellar address:", stellarKeypair.Address())
+	stellarSeed := stellarKeypair.Seed()
+	fmt.Println("Stellar Seed:", stellarSeed)
+	stellarAddress := stellarKeypair.Address()
+	fmt.Println("Stellar address:", stellarAddress)
 
+	//Back to Rivine
+	decodedStellarPK := strkey.MustDecode(strkey.VersionByteAccountID, stellarAddress)
+	copy(rivinePublicKey[:], decodedStellarPK)
+
+	rivineFromstellarUnlockHash, err := types.NewEd25519PubKeyUnlockHash(rivinePublicKey)
+	if err != nil {
+		panic("ERROR generating the rivine unlockhash from the decoded stellar address")
+	}
+	fmt.Println("Rivine address from Stellar address:", rivineFromstellarUnlockHash.String())
 }

research/stellar/examples/accounts/readme.md

@@ -24,7 +24,7 @@ To run:
 
 - transfer.go
 
-Tranfers an amount from an account to a destination address
+Transfers an amount from an account to a destination address
 
 ## Rivine key conversion
 
@@ -33,10 +33,10 @@ Rivine hashes the public key along with the key alorithm to create an unlockhash
 
 Stellar also uses uses default ed25519 keys.
 A Stellar seed is just a base32 encoded concatatantion of a versionbyte, a 32byte private key and a checksum.
-An address is the rawseed used to create an ed25519 keypair after which the versionbyte is concatenated with a checksum  and base32 encoded.
+An address is the rawseed used to create an ed25519 keypair after which the versionbyte is concatenated with the public key and a checksum and base32 encoded.
 
 The same 32 bytes can be used to create Rivine and Stellar keypairs.
 
-It is possible to go from a Stellar account address to a Rivine "01"-address but not the reverse.
+It is possible to go from a Stellar account address to a Rivine "01"-address if they are created using the same private key (ed25519 entropy) but not the reverse.
 
 `convert.go`