Commenting on PR: feedback and suggestions

[dmitriz]

I'd like to provide feedback on the recent PR comment by ABC:

dmitriz/gently-copy#79 (comment)

I find it literally repeating Codacy comments, which are already displayed in the Checks.
In that respect, ABC does not add any valuable information to the PR.

But more importantly, this PR is submitted by a first-time contributor to this repo and may find comments not particularly friendly right there in the thread, rather than humbly hidden in the Checks as Codacy does.

I would suggest to ABC to use the Checks and only provide information that is new.

Another issue I have with ABC comment is that it does not provide me any link to the ABC-related page e.g. Dashboard to control the settings. Also linking Dashboard directly from the Github marketplace would help a lot to find it.

[mspiegel]

Thank you for the feedback! The suggestion to link the dashboard from the GitHub marketplace was very helpful! I've updated the listing in the marketplace to include the link.

I must admit I have less experience with the newer GitHub Checks and more experience with the older GitHub Status Checks. The goal of the Always Be Closing "failing status check notification" is to notify the author of the pull request that some checks are failing on their pull request. GitHub does not send an email notification when a status check fails but it does send an email on a pull request comment.

I will familiarize myself with some services that provide GitHub checks. Maybe the ABC bot doesn't need to post a pull request comment for GitHub Checks.

[dmitriz]

Thank you for the feedback! The suggestion to link the dashboard from the GitHub marketplace was very helpful! I've updated the listing in the marketplace to include the link.

You are welcome, happy to help!

The goal of the Always Be Closing "failing status check notification" is to notify the author of the pull request that some checks are failing on their pull request. GitHub does not send an email notification when a status check fails but it does send an email on a pull request comment.

In my case this was only code styling check by Codacy that I regard as advisory.
Many of their checks are helpful but many others aren't and I have yet to tune them off.
In any case, I wouldn't put them in the same category as some critical security or test failing checks.

GitHub does not send an email notification when a status check fails but it does send an email on a pull request comment.

Actually I am receiving emails from Codacy.