From 59551b47e48d3c6e12f64204258f292db16c6264 Mon Sep 17 00:00:00 2001 From: ConnorClancyDeakin Date: Sun, 27 Jul 2025 21:35:02 +1000 Subject: [PATCH 1/5] Added to json unit test to include set/read number in float and double --- coresdk/src/test/unit_tests/unit_test_json.cpp | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/coresdk/src/test/unit_tests/unit_test_json.cpp b/coresdk/src/test/unit_tests/unit_test_json.cpp index f6bc1b98..ef9ba318 100644 --- a/coresdk/src/test/unit_tests/unit_test_json.cpp +++ b/coresdk/src/test/unit_tests/unit_test_json.cpp @@ -117,7 +117,18 @@ TEST_CASE("json can be created and read", "[json]") REQUIRE("#00ff00ff" == color_to_string(deserialized_clr)); } + SECTION("Json can be created and read with different number types") + { + json number_types = create_json(); + + json_set_number(number_types, "float", static_cast(21.2)); + json_set_number(number_types, "double", static_cast(30.1)); + REQUIRE(json_read_number(number_types, "float") == static_cast(21.2)); + REQUIRE(json_read_number_as_double(number_types, "double") == static_cast(30.1)); + + free_json(number_types); + } free_json(person); free_all_json(); } \ No newline at end of file From 1add3e3366711d1ccb71daa19069c0cf6a798bd0 Mon Sep 17 00:00:00 2001 From: ConnorClancyDeakin Date: Sun, 10 Aug 2025 22:21:21 +1000 Subject: [PATCH 2/5] Fixed capitilisation of json to match rest of test --- coresdk/src/test/unit_tests/unit_test_json.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/coresdk/src/test/unit_tests/unit_test_json.cpp b/coresdk/src/test/unit_tests/unit_test_json.cpp index ef9ba318..d6cd5aa2 100644 --- a/coresdk/src/test/unit_tests/unit_test_json.cpp +++ b/coresdk/src/test/unit_tests/unit_test_json.cpp @@ -117,7 +117,7 @@ TEST_CASE("json can be created and read", "[json]") REQUIRE("#00ff00ff" == color_to_string(deserialized_clr)); } - SECTION("Json can be created and read with different number types") + SECTION("json can be created and read with different number types") { json number_types = create_json(); From f76ace52f01b1e2a62de31494897f235a9ff4859 Mon Sep 17 00:00:00 2001 From: ConnorClancyDeakin Date: Sat, 20 Sep 2025 22:32:10 +1000 Subject: [PATCH 3/5] Update coresdk/src/test/unit_tests/unit_test_json.cpp Co-authored-by: Daniel Carroll <6995669+dijidiji@users.noreply.github.com> --- coresdk/src/test/unit_tests/unit_test_json.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/coresdk/src/test/unit_tests/unit_test_json.cpp b/coresdk/src/test/unit_tests/unit_test_json.cpp index d6cd5aa2..c908a626 100644 --- a/coresdk/src/test/unit_tests/unit_test_json.cpp +++ b/coresdk/src/test/unit_tests/unit_test_json.cpp @@ -124,8 +124,8 @@ TEST_CASE("json can be created and read", "[json]") json_set_number(number_types, "float", static_cast(21.2)); json_set_number(number_types, "double", static_cast(30.1)); - REQUIRE(json_read_number(number_types, "float") == static_cast(21.2)); - REQUIRE(json_read_number_as_double(number_types, "double") == static_cast(30.1)); + REQUIRE_THAT(json_read_number(number_types, "float"), WithinRel(21.2f)); + REQUIRE_THAT(json_read_number_as_double(number_types, "double"), WithinRel(30.1)); free_json(number_types); } From d1cfc437d7bd8d2a0748ebdeeaa72f84f48f0cd5 Mon Sep 17 00:00:00 2001 From: ConnorClancyDeakin Date: Sat, 20 Sep 2025 22:32:23 +1000 Subject: [PATCH 4/5] Update coresdk/src/test/unit_tests/unit_test_json.cpp Co-authored-by: Daniel Carroll <6995669+dijidiji@users.noreply.github.com> --- coresdk/src/test/unit_tests/unit_test_json.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/coresdk/src/test/unit_tests/unit_test_json.cpp b/coresdk/src/test/unit_tests/unit_test_json.cpp index c908a626..73e83116 100644 --- a/coresdk/src/test/unit_tests/unit_test_json.cpp +++ b/coresdk/src/test/unit_tests/unit_test_json.cpp @@ -117,7 +117,7 @@ TEST_CASE("json can be created and read", "[json]") REQUIRE("#00ff00ff" == color_to_string(deserialized_clr)); } - SECTION("json can be created and read with different number types") +TEST_CASE("json can be created and read with different number types", "[json_read_number][json_read_number_as_double]") { json number_types = create_json(); From 8bef975b259b29d30672f56cc4489e3686c70dbf Mon Sep 17 00:00:00 2001 From: ConnorClancyDeakin Date: Sat, 20 Sep 2025 22:32:31 +1000 Subject: [PATCH 5/5] Update coresdk/src/test/unit_tests/unit_test_json.cpp Co-authored-by: Daniel Carroll <6995669+dijidiji@users.noreply.github.com> --- coresdk/src/test/unit_tests/unit_test_json.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/coresdk/src/test/unit_tests/unit_test_json.cpp b/coresdk/src/test/unit_tests/unit_test_json.cpp index 73e83116..1f011a8f 100644 --- a/coresdk/src/test/unit_tests/unit_test_json.cpp +++ b/coresdk/src/test/unit_tests/unit_test_json.cpp @@ -121,8 +121,8 @@ TEST_CASE("json can be created and read with different number types", "[json_rea { json number_types = create_json(); - json_set_number(number_types, "float", static_cast(21.2)); - json_set_number(number_types, "double", static_cast(30.1)); + json_set_number(number_types, "float", 21.2f); + json_set_number(number_types, "double", 30.1); REQUIRE_THAT(json_read_number(number_types, "float"), WithinRel(21.2f)); REQUIRE_THAT(json_read_number_as_double(number_types, "double"), WithinRel(30.1));