From 0f25faacf7403739618b057ff868fa08674234e0 Mon Sep 17 00:00:00 2001 From: mannat2634 Date: Sun, 21 Dec 2025 23:48:27 +1100 Subject: [PATCH 1/2] refactor: added new reference and removed old ones --- src/app/doubtfire-angularjs.module.ts | 1 - src/app/doubtfire.states.ts | 17 ++++++++++++++++- src/app/projects/states/states.coffee | 1 - 3 files changed, 16 insertions(+), 3 deletions(-) diff --git a/src/app/doubtfire-angularjs.module.ts b/src/app/doubtfire-angularjs.module.ts index 4855d04ad6..c7056f1bbe 100644 --- a/src/app/doubtfire-angularjs.module.ts +++ b/src/app/doubtfire-angularjs.module.ts @@ -53,7 +53,6 @@ import 'build/src/app/config/routing/routing.js'; import 'build/src/app/config/vendor-dependencies/vendor-dependencies.js'; import 'build/src/app/config/analytics/analytics.js'; import 'build/src/app/projects/projects.js'; -import 'build/src/app/projects/states/groups/groups.js'; import 'build/src/app/projects/states/feedback/feedback.js'; import 'build/src/app/projects/states/states.js'; import 'build/src/app/projects/states/dashboard/directives/student-task-list/student-task-list.js'; diff --git a/src/app/doubtfire.states.ts b/src/app/doubtfire.states.ts index 9f3da83c84..bc40856663 100644 --- a/src/app/doubtfire.states.ts +++ b/src/app/doubtfire.states.ts @@ -17,7 +17,7 @@ import { Ng2ViewDeclaration } from '@uirouter/angular'; import { TutorialsComponent } from './projects/states/tutorials/tutorials.component'; import {PortfoliosComponent} from './units/states/portfolios/portfolios.component'; import { RolloverComponent } from './units/states/rollover/rollover.component'; - +import { ProjectGroupsComponent } from './projects/states/groups/project-groups/project-groups.component'; /* * Use this file to store any states that are sourced by angular components. */ @@ -456,6 +456,20 @@ const PortfoliosState: NgHybridStateDeclaration = { }, }; +const ProjectGroupsState: NgHybridStateDeclaration = { + name: 'projects/groups', + parent: 'projects2', + url: '/groups', + views: { + projectView: { + component: ProjectGroupsComponent, + }, + }, + data: { + task: 'Groups List', + pageTitle: 'Unit Groups', + }, +}; const RolloverState: NgHybridStateDeclaration = { name: 'units/rollover', @@ -505,4 +519,5 @@ export const doubtfireStates = [ TutorialState, PortfoliosState, RolloverState, + ProjectGroupsState, ]; diff --git a/src/app/projects/states/states.coffee b/src/app/projects/states/states.coffee index a2a24c4bc4..6e0658da58 100644 --- a/src/app/projects/states/states.coffee +++ b/src/app/projects/states/states.coffee @@ -2,6 +2,5 @@ angular.module('doubtfire.projects.states', [ 'doubtfire.projects.states.index' 'doubtfire.projects.states.dashboard' 'doubtfire.projects.states.portfolio' - 'doubtfire.projects.states.groups' 'doubtfire.projects.states.outcomes' ]) From 2d7eece40c5f7d904e66fdddacc1dee15df28640 Mon Sep 17 00:00:00 2001 From: mannat2634 Date: Sun, 21 Dec 2025 23:54:10 +1100 Subject: [PATCH 2/2] refactor: fixed unwrapping of new data format inside child components --- .../groups/project-groups/project-groups.component.html | 6 +++--- .../groups/project-groups/project-groups.component.ts | 5 ++--- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/src/app/projects/states/groups/project-groups/project-groups.component.html b/src/app/projects/states/groups/project-groups/project-groups.component.html index 6468b85e39..8594f92ffe 100644 --- a/src/app/projects/states/groups/project-groups/project-groups.component.html +++ b/src/app/projects/states/groups/project-groups/project-groups.component.html @@ -1,6 +1,6 @@ -
- @if (unit.hasGroupwork()) { - +
+ @if (project.unit.hasGroupwork()) { + } @else {
diff --git a/src/app/projects/states/groups/project-groups/project-groups.component.ts b/src/app/projects/states/groups/project-groups/project-groups.component.ts index 9969bd6ceb..8eace41f91 100644 --- a/src/app/projects/states/groups/project-groups/project-groups.component.ts +++ b/src/app/projects/states/groups/project-groups/project-groups.component.ts @@ -1,6 +1,6 @@ import {Component, Input} from '@angular/core'; import {GroupSet, Project} from 'src/app/api/models/doubtfire-model'; -import {Unit} from 'src/app/api/models/unit'; +import { Observable } from 'rxjs'; // This component is only displayed to students (projects) @Component({ @@ -9,7 +9,6 @@ import {Unit} from 'src/app/api/models/unit'; styleUrl: './project-groups.component.scss', }) export class ProjectGroupsComponent { - @Input() unit: Unit; - @Input() project: Project; + @Input() project$: Observable; @Input() selectedGroupSet: GroupSet; }