Merge pull request #37 from lepidus/main

Feature/use ROR ID to assign Thoth affiliations

Author: thiagolepidus

README.md

@@ -34,7 +34,8 @@ This is required to use the API credentials provided, that are stored encrypted
 ### Guidelines
 
 - Only basic HTML tags are preserved (`<strong>`, `<mark>`, `<em>`, `<i>`, `<u>`, `<sup>`, `<sub>`, `<ul>`, `<ol>` and `<li>`); all others will be removed
-- ISBN must be properly formatted (e.g., 978-3-16-148410-0)
+- ISBN must be properly formatted (e.g., 978-3-16-148410-0).
+- To avoid incorrect assignment of affiliations in Thoth, is required the use of the [ROR plugin](https://github.com/withanage/ror) to fill the affiliations in OMP.
 
 ### Configuration
 

classes/services/ThothAffiliationService.inc.php

@@ -25,9 +25,9 @@ public function __construct($repository)
         $this->repository = $repository;
     }
 
-    public function register($affiliation, $thothContributionId)
+    public function register($rorId, $thothContributionId)
     {
-        $thothInstitution = ThothRepository::institution()->find($affiliation);
+        $thothInstitution = ThothRepository::institution()->find($rorId);
 
         if ($thothInstitution === null) {
             return null;

classes/services/ThothContributionService.inc.php

@@ -48,8 +48,8 @@ public function register($author, $thothWorkId, $primaryContactId = null)
 
         $thothContributionId = $this->repository->add($thothContribution);
 
-        if ($affiliation = $author->getLocalizedAffiliation()) {
-            ThothService::affiliation()->register($affiliation, $thothContributionId);
+        if ($rorId = $author->getData('rorId')) {
+            ThothService::affiliation()->register($rorId, $thothContributionId);
         }
 
         return $thothContributionId;

docs/README-es.md

@@ -34,7 +34,8 @@ Esto es necesario para utilizar las credenciales de la API proporcionadas, que s
 ### Orientaciones
 
 - Solo se conservan las etiquetas HTML básicas (`<strong>`, `<mark>`, `<em>`, `<i>`, `<u>`, `<sup>`, `<sub>`, `<ul>`, `<ol>` y `<li>`); todas las demás serán eliminadas
-- El ISBN debe estar correctamente formateado (por ejemplo, 978-3-16-148410-0)
+- El ISBN debe estar correctamente formateado (por ejemplo, 978-3-16-148410-0).
+- Para evitar la asignación incorrecta de afiliaciones en Thoth, se requiere el uso del [plugin ROR](https://github.com/withanage/ror) para completar las afiliaciones en OMP.
 
 ### Configuración
 

docs/README-pt_BR.md

@@ -34,7 +34,8 @@ Isso é necessário para usar as credenciais da API fornecidas, que são armazen
 ### Orientações
 
 - Apenas tags básicas de HTML são preservadas (`<strong>`, `<mark>`, `<em>`, `<i>`, `<u>`, `<sup>`, `<sub>`, `<ul>`, `<ol>` e `<li>`); todas as outras serão removidas
-- O ISBN deve estar devidamente formatado (por exemplo, 978-3-16-148410-0)
+- O ISBN deve estar devidamente formatado (por exemplo, 978-3-16-148410-0).
+- Para evitar a atribuição incorreta de afiliações no Thoth, é necessário o uso do [plugin ROR](https://github.com/withanage/ror) para preencher as afiliações no OMP.
 
 ### Configuração
 

tests/classes/services/ThothAffiliationServiceTest.php

@@ -60,11 +60,11 @@ public function testRegisterAffiliation()
             ->method('add')
             ->will($this->returnValue('43f98edb-ac8c-45b4-9faa-2941a05c133c'));
 
-        $affiliation = 'My Affiliation Institution';
+        $rorId = 'https://ror.org/00101234';
         $thothContributionId = '7315563c-e5c3-40b2-8558-8d1f9cede901';
 
         $service = new ThothAffiliationService($mockRepository);
-        $thothAffiliationId = $service->register($affiliation, $thothContributionId);
+        $thothAffiliationId = $service->register($rorId, $thothContributionId);
 
         $this->assertSame('43f98edb-ac8c-45b4-9faa-2941a05c133c', $thothAffiliationId);
     }

version.xml

@@ -3,7 +3,7 @@
 <version>
 	<application>thoth</application>
 	<type>plugins.generic</type>
-	<release>0.2.7.0</release>
+	<release>0.2.8.0</release>
 	<date>2025-05-01</date>
 	<lazy-load>1</lazy-load>
 	<class>ThothPlugin</class>