test: add tests to improve test coverage

Author: brianheineman

postgresql_archive/src/repository/github/repository.rs

@@ -368,6 +368,26 @@ mod tests {
         assert_eq!("GitHub", github.name());
     }
 
+    #[test]
+    fn test_get_version_from_tag_name() -> Result<()> {
+        let versions = vec!["16.3.0", "v16.3.0"];
+        for version in versions {
+            let version = GitHub::get_version_from_tag_name(version)?;
+            assert_eq!(Version::new(16, 3, 0), version);
+        }
+
+        Ok(())
+    }
+
+    #[test]
+    fn test_get_version_from_tag_name_error() {
+        let error = GitHub::get_version_from_tag_name("foo").unwrap_err();
+        assert_eq!(
+            "empty string, expected a semver version".to_string(),
+            error.to_string()
+        );
+    }
+
     //
     // get_version tests
     //

postgresql_archive/src/version.rs

@@ -16,19 +16,14 @@ impl ExactVersion for VersionReq {
         if self.comparators.len() != 1 {
             return None;
         }
-
-        if let Some(comparator) = self.comparators.first() {
-            if comparator.op != semver::Op::Exact {
-                return None;
-            }
-            let minor = comparator.minor?;
-            let patch = comparator.patch?;
-
-            let version = Version::new(comparator.major, minor, patch);
-            return Some(version);
+        let comparator = self.comparators.first()?;
+        if comparator.op != semver::Op::Exact {
+            return None;
         }
-
-        None
+        let minor = comparator.minor?;
+        let patch = comparator.patch?;
+        let version = Version::new(comparator.major, minor, patch);
+        Some(version)
     }
 }
 
@@ -99,6 +94,13 @@ mod tests {
         Ok(())
     }
 
+    #[test]
+    fn test_exact_version_range() -> Result<()> {
+        let version_req = VersionReq::parse(">= 16, < 17")?;
+        assert_eq!(None, version_req.exact_version());
+        Ok(())
+    }
+
     #[test]
     fn test_exact_version_req_not_equal() -> Result<()> {
         let version = Version::new(1, 2, 3);