From 0a9322e25f1aaa07a6e47c4a8a19d8cab16340a9 Mon Sep 17 00:00:00 2001 From: Jeff Larson Date: Fri, 24 Apr 2026 01:55:48 -0700 Subject: [PATCH] Remove spurious '--' in git diff ref arg git diff --name-only --diff-filter=ACMR -- treats as a path (not a ref) because of the --. The match returns empty, so diff-mode always short-circuited with 'No changed files. Nothing to review.' Every PR-triggered and push-triggered run under the action was a silent no-op. Co-Authored-By: Claude Opus 4.7 (1M context) --- scripts/security-review-action.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/security-review-action.py b/scripts/security-review-action.py index b981ae8..18031ba 100644 --- a/scripts/security-review-action.py +++ b/scripts/security-review-action.py @@ -63,7 +63,7 @@ def get_changed_files(repo_dir: Path, diff_base: str) -> list[str]: return [] try: result = subprocess.run( - ["git", "diff", "--name-only", "--diff-filter=ACMR", "--", diff_base], + ["git", "diff", "--name-only", "--diff-filter=ACMR", diff_base], capture_output=True, text=True, cwd=repo_dir, timeout=GIT_DIFF_TIMEOUT, )