fix: avoid SwiftUI publishes when exiting url bar edit mode

Author: yonaries

ora/Features/Browser/URLBar/URLBar.swift

@@ -83,7 +83,7 @@ struct URLBar: View {
 
     private func setupInlineLauncher() {
         suppressInitialSearch = true
-        if let tab = tabManager.activeTab {
+        if launcherInput.isEmpty, let tab = tabManager.activeTab {
             launcherInput = tab.url.absoluteString
         }
         launcherViewModel.searchEngineService.setTheme(theme)
@@ -119,18 +119,26 @@ struct URLBar: View {
     }
 
     private func cleanupInlineLauncher() {
-        isLauncherFocused = false
-        launcherInput = ""
-        launcherViewModel.suggestions = []
         if let monitor = mouseMonitor {
             NSEvent.removeMonitor(monitor)
             mouseMonitor = nil
         }
+        DispatchQueue.main.async {
+            guard !appState.isURLBarEditing else { return }
+            isLauncherFocused = false
+            mouseHasMoved = false
+            suppressInitialSearch = false
+            launcherInput = ""
+            launcherViewModel.reset()
+        }
     }
 
     private func dismissEditing() {
-        withAnimation(.easeOut(duration: 0.2)) {
-            appState.isURLBarEditing = false
+        DispatchQueue.main.async {
+            guard appState.isURLBarEditing else { return }
+            withAnimation(.easeOut(duration: 0.2)) {
+                appState.isURLBarEditing = false
+            }
         }
     }
 
@@ -256,13 +264,6 @@ struct URLBar: View {
             .onChange(of: tabManager.activeTab?.id) { _, _ in
                 if isEditing { dismissEditing() }
             }
-            .onChange(of: appState.isURLBarEditing) { _, newValue in
-                if newValue {
-                    setupInlineLauncher()
-                } else {
-                    cleanupInlineLauncher()
-                }
-            }
             .onChange(of: appState.showLauncher) { _, newValue in
                 // Dismiss URL bar editing if the center launcher is opened
                 if newValue, isEditing { dismissEditing() }
@@ -394,6 +395,12 @@ struct URLBar: View {
                 return .handled
             }
         }
+        .onAppear {
+            setupInlineLauncher()
+        }
+        .onDisappear {
+            cleanupInlineLauncher()
+        }
         .frame(height: 30)
         .padding(.horizontal, 8)
         .frame(maxWidth: .infinity, alignment: .leading)

ora/Features/Browser/Views/BrowserWebContentView.swift

@@ -35,7 +35,9 @@ struct BrowserWebContentView: View {
                         .frame(maxWidth: .infinity, maxHeight: .infinity)
                         .contentShape(Rectangle())
                         .onTapGesture {
-                            appState.isURLBarEditing = false
+                            DispatchQueue.main.async {
+                                appState.isURLBarEditing = false
+                            }
                         }
                         .transition(.opacity)
                 }

ora/Features/Launcher/Main/LauncherTextField.swift

@@ -15,13 +15,35 @@ struct LauncherTextField: NSViewRepresentable {
     class CustomTextField: NSTextField {
         var cursorColor: NSColor?
 
+        private func configureEditorIfNeeded() {
+            guard let textView = currentEditor() as? NSTextView else { return }
+            if let color = cursorColor {
+                textView.insertionPointColor = color
+            }
+            textView.isHorizontallyResizable = true
+            textView.isVerticallyResizable = false
+            textView.textContainerInset = .zero
+            textView.textContainer?.widthTracksTextView = false
+            textView.textContainer?.containerSize = NSSize(
+                width: .greatestFiniteMagnitude,
+                height: bounds.height
+            )
+            textView.textContainer?.lineBreakMode = .byClipping
+            textView.textContainer?.maximumNumberOfLines = 1
+        }
+
         override func becomeFirstResponder() -> Bool {
             let didBecome = super.becomeFirstResponder()
-            if didBecome, let textView = currentEditor() as? NSTextView, let color = cursorColor {
-                textView.insertionPointColor = color
+            if didBecome {
+                configureEditorIfNeeded()
             }
             return didBecome
         }
+
+        override func textDidBeginEditing(_ notification: Notification) {
+            super.textDidBeginEditing(notification)
+            configureEditorIfNeeded()
+        }
     }
 
     func makeCoordinator() -> Coordinator {
@@ -37,33 +59,56 @@ struct LauncherTextField: NSViewRepresentable {
         textField.focusRingType = .none
         textField.drawsBackground = false
         textField.placeholderString = placeholder
+        textField.lineBreakMode = .byClipping
+        textField.maximumNumberOfLines = 1
+        textField.usesSingleLineMode = true
+        textField.cell?.wraps = false
+        textField.cell?.isScrollable = true
         if let textColor {
             textField.textColor = NSColor(textColor)
         }
         return textField
     }
 
     func updateNSView(_ nsView: CustomTextField, context: Context) {
-        nsView.stringValue = text
+        if nsView.stringValue != text {
+            // Prevent the AppKit delegate callback from bouncing this write
+            // straight back into SwiftUI during the same update pass.
+            context.coordinator.isProgrammaticUpdate = true
+            nsView.stringValue = text
+            context.coordinator.isProgrammaticUpdate = false
+        }
         nsView.cursorColor = NSColor(cursorColor)
         nsView.placeholderString = placeholder
         if let textColor {
             nsView.textColor = NSColor(textColor)
         }
         if let textView = nsView.currentEditor() as? NSTextView {
             textView.insertionPointColor = nsView.cursorColor
+            textView.isHorizontallyResizable = true
+            textView.isVerticallyResizable = false
+            textView.textContainerInset = .zero
+            textView.textContainer?.widthTracksTextView = false
+            textView.textContainer?.containerSize = NSSize(
+                width: .greatestFiniteMagnitude,
+                height: nsView.bounds.height
+            )
+            textView.textContainer?.lineBreakMode = .byClipping
+            textView.textContainer?.maximumNumberOfLines = 1
         }
     }
 
     class Coordinator: NSObject, NSTextFieldDelegate {
         var parent: LauncherTextField
+        var isProgrammaticUpdate = false
 
         init(_ parent: LauncherTextField) {
             self.parent = parent
         }
 
         func controlTextDidChange(_ obj: Notification) {
-            if let textField = obj.object as? NSTextField {
+            guard !isProgrammaticUpdate else { return }
+            if let textField = obj.object as? NSTextField, parent.text != textField.stringValue {
                 parent.text = textField.stringValue
             }
         }

ora/Features/Launcher/Suggestions/LauncherSuggestionItem.swift

@@ -132,8 +132,10 @@ struct LauncherSuggestionItem: View {
         .clipShape(ConditionallyConcentricRectangle(cornerRadius: 12, style: .continuous))
         .onTapGesture {
             suggestion.action()
-            appState.showLauncher = false
-            appState.isURLBarEditing = false
+            DispatchQueue.main.async {
+                appState.showLauncher = false
+                appState.isURLBarEditing = false
+            }
         }
         .onHover { hover in
             if hover, mouseHasMoved {